Skip to content

Commit 5885d88

Browse files
committed
refactor(sdk-core): remove vssProof from Eddsa singing
Removed vssProof from MPC Eddsa signing is not needed and not being used WP-3393 TICKET: WP-3393
1 parent b70bcb3 commit 5885d88

File tree

3 files changed

+1
-26
lines changed

3 files changed

+1
-26
lines changed

modules/bitgo/test/v2/unit/tss/eddsa.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -561,10 +561,6 @@ describe('test tss helper functions', function () {
561561
validUserSignShare,
562562
'signerShare',
563563
undefined,
564-
undefined,
565-
undefined,
566-
undefined,
567-
undefined,
568564
reqId
569565
).should.be.fulfilled();
570566
nock.isDone().should.equal(true);

modules/sdk-core/src/bitgo/tss/eddsa/eddsa.ts

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -203,10 +203,6 @@ export async function offerUserToBitgoRShare(
203203
userSignShare: SignShare,
204204
encryptedSignerShare: string,
205205
apiMode: 'full' | 'lite' = 'lite',
206-
vssProof?: string,
207-
privateShareProof?: string,
208-
userPublicGpgKey?: string,
209-
publicShare?: string,
210206
reqId?: IRequestTracer
211207
): Promise<void> {
212208
const rShare: RShare = userSignShare.rShares[ShareKeyPosition.BITGO];
@@ -220,9 +216,6 @@ export async function offerUserToBitgoRShare(
220216
from: SignatureShareType.USER,
221217
to: SignatureShareType.BITGO,
222218
share: rShare.r + rShare.R,
223-
vssProof,
224-
privateShareProof,
225-
publicShare,
226219
};
227220

228221
// TODO (BG-57944): implement message signing for EDDSA
@@ -235,7 +228,7 @@ export async function offerUserToBitgoRShare(
235228
encryptedSignerShare,
236229
'eddsa',
237230
apiMode,
238-
userPublicGpgKey,
231+
undefined,
239232
reqId
240233
);
241234
}

modules/sdk-core/src/bitgo/utils/tss/eddsa/eddsa.ts

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -527,10 +527,6 @@ export class EddsaUtils extends baseTSSUtils<KeyShare> {
527527
rShare,
528528
encryptedSignerShare.share,
529529
apiVersion,
530-
undefined,
531-
undefined,
532-
undefined,
533-
undefined,
534530
reqId
535531
);
536532
const bitgoToUserRShare = await getBitgoToUserRShare(this.bitgo, this.wallet.id(), txRequestId, reqId);
@@ -596,12 +592,6 @@ export class EddsaUtils extends baseTSSUtils<KeyShare> {
596592
const bitgoGpgKey = await this.pickBitgoPubGpgKeyForSigning(false, params.reqId, txRequestResolved.enterpriseId);
597593
const userToBitgoEncryptedSignerShare = await encryptText(signerShare, bitgoGpgKey);
598594

599-
const userGpgKey = await generateGPGKeyPair('secp256k1');
600-
const privateShareProof = await createShareProof(userGpgKey.privateKey, signingKey.yShares[bitgoIndex].u, 'eddsa');
601-
const vssProof = signingKey.yShares[bitgoIndex].v;
602-
const userPublicGpgKey = userGpgKey.publicKey;
603-
const publicShare = signingKey.yShares[bitgoIndex].y + signingKey.yShares[bitgoIndex].chaincode;
604-
605595
const userToBitgoCommitment = userSignShare.rShares[bitgoIndex].commitment;
606596
assert(userToBitgoCommitment, 'Missing userToBitgoCommitment commitment');
607597

@@ -625,10 +615,6 @@ export class EddsaUtils extends baseTSSUtils<KeyShare> {
625615
userSignShare,
626616
userToBitgoEncryptedSignerShare,
627617
apiVersion,
628-
vssProof,
629-
privateShareProof,
630-
userPublicGpgKey,
631-
publicShare,
632618
params.reqId
633619
);
634620

0 commit comments

Comments
 (0)