Merge pull request #5751 from BitGo/DX-1125-remove-bluebird-from-abstract-utxo

refactor(abstract-utxo): replace bluebird with native promises

Author: davidkaplanbitgo

modules/abstract-utxo/package.json

@@ -49,12 +49,10 @@
     "@bitgo/utxo-core": "^1.5.0",
     "@bitgo/utxo-lib": "^11.2.4",
     "@bitgo/wasm-miniscript": "2.0.0-beta.7",
-    "@types/bluebird": "^3.5.25",
     "@types/lodash": "^4.14.121",
     "@types/superagent": "4.1.15",
     "bignumber.js": "^9.0.2",
     "bitcoinjs-message": "npm:@bitgo-forks/[email protected]",
-    "bluebird": "^3.5.3",
     "debug": "^3.1.0",
     "io-ts": "npm:@bitgo-forks/[email protected]",
     "lodash": "^4.17.14",

modules/abstract-utxo/src/recovery/crossChainRecovery.ts

@@ -1,4 +1,3 @@
-import Bluebird from 'bluebird';
 import * as utxolib from '@bitgo/utxo-lib';
 import { bip32, BIP32Interface } from '@bitgo/utxo-lib';
 import { Dimensions } from '@bitgo/unspents';
@@ -199,23 +198,26 @@ async function toWalletUnspents<TNumber extends number | bigint = number>(
   wallet: IWallet | WalletV1
 ): Promise<WalletUnspent<TNumber>[]> {
   const addresses = new Set(unspents.map((u) => u.address));
-  return (
-    await Bluebird.mapSeries(addresses, async (address): Promise<WalletUnspent<TNumber>[]> => {
-      let scriptId;
-      try {
-        scriptId = await getScriptId(recoveryCoin, wallet, utxolib.address.toOutputScript(address, sourceCoin.network));
-      } catch (e) {
-        console.error(`error getting scriptId for ${address}:`, e);
-        return [];
-      }
-      return unspents
-        .filter((u) => u.address === address)
-        .map((u) => ({
-          ...u,
-          ...scriptId,
-        }));
-    })
-  ).flat();
+  const walletUnspents: WalletUnspent<TNumber>[] = [];
+
+  for (const address of addresses) {
+    let scriptId;
+    try {
+      scriptId = await getScriptId(recoveryCoin, wallet, utxolib.address.toOutputScript(address, sourceCoin.network));
+    } catch (e) {
+      console.error(`error getting scriptId for ${address}:`, e);
+      continue;
+    }
+    const filteredUnspents = unspents
+      .filter((u) => u.address === address)
+      .map((u) => ({
+        ...u,
+        ...scriptId,
+      }));
+    walletUnspents.push(...filteredUnspents);
+  }
+
+  return walletUnspents;
 }
 
 /**