feat(utxo-lib): split sign verify tests for PSBTs and legacy transactions

Split the combined test file into two separate files - one for PSBT
operations and another for legacy transaction signing and verification.

Issue: BTC-2732

Co-authored-by: llm-git <[email protected]>

Author: OttoAllmendinger

modules/utxo-lib/test/bitgo/psbt/SignVerifyLegacy.ts

@@ -0,0 +1,56 @@
+import * as assert from 'assert';
+
+import { getStrictSignatureCount, getStrictSignatureCounts } from '../../../src/bitgo';
+import { constructTxnBuilder, TxnInput } from '../../../src/testutil';
+import { AcidTest, SignStage } from '../../../src/testutil/psbt';
+import { getNetworkList, getNetworkName, isMainnet, networks } from '../../../src';
+
+const signs = ['unsigned', 'halfsigned', 'fullsigned'] as const;
+
+function signCount(signStage: SignStage) {
+  return signStage === 'unsigned' ? 0 : signStage === 'halfsigned' ? 1 : 2;
+}
+
+function runTx(acidTest: AcidTest) {
+  const coin = getNetworkName(acidTest.network);
+  const signatureCount = signCount(acidTest.signStage);
+  describe(`tx build, sign and verify for ${coin} ${acidTest.signStage}`, function () {
+    const inputs = acidTest.inputs.filter(
+      (input): input is TxnInput<bigint> =>
+        input.scriptType !== 'taprootKeyPathSpend' && input.scriptType !== 'p2trMusig2'
+    );
+    const outputs = acidTest.outputs.filter(
+      (output) =>
+        ('scriptType' in output && output.scriptType !== undefined) ||
+        ('address' in output && output.address !== undefined)
+    );
+    it(`tx signature counts ${coin} ${acidTest.signStage}`, function () {
+      const txb = constructTxnBuilder(inputs, outputs, acidTest.network, acidTest.rootWalletKeys, acidTest.signStage);
+      const tx = acidTest.signStage === 'fullsigned' ? txb.build() : txb.buildIncomplete();
+
+      const counts = getStrictSignatureCounts(tx);
+      const countsFromIns = getStrictSignatureCounts(tx.ins);
+
+      assert.strictEqual(counts.length, tx.ins.length);
+      assert.strictEqual(countsFromIns.length, tx.ins.length);
+      tx.ins.forEach((input, inputIndex) => {
+        const expectedCount = inputs[inputIndex].scriptType === 'p2shP2pk' && signatureCount > 0 ? 1 : signatureCount;
+        assert.strictEqual(
+          getStrictSignatureCount(input),
+          expectedCount,
+          `input ${inputIndex} has ${getStrictSignatureCount(input)} signatures, expected ${expectedCount}`
+        );
+        assert.strictEqual(counts[inputIndex], expectedCount);
+        assert.strictEqual(countsFromIns[inputIndex], expectedCount);
+      });
+    });
+  });
+}
+
+signs.forEach((sign) => {
+  getNetworkList()
+    .filter((v) => isMainnet(v) && v !== networks.bitcoinsv)
+    .forEach((network) => {
+      runTx(AcidTest.withDefaults(network, sign, 'psbt'));
+    });
+});

modules/utxo-lib/test/bitgo/psbt/SignVerifyPsbtAndTx.ts renamed to modules/utxo-lib/test/bitgo/psbt/SignVerifyPsbt.ts

@@ -12,7 +12,7 @@ import {
   UtxoPsbt,
   UtxoTransaction,
 } from '../../../src/bitgo';
-import { constructTxnBuilder, Input as TestUtilInput, TxnInput } from '../../../src/testutil';
+import { Input as TestUtilInput } from '../../../src/testutil';
 import { AcidTest, InputScriptType, SignStage } from '../../../src/testutil/psbt';
 import { getNetworkList, getNetworkName, isMainnet, networks } from '../../../src';
 import {
@@ -186,48 +186,11 @@ function runPsbt(acidTest: AcidTest) {
   });
 }
 
-function runTx(acidTest: AcidTest) {
-  const coin = getNetworkName(acidTest.network);
-  const signatureCount = signCount(acidTest.signStage);
-  describe(`tx build, sign and verify for ${coin} ${acidTest.signStage}`, function () {
-    const inputs = acidTest.inputs.filter(
-      (input): input is TxnInput<bigint> =>
-        input.scriptType !== 'taprootKeyPathSpend' && input.scriptType !== 'p2trMusig2'
-    );
-    const outputs = acidTest.outputs.filter(
-      (output) =>
-        ('scriptType' in output && output.scriptType !== undefined) ||
-        ('address' in output && output.address !== undefined)
-    );
-    it(`tx signature counts ${coin} ${acidTest.signStage}`, function () {
-      const txb = constructTxnBuilder(inputs, outputs, acidTest.network, acidTest.rootWalletKeys, acidTest.signStage);
-      const tx = acidTest.signStage === 'fullsigned' ? txb.build() : txb.buildIncomplete();
-
-      const counts = getStrictSignatureCounts(tx);
-      const countsFromIns = getStrictSignatureCounts(tx.ins);
-
-      assert.strictEqual(counts.length, tx.ins.length);
-      assert.strictEqual(countsFromIns.length, tx.ins.length);
-      tx.ins.forEach((input, inputIndex) => {
-        const expectedCount = inputs[inputIndex].scriptType === 'p2shP2pk' && signatureCount > 0 ? 1 : signatureCount;
-        assert.strictEqual(
-          getStrictSignatureCount(input),
-          expectedCount,
-          `input ${inputIndex} has ${getStrictSignatureCount(input)} signatures, expected ${expectedCount}`
-        );
-        assert.strictEqual(counts[inputIndex], expectedCount);
-        assert.strictEqual(countsFromIns[inputIndex], expectedCount);
-      });
-    });
-  });
-}
-
 signs.forEach((sign) => {
   getNetworkList()
     .filter((v) => isMainnet(v) && v !== networks.bitcoinsv)
     .forEach((network) => {
       runPsbt(AcidTest.withDefaults(network, sign, 'psbt'));
       runPsbt(AcidTest.withDefaults(network, sign, 'psbt-lite'));
-      runTx(AcidTest.withDefaults(network, sign, 'psbt'));
     });
 });