Merge pull request #6811 from BitGo/coin-5408

fix: implement buildNftTransferData for vet

Author: at31416

modules/sdk-coin-vet/src/vet.ts

@@ -6,11 +6,13 @@ import {
   BaseCoin,
   BaseTransaction,
   BitGoBase,
+  BuildNftTransferDataOptions,
   InvalidAddressError,
   KeyPair,
   MPCAlgorithm,
   MultisigType,
   multisigTypes,
+  NotImplementedError,
   ParsedTransaction,
   SignedTransaction,
   SignTransactionOptions,
@@ -238,4 +240,22 @@ export class Vet extends BaseCoin {
       },
     } as unknown as Hash;
   }
+
+  buildNftTransferData(params: BuildNftTransferDataOptions): string {
+    const { recipientAddress, fromAddress } = params;
+    if (!utils.isValidAddress(recipientAddress)) {
+      throw new InvalidAddressError('Invalid recipient address');
+    }
+    if (!utils.isValidAddress(fromAddress)) {
+      throw new InvalidAddressError('Invalid from address');
+    }
+    switch (params.type) {
+      case 'ERC721': {
+        const tokenId = params.tokenId;
+        return utils.getTransferNFTData(fromAddress, recipientAddress, tokenId);
+      }
+      default:
+        throw new NotImplementedError(`NFT type ${params.type} not supported on ${this.getChain()}`);
+    }
+  }
 }

modules/sdk-coin-vet/test/resources/vet.ts

@@ -190,3 +190,6 @@ export const SERIALIZED_SIGNED_ADDRESS_INIT_TX =
 
 export const SERIALIZED_SIGNED_FLUSH_TOKEN_TX =
   '0xf89827880152cf455536ebc740f83df83b94604a42898388080d56bc85f815965d1f64beb1a680a43ef133670000000000000000000000000000000000000000000000000000456e657267798180830249f08082faf9c0b841b5225a0d5c63fd4ceee2fefe94759d20e37c29ebcd15fc03eb699d4af5bb210c258583f9e8e26e872751e255c2f0fe9d44d52ce65b6b76040476e285074a4b5901';
+
+export const VALID_NFT_CONTRACT_DATA =
+  '0x23b872dd0000000000000000000000007ca00e3bc8a836026c2917c6c7c6d049e52099dd000000000000000000000000e59f1cea4e0fef511e3d0f4eec44adf19c4cbeec00000000000000000000000000000000000000000000000000000000000004d2';

modules/sdk-coin-vet/test/unit/vet.ts

@@ -1,6 +1,7 @@
 import sinon from 'sinon';
 import assert from 'assert';
 import _ from 'lodash';
+import should from 'should';
 import { BitGoAPI } from '@bitgo/sdk-api';
 import { TestBitGo, TestBitGoAPI } from '@bitgo/sdk-test';
 import { coins, GasTankAccountCoin } from '@bitgo/statics';
@@ -109,6 +110,39 @@ describe('Vechain', function () {
         })
         .should.rejectedWith('missing required tx prebuild property txHex');
     });
+
+    it('should build correct nft transfer data', function () {
+      const data = basecoin.buildNftTransferData({
+        fromAddress: testData.addresses.validAddresses[0],
+        recipientAddress: testData.addresses.validAddresses[1],
+        type: 'ERC721',
+        tokenId: '1234',
+        tokenContractAddress: testData.NFT_CONTRACT_ADDRESS,
+      });
+      data.should.equal(testData.VALID_NFT_CONTRACT_DATA);
+    });
+
+    it('should build throw invalid address error', function () {
+      should(() =>
+        basecoin.buildNftTransferData({
+          fromAddress: testData.addresses.validAddresses[0],
+          recipientAddress: testData.addresses.invalidAddresses[0],
+          type: 'ERC721',
+          tokenId: '1234',
+          tokenContractAddress: testData.NFT_CONTRACT_ADDRESS,
+        })
+      ).throwError('Invalid recipient address');
+
+      should(() =>
+        basecoin.buildNftTransferData({
+          fromAddress: testData.addresses.invalidAddresses[0],
+          recipientAddress: testData.addresses.validAddresses[0],
+          type: 'ERC721',
+          tokenId: '1234',
+          tokenContractAddress: testData.NFT_CONTRACT_ADDRESS,
+        })
+      ).throwError('Invalid from address');
+    });
   });
 
   describe('Parse and Explain Transactions: ', () => {