Merge pull request #6116 from BitGo/COIN-3463

fix: Custodial wallets are not supported for CELO

Author: nvjsr

modules/statics/src/account.ts

@@ -2,6 +2,11 @@ import { BaseCoin, BaseUnit, CoinFeature, CoinKind, KeyCurve, UnderlyingAsset }
 import { DOMAIN_PATTERN, HEDERA_NODE_ACCCOUNT_ID } from './constants';
 import { InvalidContractAddressError, InvalidDomainError } from './errors';
 import { AccountNetwork, BaseNetwork, EthereumNetwork, Networks, TronNetwork } from './networks';
+import {
+  ACCOUNT_COIN_DEFAULT_FEATURES,
+  ACCOUNT_COIN_DEFAULT_FEATURES_EXCLUDE_SINGAPORE,
+  CELO_TOKEN_FEATURES,
+} from './coinFeatures';
 
 export interface AccountConstructorOptions {
   id: string;
@@ -27,25 +32,10 @@ export interface AccountConstructorOptions {
  * "pieces" of coin which belong to an address.
  */
 export class AccountCoin extends BaseCoin {
-  public static readonly DEFAULT_FEATURES = [
-    CoinFeature.ACCOUNT_MODEL,
-    CoinFeature.REQUIRES_BIG_NUMBER,
-    CoinFeature.VALUELESS_TRANSFER,
-    CoinFeature.TRANSACTION_DATA,
-    CoinFeature.CUSTODY,
-    CoinFeature.CUSTODY_BITGO_TRUST,
-    CoinFeature.CUSTODY_BITGO_MENA_FZE,
-    CoinFeature.CUSTODY_BITGO_CUSTODY_MENA_FZE,
-    CoinFeature.CUSTODY_BITGO_SINGAPORE,
-    CoinFeature.CUSTODY_BITGO_KOREA,
-    CoinFeature.CUSTODY_BITGO_EUROPE_APS,
-    CoinFeature.CUSTODY_BITGO_FRANKFURT,
-  ];
+  public static readonly DEFAULT_FEATURES = ACCOUNT_COIN_DEFAULT_FEATURES;
 
   // Need to gate some high risk coin from SINGAPORE trust
-  public static readonly DEFAULT_FEATURES_EXCLUDE_SINGAPORE = AccountCoin.DEFAULT_FEATURES.filter(
-    (feature) => feature !== CoinFeature.CUSTODY_BITGO_SINGAPORE
-  );
+  public static readonly DEFAULT_FEATURES_EXCLUDE_SINGAPORE = ACCOUNT_COIN_DEFAULT_FEATURES_EXCLUDE_SINGAPORE;
 
   public readonly network: AccountNetwork;
 
@@ -997,11 +987,11 @@ export function erc20CompatibleAccountCoin(
  * @param fullName Complete human-readable name of the token
  * @param decimalPlaces Number of decimal places this token supports (divisibility exponent)
  * @param contractAddress Contract address of this token
- * @param asset Asset which this coin represents. This is the same for both mainnet and testnet variants of a coin.
- * @param prefix? Optional token prefix. Defaults to empty string
- * @param suffix? Optional token suffix. Defaults to token name.
- * @param network? Optional token network. Defaults to CELO main network.
- * @param features? Features of this coin. Defaults to the DEFAULT_FEATURES defined in `AccountCoin`
+ * @param asset Asset which this coin represents. This is the same for both mainnet and testnet variants of a coin
+ * @param prefix ? Optional token prefix. Defaults to empty string
+ * @param suffix ? Optional token suffix. Defaults to token name.
+ * @param network ? Optional token network. Defaults to CELO main network.
+ * @param features ? Features of this coin. Defaults to the DEFAULT_FEATURES excluding CUSTODY feature
  * @param primaryKeyCurve The elliptic curve for this chain/token
  */
 export function celoToken(
@@ -1011,7 +1001,7 @@ export function celoToken(
   decimalPlaces: number,
   contractAddress: string,
   asset: UnderlyingAsset,
-  features: CoinFeature[] = AccountCoin.DEFAULT_FEATURES,
+  features: CoinFeature[] = CELO_TOKEN_FEATURES,
   prefix = '',
   suffix: string = name.toUpperCase(),
   network: EthereumNetwork = Networks.main.celo,
@@ -1045,10 +1035,10 @@ export function celoToken(
  * @param decimalPlaces Number of decimal places this token supports (divisibility exponent)
  * @param contractAddress Contract address of this token
  * @param asset Asset which this coin represents. This is the same for both mainnet and testnet variants of a coin.
- * @param prefix? Optional token prefix. Defaults to empty string
- * @param suffix? Optional token suffix. Defaults to token name.
- * @param network? Optional token network. Defaults to the testnet CELO network.
- * @param features? Features of this coin. Defaults to the DEFAULT_FEATURES defined in `AccountCoin`
+ * @param features ? Features of this coin. Defaults to the DEFAULT_FEATURES excluding CUSTODY feature
+ * @param prefix ? Optional token prefix. Defaults to empty string
+ * @param suffix ? Optional token suffix. Defaults to token name.
+ * @param network ? Optional token network. Defaults to the testnet CELO network.
  */
 export function tceloToken(
   id: string,
@@ -1057,7 +1047,7 @@ export function tceloToken(
   decimalPlaces: number,
   contractAddress: string,
   asset: UnderlyingAsset,
-  features: CoinFeature[] = AccountCoin.DEFAULT_FEATURES,
+  features: CoinFeature[] = CELO_TOKEN_FEATURES,
   prefix = '',
   suffix: string = name.toUpperCase(),
   network: EthereumNetwork = Networks.test.celo