Merge pull request #5776 from BitGo/COIN-3439

fix(sdk-coin-stx): fix post condition issue in fungible token transfer builder

Author: ravibitgo

modules/sdk-coin-stx/src/lib/fungibleTokenTransferBuilder.ts

@@ -39,12 +39,12 @@ export class FungibleTokenTransferBuilder extends AbstractContractBuilder {
     this.contractName(this._contractName);
     this.functionName(this._functionName);
     this.functionArgs(this._functionArgs);
-    this._postConditionMode = PostConditionMode.Deny;
-    this._postConditions = this.tokenTransferParamsToPostCondition(this._fungibleTokenTransferParams);
   }
 
   /** @inheritdoc */
   protected async buildImplementation(): Promise<Transaction> {
+    this._postConditionMode = PostConditionMode.Deny;
+    this._postConditions = this.tokenTransferParamsToPostCondition(this._fungibleTokenTransferParams);
     await super.buildImplementation();
     this.transaction.setTransactionType(TransactionType.Send);
     return this.transaction;
@@ -127,6 +127,7 @@ export class FungibleTokenTransferBuilder extends AbstractContractBuilder {
       throw new InvalidParameterValueError('Invalid number of arguments');
     }
     this._functionArgs = args;
+    this._fungibleTokenTransferParams = functionArgsToTokenTransferParams(this._functionArgs);
     return this;
   }
 

modules/sdk-coin-stx/test/fixtures.ts

@@ -34,10 +34,10 @@ export const unsignedTxExplainedTransfer = {
 };
 
 export const txForExplainFungibleTokenTransfer =
-  '808000000004012fe507c09dbb23c3b7e5d166c81fc4b87692510b000000000000000000000000000000b400000003020000f2872c232e1747af46070c191947fa2503ac364d111c30c17a7d0307c7c6792140250743d22d37f0df813d48493bf58bdc455d9d71fce8a57245d8cd17335102018627c757a1216e33c6cd06a33a48ae072b8b28f50df772aaaa57cc067fc2220f646a068ea54847638e03c0782063bd4931674cf80be805bc458e27a0d042a24700038e3c4529395611be9abf6fa3b6987e81d402385e3d605a073f42f407565a4a3d0002030200000000021a1500a1c42f0c11bfe3893f479af18904677685be0d747369703664702d746f6b656e087472616e73666572000000040100000000000000000000000000002710051a1500a1c42f0c11bfe3893f479af18904677685be0515ab50cac953ac55edc14e2b236854b1ead863fece020000000131';
+  '808000000004012fe507c09dbb23c3b7e5d166c81fc4b87692510b000000000000000000000000000000b40000000302004f1813139aad38ac90ba905885ad4822bf33b7a56fff9127780c52359edee495587008204b0a7eaf39a0ba467b54a3e1896f863559349e5142f929cc4c706cd20201ae3fa80f2900c950667d827ed3b843afc94c63179dca70e6205f7d629a5f511a0ed45137c2baa16e33753c8e672dc61182869b6304fdea7daee42d8896f1a3fd00038e3c4529395611be9abf6fa3b6987e81d402385e3d605a073f42f407565a4a3d00020302000000010102152fe507c09dbb23c3b7e5d166c81fc4b87692510b1a1500a1c42f0c11bfe3893f479af18904677685be0d747369703664702d746f6b656e0d747369703664702d746f6b656e010000000000002710021a1500a1c42f0c11bfe3893f479af18904677685be0d747369703664702d746f6b656e087472616e73666572000000040100000000000000000000000000002710051a1500a1c42f0c11bfe3893f479af18904677685be0515ab50cac953ac55edc14e2b236854b1ead863fece020000000131';
 
 export const fungibleTokenTransferTx = {
-  id: '992f26de0f8ebb56bcd2a3d41eefe3552c98d524b4f4ff1fea1a908891ec1e54',
+  id: 'b09ba559258dce27bf42526f7169969e70d694d4c8ecef2ce1abcdb3fb5f713c',
   fee: '180',
   contractAddress: 'STAG18E45W613FZ3H4ZMF6QHH426EXM5QTSAVWYH',
   contractName: 'tsip6dp-token',

modules/sdk-coin-stx/test/unit/resources.ts

@@ -184,9 +184,9 @@ export const FUNGIBLE_TOKEN_TRANSFER_CONSTANTS = {
   RECEIVER_ADDRESS: 'SN2NN1JP9AEP5BVE19RNJ6T2MP7NDGRZYST1VDF3M',
   TOKEN_NAME: 'tsip6dp-token',
   UNSIGNED_SINGLE_SIG_TX:
-    '80800000000400164247d6f2b425ac5771423ae6c80c754f7172b0000000000000000000000000000000b4000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000030200000000021a1500a1c42f0c11bfe3893f479af18904677685be0d747369703664702d746f6b656e087472616e73666572000000040100000000000000000000000000002710051a1500a1c42f0c11bfe3893f479af18904677685be0515ab50cac953ac55edc14e2b236854b1ead863fece020000000131',
+    '80800000000400164247d6f2b425ac5771423ae6c80c754f7172b0000000000000000000000000000000b4000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000030200000001010215164247d6f2b425ac5771423ae6c80c754f7172b01a1500a1c42f0c11bfe3893f479af18904677685be0d747369703664702d746f6b656e0d747369703664702d746f6b656e010000000000002710021a1500a1c42f0c11bfe3893f479af18904677685be0d747369703664702d746f6b656e087472616e73666572000000040100000000000000000000000000002710051a1500a1c42f0c11bfe3893f479af18904677685be0515ab50cac953ac55edc14e2b236854b1ead863fece020000000131',
   UNSIGNED_SINGLE_SIG_TX_WITHOUT_MEMO:
-    '80800000000400164247d6f2b425ac5771423ae6c80c754f7172b0000000000000000000000000000000b4000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000030200000000021a1500a1c42f0c11bfe3893f479af18904677685be0d747369703664702d746f6b656e087472616e73666572000000030100000000000000000000000000002710051a1500a1c42f0c11bfe3893f479af18904677685be0515ab50cac953ac55edc14e2b236854b1ead863fece',
+    '80800000000400164247d6f2b425ac5771423ae6c80c754f7172b0000000000000000000000000000000b4000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000030200000001010215164247d6f2b425ac5771423ae6c80c754f7172b01a1500a1c42f0c11bfe3893f479af18904677685be0d747369703664702d746f6b656e0d747369703664702d746f6b656e010000000000002710021a1500a1c42f0c11bfe3893f479af18904677685be0d747369703664702d746f6b656e087472616e73666572000000030100000000000000000000000000002710051a1500a1c42f0c11bfe3893f479af18904677685be0515ab50cac953ac55edc14e2b236854b1ead863fece',
   SIGNED_MULTI_SIG_TX:
-    '808000000004012fe507c09dbb23c3b7e5d166c81fc4b87692510b000000000000000000000000000000b400000003020000f2872c232e1747af46070c191947fa2503ac364d111c30c17a7d0307c7c6792140250743d22d37f0df813d48493bf58bdc455d9d71fce8a57245d8cd17335102018627c757a1216e33c6cd06a33a48ae072b8b28f50df772aaaa57cc067fc2220f646a068ea54847638e03c0782063bd4931674cf80be805bc458e27a0d042a24700038e3c4529395611be9abf6fa3b6987e81d402385e3d605a073f42f407565a4a3d0002030200000000021a1500a1c42f0c11bfe3893f479af18904677685be0d747369703664702d746f6b656e087472616e73666572000000040100000000000000000000000000002710051a1500a1c42f0c11bfe3893f479af18904677685be0515ab50cac953ac55edc14e2b236854b1ead863fece020000000131',
+    '808000000004012fe507c09dbb23c3b7e5d166c81fc4b87692510b000000000000000000000000000000b40000000302004f1813139aad38ac90ba905885ad4822bf33b7a56fff9127780c52359edee495587008204b0a7eaf39a0ba467b54a3e1896f863559349e5142f929cc4c706cd20201ae3fa80f2900c950667d827ed3b843afc94c63179dca70e6205f7d629a5f511a0ed45137c2baa16e33753c8e672dc61182869b6304fdea7daee42d8896f1a3fd00038e3c4529395611be9abf6fa3b6987e81d402385e3d605a073f42f407565a4a3d00020302000000010102152fe507c09dbb23c3b7e5d166c81fc4b87692510b1a1500a1c42f0c11bfe3893f479af18904677685be0d747369703664702d746f6b656e0d747369703664702d746f6b656e010000000000002710021a1500a1c42f0c11bfe3893f479af18904677685be0d747369703664702d746f6b656e087472616e73666572000000040100000000000000000000000000002710051a1500a1c42f0c11bfe3893f479af18904677685be0515ab50cac953ac55edc14e2b236854b1ead863fece020000000131',
 };

modules/sdk-coin-stx/test/unit/transactionBuilder/fungibleTokenTransferBuilder.ts

@@ -8,6 +8,7 @@ import { TransactionType } from '@bitgo/sdk-core';
 import assert from 'assert';
 
 import { Sip10Token, StxLib } from '../../../src';
+import { Transaction } from '../../../src/lib';
 import * as testData from '../resources';
 
 describe('Stacks: Fungible Token Transfer Builder', () => {
@@ -63,6 +64,8 @@ describe('Stacks: Fungible Token Transfer Builder', () => {
         builder.fromPubKey(testData.TX_SENDER.pub);
         builder.numberSignatures(1);
         const tx = await builder.build();
+        const stacksTxn = tx as Transaction;
+        should.deepEqual(stacksTxn.stxTransaction.postConditions.values.length, 1);
 
         const txJson = tx.toJson();
         should.deepEqual(txJson.payload.contractAddress, testData.FUNGIBLE_TOKEN_TRANSFER_CONSTANTS.CONTRACT_ADDRESS);