chore(utxo-lib): change mock UTXO to P2PKH from P2WPKH

Update the mock previous transaction to use P2PKH rather than P2WPKH for
better compatibility (doge, dash) with testing needs.

Issue: BTC-2259

Co-authored-by: llm-git <[email protected]>

Author: davidkaplanbitgo

modules/utxo-lib/src/testutil/mock.ts

@@ -38,7 +38,7 @@ export function mockPrevTx(
   const keypair = getKey('mock-prev-tx');
   const pubkey = keypair.publicKey;
   assert(keypair.privateKey);
-  const payment = utxolib.payments.p2wpkh({ pubkey });
+  const payment = utxolib.payments.p2pkh({ pubkey });
   const destOutput = payment.output;
   if (!destOutput) throw new Error('Impossible, payment we just constructed has no output');
 
@@ -54,13 +54,16 @@ export function mockPrevTx(
     index: 0,
     witnessUtxo: { script: destOutput, value: value * (BigInt(vout) + BigInt(1)) + BigInt(1000) },
   });
-  psbtFromNetwork.signInput(0, {
-    publicKey: pubkey,
-    sign: (hash: Buffer, lowR?: boolean) =>
-      Buffer.from(noble.signSync(hash, keypair.privateKey as Buffer, { canonical: !lowR, der: false })),
+  // Don't require the prevTx for signing and finalizing for non-segwit input
+  utxolib.bitgo.withUnsafeNonSegwit(psbtFromNetwork, () => {
+    psbtFromNetwork.signInput(0, {
+      publicKey: pubkey,
+      sign: (hash: Buffer, lowR?: boolean) =>
+        Buffer.from(noble.signSync(hash, keypair.privateKey as Buffer, { canonical: !lowR, der: false })),
+    });
+    psbtFromNetwork.validateSignaturesOfAllInputs();
+    psbtFromNetwork.finalizeAllInputs();
   });
-  psbtFromNetwork.validateSignaturesOfAllInputs();
-  psbtFromNetwork.finalizeAllInputs();
   return psbtFromNetwork.extractTransaction();
 }
 

modules/utxo-lib/test/bitgo/psbt/ZcashPsbt.ts

@@ -13,7 +13,7 @@ const rootWalletKeys = getDefaultWalletKeys();
 describe('Zcash PSBT', function () {
   let psbt: utxolib.bitgo.ZcashPsbt;
   before(async function () {
-    const unspents = mockUnspents(rootWalletKeys, ['p2sh'], BigInt('10000000000000000'), network);
+    const unspents = mockUnspents(rootWalletKeys, ['p2sh'], BigInt('1000000000000000'), network);
     psbt = await utxolib.bitgo.ZcashPsbt.createPsbt({ network });
 
     unspents.forEach((unspent) => {