feat(KeyPair, Transaction): update address derivation methods and remove redundant logging in sign method

TICKET: WIN-7770

Author: mohd-kashif

modules/sdk-coin-flrp/src/lib/keyPair.ts

@@ -11,6 +11,8 @@ import {
 import { bip32, ECPair } from '@bitgo/secp256k1';
 import { randomBytes, createHash } from 'crypto';
 import utils from './utils';
+import { secp256k1 } from '@flarenetwork/flarejs';
+import { Buffer as SafeBuffer } from 'safe-buffer';
 
 const DEFAULT_SEED_SIZE_BYTES = 16;
 export enum addressFormat {
@@ -127,7 +129,8 @@ export class KeyPair extends Secp256k1ExtendedKeyPair {
   getAddressBuffer(): Buffer {
     try {
       // Use the safe buffer method for address derivation
-      return this.getAddressSafeBuffer();
+      const publicKey = Buffer.from(this.keyPair.publicKey);
+      return Buffer.from(secp256k1.publicKeyBytesToAddress(publicKey));
     } catch (error) {
       return this.getAddressSafeBuffer();
     }
@@ -139,22 +142,8 @@ export class KeyPair extends Secp256k1ExtendedKeyPair {
    * @returns {Buffer}
    */
   private getAddressSafeBuffer(): Buffer {
-    // For EVM addresses, we need to use keccak256 hash of the uncompressed public key
-    const pubKey = this.keyPair.publicKey;
-    // Skip the first byte (compression flag) for EVM address generation
-    const sha256 = createHash('sha256').update(pubKey.slice(1)).digest();
-    const ripemd = createHash('ripemd160').update(sha256).digest();
-    return ripemd;
-  }
-
-  /**
-   * Get the EVM format address buffer
-   * @returns {Buffer} The EVM address buffer
-   */
-  getEvmAddressBuffer(): Buffer {
-    const pubKey = this.keyPair.publicKey;
-    // Remove compression flag and get last 20 bytes of keccak256 hash
-    const keccak = createHash('sha3-256').update(pubKey.slice(1)).digest();
-    return keccak.slice(-20);
+    const publicKeySafe = SafeBuffer.from(this.keyPair.publicKey);
+    const sha256 = SafeBuffer.from(createHash('sha256').update(publicKeySafe).digest());
+    return Buffer.from(createHash('ripemd160').update(sha256).digest());
   }
 }

modules/sdk-coin-flrp/src/lib/transaction.ts

@@ -107,8 +107,6 @@ export class Transaction extends BaseTransaction {
   async sign(keyPair: KeyPair): Promise<void> {
     const prv = keyPair.getPrivateKey() as Uint8Array;
     console.log('private key in sign method:', Buffer.from(prv).toString('hex'));
-    const addressHex = keyPair.getEvmAddressBuffer().toString('hex');
-    console.log('address hex in sign method:', addressHex);
     if (!prv) {
       throw new SigningError('Missing private key');
     }