fix(sdk-core): use Promise.all for concurrent processing for transaction verifying, linting fixes

Ticket: WP-5945

Author: danielpeng1

modules/sdk-coin-btc/test/unit/btc.ts

@@ -118,7 +118,10 @@ describe('BTC:', () => {
     });
 
     it('should detect hex spoofing in BUILD_SIGN_SEND', async (): Promise<void> => {
-      const { getDefaultWalletKeys, toKeychainObjects } = require('../../../bitgo/test/v2/unit/coins/utxo/util/keychains');
+      const {
+        getDefaultWalletKeys,
+        toKeychainObjects,
+      } = require('../../../bitgo/test/v2/unit/coins/utxo/util/keychains');
       const rootWalletKey = getDefaultWalletKeys();
       const keysObj = toKeychainObjects(rootWalletKey, 'pass');
 
@@ -164,9 +167,7 @@ describe('BTC:', () => {
           return [200, { txid: 'test-txid-123', status: 'signed' }];
         });
 
-      keysObj.forEach((k, i) =>
-        nock(bgUrl).get(`/api/v2/${wallet.coin()}/key/${wallet.keyIds()[i]}`).reply(200, k)
-      );
+      keysObj.forEach((k, i) => nock(bgUrl).get(`/api/v2/${wallet.coin()}/key/${wallet.keyIds()[i]}`).reply(200, k));
 
       await assert.rejects(
         wallet.consolidateUnspents({ walletPassphrase: 'pass' }),

modules/sdk-core/src/bitgo/wallet/wallet.ts

@@ -737,15 +737,17 @@ export class Wallet implements IWallet {
 
     // Validate that the platform-built transaction matches user parameters
     const txPrebuilds = Array.isArray(buildResponse) ? buildResponse : [buildResponse];
-    for (const txPrebuild of txPrebuilds) {
-      await this.baseCoin.verifyTransaction({
-        txParams: params,
-        txPrebuild,
-        wallet: this,
-        verification: params.verification ?? {},
-        reqId,
-      });
-    }
+    await Promise.all(
+      txPrebuilds.map((txPrebuild) =>
+        this.baseCoin.verifyTransaction({
+          txParams: params,
+          txPrebuild,
+          wallet: this,
+          verification: params.verification ?? {},
+          reqId,
+        })
+      )
+    );
 
     const keychains = (await this.baseCoin
       .keychains()