feat(abstract-utxo): return specific coin types from createInstance

OttoAllmendinger · llm-git · OttoAllmendinger · commit 75c07a380da4 · 2025-10-24T11:42:57.000+02:00
Return specific coin types from createInstance rather than the generic BaseCoin type to improve type safety and eliminate the need for casting. Issue: BTC-2652 Co-authored-by: llm-git <llm-git@ttll.de>
diff --git a/modules/abstract-utxo/src/impl/bch/bch.ts b/modules/abstract-utxo/src/impl/bch/bch.ts
@@ -1,4 +1,4 @@
-import { BitGoBase, BaseCoin } from '@bitgo/sdk-core';
+import { BitGoBase } from '@bitgo/sdk-core';
 import * as utxolib from '@bitgo/utxo-lib';
 
 import { AbstractUtxoCoin, UtxoNetwork } from '../../abstractUtxoCoin';
@@ -8,7 +8,7 @@ export class Bch extends AbstractUtxoCoin {
     super(bitgo, network || utxolib.networks.bitcoincash);
   }
 
-  static createInstance(bitgo: BitGoBase): BaseCoin {
+  static createInstance(bitgo: BitGoBase): Bch {
     return new Bch(bitgo);
   }
 
diff --git a/modules/abstract-utxo/src/impl/bch/tbch.ts b/modules/abstract-utxo/src/impl/bch/tbch.ts
@@ -1,7 +1,7 @@
 /**
  * @prettier
  */
-import { BaseCoin, BitGoBase } from '@bitgo/sdk-core';
+import { BitGoBase } from '@bitgo/sdk-core';
 import * as bitcoin from '@bitgo/utxo-lib';
 
 import { Bch } from './bch';
@@ -11,7 +11,7 @@ export class Tbch extends Bch {
     super(bitgo, bitcoin.networks.bitcoincashTestnet);
   }
 
-  static createInstance(bitgo: BitGoBase): BaseCoin {
+  static createInstance(bitgo: BitGoBase): Tbch {
     return new Tbch(bitgo);
   }
 }
diff --git a/modules/abstract-utxo/src/impl/bcha/bcha.ts b/modules/abstract-utxo/src/impl/bcha/bcha.ts
@@ -1,4 +1,4 @@
-import { BitGoBase, BaseCoin } from '@bitgo/sdk-core';
+import { BitGoBase } from '@bitgo/sdk-core';
 import * as utxolib from '@bitgo/utxo-lib';
 
 import { Bch } from '../bch/bch';
@@ -9,7 +9,7 @@ export class Bcha extends Bch {
     super(bitgo, network || utxolib.networks.ecash);
   }
 
-  static createInstance(bitgo: BitGoBase): BaseCoin {
+  static createInstance(bitgo: BitGoBase): Bcha {
     return new Bcha(bitgo);
   }
 
diff --git a/modules/abstract-utxo/src/impl/bcha/tbcha.ts b/modules/abstract-utxo/src/impl/bcha/tbcha.ts
@@ -1,7 +1,7 @@
 /**
  * @prettier
  */
-import { BitGoBase, BaseCoin } from '@bitgo/sdk-core';
+import { BitGoBase } from '@bitgo/sdk-core';
 import * as utxolib from '@bitgo/utxo-lib';
 
 import { Bcha } from './bcha';
@@ -11,7 +11,7 @@ export class Tbcha extends Bcha {
     super(bitgo, utxolib.networks.ecashTest);
   }
 
-  static createInstance(bitgo: BitGoBase): BaseCoin {
+  static createInstance(bitgo: BitGoBase): Tbcha {
     return new Tbcha(bitgo);
   }
 }
diff --git a/modules/abstract-utxo/src/impl/bsv/bsv.ts b/modules/abstract-utxo/src/impl/bsv/bsv.ts
@@ -1,4 +1,4 @@
-import { BitGoBase, BaseCoin } from '@bitgo/sdk-core';
+import { BitGoBase } from '@bitgo/sdk-core';
 import * as utxolib from '@bitgo/utxo-lib';
 
 import { UtxoNetwork } from '../../abstractUtxoCoin';
@@ -9,7 +9,7 @@ export class Bsv extends Bch {
     super(bitgo, network || utxolib.networks.bitcoinsv);
   }
 
-  static createInstance(bitgo: BitGoBase): BaseCoin {
+  static createInstance(bitgo: BitGoBase): Bsv {
     return new Bsv(bitgo);
   }
 }
diff --git a/modules/abstract-utxo/src/impl/bsv/tbsv.ts b/modules/abstract-utxo/src/impl/bsv/tbsv.ts
@@ -1,7 +1,7 @@
 /**
  * @prettier
  */
-import { BitGoBase, BaseCoin } from '@bitgo/sdk-core';
+import { BitGoBase } from '@bitgo/sdk-core';
 import * as utxolib from '@bitgo/utxo-lib';
 
 import { Bsv } from './bsv';
@@ -11,7 +11,7 @@ export class Tbsv extends Bsv {
     super(bitgo, utxolib.networks.bitcoinsvTestnet);
   }
 
-  static createInstance(bitgo: BitGoBase): BaseCoin {
+  static createInstance(bitgo: BitGoBase): Tbsv {
     return new Tbsv(bitgo);
   }
 }
diff --git a/modules/abstract-utxo/src/impl/btc/btc.ts b/modules/abstract-utxo/src/impl/btc/btc.ts
@@ -1,6 +1,5 @@
 import {
   BitGoBase,
-  BaseCoin,
   VerifyRecoveryTransactionOptions as BaseVerifyRecoveryTransactionOptions,
   Wallet,
 } from '@bitgo/sdk-core';
@@ -19,7 +18,7 @@ export class Btc extends AbstractUtxoCoin {
     super(bitgo, network || utxolib.networks.bitcoin);
   }
 
-  static createInstance(bitgo: BitGoBase): BaseCoin {
+  static createInstance(bitgo: BitGoBase): Btc {
     return new Btc(bitgo);
   }
 
diff --git a/modules/abstract-utxo/src/impl/btc/tbtc.ts b/modules/abstract-utxo/src/impl/btc/tbtc.ts
@@ -1,7 +1,7 @@
 /**
  * @prettier
  */
-import { BaseCoin, BitGoBase } from '@bitgo/sdk-core';
+import { BitGoBase } from '@bitgo/sdk-core';
 import * as utxolib from '@bitgo/utxo-lib';
 
 import { Btc } from './btc';
@@ -11,7 +11,7 @@ export class Tbtc extends Btc {
     super(bitgo, utxolib.networks.testnet);
   }
 
-  static createInstance(bitgo: BitGoBase): BaseCoin {
+  static createInstance(bitgo: BitGoBase): Tbtc {
     return new Tbtc(bitgo);
   }
 }
diff --git a/modules/abstract-utxo/src/impl/btc/tbtc4.ts b/modules/abstract-utxo/src/impl/btc/tbtc4.ts
@@ -1,7 +1,7 @@
 /**
  * @prettier
  */
-import { BaseCoin, BitGoBase } from '@bitgo/sdk-core';
+import { BitGoBase } from '@bitgo/sdk-core';
 import * as utxolib from '@bitgo/utxo-lib';
 
 import { Btc } from './btc';
@@ -11,7 +11,7 @@ export class Tbtc4 extends Btc {
     super(bitgo, utxolib.networks.bitcoinTestnet4);
   }
 
-  static createInstance(bitgo: BitGoBase): BaseCoin {
+  static createInstance(bitgo: BitGoBase): Tbtc4 {
     return new Tbtc4(bitgo);
   }
 }
diff --git a/modules/abstract-utxo/src/impl/btc/tbtcbgsig.ts b/modules/abstract-utxo/src/impl/btc/tbtcbgsig.ts
@@ -1,7 +1,7 @@
 /**
  * @prettier
  */
-import { BaseCoin, BitGoBase } from '@bitgo/sdk-core';
+import { BitGoBase } from '@bitgo/sdk-core';
 import * as utxolib from '@bitgo/utxo-lib';
 
 import { Btc } from './btc';
@@ -11,7 +11,7 @@ export class Tbtcbgsig extends Btc {
     super(bitgo, utxolib.networks.bitcoinBitGoSignet);
   }
 
-  static createInstance(bitgo: BitGoBase): BaseCoin {
+  static createInstance(bitgo: BitGoBase): Tbtcbgsig {
     return new Tbtcbgsig(bitgo);
   }
 }
diff --git a/modules/abstract-utxo/src/impl/btc/tbtcsig.ts b/modules/abstract-utxo/src/impl/btc/tbtcsig.ts
@@ -1,7 +1,7 @@
 /**
  * @prettier
  */
-import { BaseCoin, BitGoBase } from '@bitgo/sdk-core';
+import { BitGoBase } from '@bitgo/sdk-core';
 import * as utxolib from '@bitgo/utxo-lib';
 
 import { Btc } from './btc';
@@ -11,7 +11,7 @@ export class Tbtcsig extends Btc {
     super(bitgo, utxolib.networks.bitcoinPublicSignet);
   }
 
-  static createInstance(bitgo: BitGoBase): BaseCoin {
+  static createInstance(bitgo: BitGoBase): Tbtcsig {
     return new Tbtcsig(bitgo);
   }
 }
diff --git a/modules/abstract-utxo/src/impl/btg/btg.ts b/modules/abstract-utxo/src/impl/btg/btg.ts
@@ -1,4 +1,4 @@
-import { BitGoBase, BaseCoin } from '@bitgo/sdk-core';
+import { BitGoBase } from '@bitgo/sdk-core';
 import * as utxolib from '@bitgo/utxo-lib';
 
 import { AbstractUtxoCoin, UtxoNetwork } from '../../abstractUtxoCoin';
@@ -8,7 +8,7 @@ export class Btg extends AbstractUtxoCoin {
     super(bitgo, network || utxolib.networks.bitcoingold);
   }
 
-  static createInstance(bitgo: BitGoBase): BaseCoin {
+  static createInstance(bitgo: BitGoBase): Btg {
     return new Btg(bitgo);
   }
 }
diff --git a/modules/abstract-utxo/src/impl/dash/dash.ts b/modules/abstract-utxo/src/impl/dash/dash.ts
@@ -1,4 +1,4 @@
-import { BitGoBase, BaseCoin } from '@bitgo/sdk-core';
+import { BitGoBase } from '@bitgo/sdk-core';
 import * as utxolib from '@bitgo/utxo-lib';
 
 import { AbstractUtxoCoin, UtxoNetwork } from '../../abstractUtxoCoin';
@@ -8,7 +8,7 @@ export class Dash extends AbstractUtxoCoin {
     super(bitgo, network || utxolib.networks.dash);
   }
 
-  static createInstance(bitgo: BitGoBase): BaseCoin {
+  static createInstance(bitgo: BitGoBase): Dash {
     return new Dash(bitgo);
   }
 }
diff --git a/modules/abstract-utxo/src/impl/dash/tdash.ts b/modules/abstract-utxo/src/impl/dash/tdash.ts
@@ -1,7 +1,7 @@
 /**
  * @prettier
  */
-import { BitGoBase, BaseCoin } from '@bitgo/sdk-core';
+import { BitGoBase } from '@bitgo/sdk-core';
 import * as utxolib from '@bitgo/utxo-lib';
 
 import { Dash } from './dash';
@@ -10,7 +10,7 @@ export class Tdash extends Dash {
   constructor(bitgo: BitGoBase) {
     super(bitgo, utxolib.networks.dashTest);
   }
-  static createInstance(bitgo: BitGoBase): BaseCoin {
+  static createInstance(bitgo: BitGoBase): Tdash {
     return new Tdash(bitgo);
   }
 }
diff --git a/modules/abstract-utxo/src/impl/doge/doge.ts b/modules/abstract-utxo/src/impl/doge/doge.ts
@@ -1,4 +1,4 @@
-import { BaseCoin, BitGoBase, HalfSignedUtxoTransaction, SignedTransaction } from '@bitgo/sdk-core';
+import { BitGoBase, HalfSignedUtxoTransaction, SignedTransaction } from '@bitgo/sdk-core';
 import { bitgo, networks } from '@bitgo/utxo-lib';
 
 import {
@@ -60,7 +60,7 @@ export class Doge extends AbstractUtxoCoin {
     super(bitgo, network || networks.dogecoin, 'bigint');
   }
 
-  static createInstance(bitgo: BitGoBase): BaseCoin {
+  static createInstance(bitgo: BitGoBase): Doge {
     return new Doge(bitgo);
   }
 
diff --git a/modules/abstract-utxo/src/impl/doge/tdoge.ts b/modules/abstract-utxo/src/impl/doge/tdoge.ts
@@ -1,7 +1,7 @@
 /**
  * @prettier
  */
-import { BitGoBase, BaseCoin } from '@bitgo/sdk-core';
+import { BitGoBase } from '@bitgo/sdk-core';
 import * as utxolib from '@bitgo/utxo-lib';
 
 import { Doge } from './doge';
@@ -10,7 +10,7 @@ export class Tdoge extends Doge {
   constructor(bitgo: BitGoBase) {
     super(bitgo, utxolib.networks.dogecoinTest);
   }
-  static createInstance(bitgo: BitGoBase): BaseCoin {
+  static createInstance(bitgo: BitGoBase): Tdoge {
     return new Tdoge(bitgo);
   }
 }
diff --git a/modules/abstract-utxo/src/impl/ltc/ltc.ts b/modules/abstract-utxo/src/impl/ltc/ltc.ts
@@ -1,4 +1,4 @@
-import { BitGoBase, BaseCoin } from '@bitgo/sdk-core';
+import { BitGoBase } from '@bitgo/sdk-core';
 import * as utxolib from '@bitgo/utxo-lib';
 
 import { AbstractUtxoCoin, UtxoNetwork } from '../../abstractUtxoCoin';
@@ -12,7 +12,7 @@ export class Ltc extends AbstractUtxoCoin {
     this.supportAltScriptDestination = false;
   }
 
-  static createInstance(bitgo: BitGoBase): BaseCoin {
+  static createInstance(bitgo: BitGoBase): Ltc {
     return new Ltc(bitgo);
   }
 }
diff --git a/modules/abstract-utxo/src/impl/ltc/tltc.ts b/modules/abstract-utxo/src/impl/ltc/tltc.ts
@@ -1,4 +1,4 @@
-import { BitGoBase, BaseCoin } from '@bitgo/sdk-core';
+import { BitGoBase } from '@bitgo/sdk-core';
 import * as utxolib from '@bitgo/utxo-lib';
 
 import { Ltc } from './ltc';
@@ -10,7 +10,7 @@ export class Tltc extends Ltc {
     // support alt destinations on test
     this.supportAltScriptDestination = false;
   }
-  static createInstance(bitgo: BitGoBase): BaseCoin {
+  static createInstance(bitgo: BitGoBase): Tltc {
     return new Tltc(bitgo);
   }
 }
diff --git a/modules/abstract-utxo/src/impl/zec/tzec.ts b/modules/abstract-utxo/src/impl/zec/tzec.ts
@@ -1,4 +1,4 @@
-import { BaseCoin, BitGoBase } from '@bitgo/sdk-core';
+import { BitGoBase } from '@bitgo/sdk-core';
 import * as utxolib from '@bitgo/utxo-lib';
 
 import { Zec } from './zec';
@@ -8,7 +8,7 @@ export class Tzec extends Zec {
     super(bitgo, utxolib.networks.zcashTest);
   }
 
-  static createInstance(bitgo: BitGoBase): BaseCoin {
+  static createInstance(bitgo: BitGoBase): Tzec {
     return new Tzec(bitgo);
   }
 }
diff --git a/modules/abstract-utxo/src/impl/zec/zec.ts b/modules/abstract-utxo/src/impl/zec/zec.ts
@@ -1,7 +1,7 @@
 /**
  * @prettier
  */
-import { BitGoBase, BaseCoin } from '@bitgo/sdk-core';
+import { BitGoBase } from '@bitgo/sdk-core';
 import * as utxolib from '@bitgo/utxo-lib';
 
 import { AbstractUtxoCoin, UtxoNetwork } from '../../abstractUtxoCoin';
@@ -11,7 +11,7 @@ export class Zec extends AbstractUtxoCoin {
     super(bitgo, network || utxolib.networks.zcash);
   }
 
-  static createInstance(bitgo: BitGoBase): BaseCoin {
+  static createInstance(bitgo: BitGoBase): Zec {
     return new Zec(bitgo);
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-import { BitGoBase, BaseCoin } from '@bitgo/sdk-core';`
	`1`	`+import { BitGoBase } from '@bitgo/sdk-core';`
`2`	`2`	`import * as utxolib from '@bitgo/utxo-lib';`
`3`	`3`
`4`	`4`	`import { AbstractUtxoCoin, UtxoNetwork } from '../../abstractUtxoCoin';`
`@@ -8,7 +8,7 @@ export class Bch extends AbstractUtxoCoin {`
`8`	`8`	`super(bitgo, network \|\| utxolib.networks.bitcoincash);`
`9`	`9`	`}`
`10`	`10`
`11`		`- static createInstance(bitgo: BitGoBase): BaseCoin {`
	`11`	`+ static createInstance(bitgo: BitGoBase): Bch {`
`12`	`12`	`return new Bch(bitgo);`
`13`	`13`	`}`
`14`	`14`
Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,7 @@`
`1`	`1`	`/**`
`2`	`2`	`* @prettier`
`3`	`3`	`*/`
`4`		`-import { BaseCoin, BitGoBase } from '@bitgo/sdk-core';`
	`4`	`+import { BitGoBase } from '@bitgo/sdk-core';`
`5`	`5`	`import * as bitcoin from '@bitgo/utxo-lib';`
`6`	`6`
`7`	`7`	`import { Bch } from './bch';`
`@@ -11,7 +11,7 @@ export class Tbch extends Bch {`
`11`	`11`	`super(bitgo, bitcoin.networks.bitcoincashTestnet);`
`12`	`12`	`}`
`13`	`13`
`14`		`- static createInstance(bitgo: BitGoBase): BaseCoin {`
	`14`	`+ static createInstance(bitgo: BitGoBase): Tbch {`
`15`	`15`	`return new Tbch(bitgo);`
`16`	`16`	`}`
`17`	`17`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,5 @@`
`1`	`1`	`import {`
`2`	`2`	`BitGoBase,`
`3`		`- BaseCoin,`
`4`	`3`	`VerifyRecoveryTransactionOptions as BaseVerifyRecoveryTransactionOptions,`
`5`	`4`	`Wallet,`
`6`	`5`	`} from '@bitgo/sdk-core';`
`@@ -19,7 +18,7 @@ export class Btc extends AbstractUtxoCoin {`
`19`	`18`	`super(bitgo, network \|\| utxolib.networks.bitcoin);`
`20`	`19`	`}`
`21`	`20`
`22`		`- static createInstance(bitgo: BitGoBase): BaseCoin {`
	`21`	`+ static createInstance(bitgo: BitGoBase): Btc {`
`23`	`22`	`return new Btc(bitgo);`
`24`	`23`	`}`
`25`	`24`