Merge pull request #7010 from BitGo/BTC-2470-change-accounts-purpose

feat: optional only create addrees accounts lightning

Author: parvbitgo067

modules/abstract-lightning/src/codecs/api/wallet.ts

@@ -52,11 +52,15 @@ export const WatchOnlyAccount = t.type({
 
 export type WatchOnlyAccount = t.TypeOf<typeof WatchOnlyAccount>;
 
-export const WatchOnly = t.type({
-  master_key_birthday_timestamp: t.string,
-  master_key_fingerprint: t.string,
-  accounts: t.array(WatchOnlyAccount),
-});
+export const WatchOnly = t.intersection([
+  t.type({
+    accounts: t.array(WatchOnlyAccount),
+  }),
+  t.partial({
+    master_key_birthday_timestamp: t.string,
+    master_key_fingerprint: t.string,
+  }),
+]);
 
 export type WatchOnly = t.TypeOf<typeof WatchOnly>;
 

modules/abstract-lightning/src/lightning/lightningUtils.ts

@@ -154,14 +154,18 @@ function convertXpubPrefix(xpub: string, purpose: ExtendedKeyPurpose, isMainnet:
 /**
  * Derives watch-only accounts from the master HD node for the given purposes and network.
  */
-function deriveWatchOnlyAccounts(masterHDNode: utxolib.BIP32Interface, isMainnet: boolean): WatchOnlyAccount[] {
+export function deriveWatchOnlyAccounts(
+  masterHDNode: utxolib.BIP32Interface,
+  isMainnet: boolean,
+  params: { onlyAddressCreationAccounts?: boolean } = { onlyAddressCreationAccounts: false }
+): WatchOnlyAccount[] {
   // https://github.com/lightningnetwork/lnd/blob/master/docs/remote-signing.md#required-accounts
   if (masterHDNode.isNeutered()) {
     throw new Error('masterHDNode must not be neutered');
   }
-
-  const purposes = [PURPOSE_WRAPPED_P2WKH, PURPOSE_P2WKH, PURPOSE_P2TR, PURPOSE_ALL_OTHERS] as const;
-
+  const purposes = params.onlyAddressCreationAccounts
+    ? ([PURPOSE_WRAPPED_P2WKH, PURPOSE_P2WKH, PURPOSE_P2TR] as const)
+    : ([PURPOSE_WRAPPED_P2WKH, PURPOSE_P2WKH, PURPOSE_P2TR, PURPOSE_ALL_OTHERS] as const);
   return purposes.flatMap((purpose) => {
     const maxAccount = purpose === PURPOSE_ALL_OTHERS ? 255 : 0;
     const coinType = purpose !== PURPOSE_ALL_OTHERS || isMainnet ? 0 : 1;