Merge pull request #7515 from BitGo/COIN-6544

fix: remove length check on party hint

Author: ravibitgo

modules/sdk-coin-canton/src/lib/utils.ts

@@ -16,7 +16,7 @@ export class Utils implements BaseUtils {
     if (!address || address.trim() === '') return false;
     const [partyHint, fingerprint] = address.trim().split('::');
     if (!partyHint || !fingerprint) return false;
-    return partyHint.length >= 5 && this.isValidCantonHex(fingerprint);
+    return this.isValidCantonHex(fingerprint);
   }
 
   /** @inheritdoc */

modules/sdk-coin-canton/test/resources.ts

@@ -78,8 +78,8 @@ export const InvalidOneStepPreApprovalPrepareResponse = {
 
 export const CANTON_ADDRESSES = {
   VALID_ADDRESS: '1220a::1220a43d89dc7d8f85316116aac093667f769fce55411aef6846ccb933b2e1a3b598',
-  // party hint is not greater than or equal to 5 characters
-  INVALID_PARTY_HINT: '1234::1220a43d89dc7d8f85316116aac093667f769fce55411aef6846ccb933b2e1a3b598',
+  // party hint should be present
+  VALID_PARTY_HINT: '1234::1220a43d89dc7d8f85316116aac093667f769fce55411aef6846ccb933b2e1a3b598',
   // fingerprint is not a valid hex value
   INVALID_FINGERPRINT: '12205::12205b4e3537a95126d9060459234gd8ad3c3ddccda4f79901954280ee19c576714d',
   MISSING_PARTY_HINT: '::12205b4e3537a95126d9060459234gd8ad3c3ddccda4f79901954280ee19c576714d',

modules/sdk-coin-canton/test/unit/utils.ts

@@ -115,9 +115,9 @@ describe('Canton Util', function () {
     });
 
     it('should return false when party hint is invalid', function () {
-      const isValid = utils.isValidAddress(CANTON_ADDRESSES.INVALID_PARTY_HINT);
+      const isValid = utils.isValidAddress(CANTON_ADDRESSES.VALID_PARTY_HINT);
       should.exist(isValid);
-      assert.strictEqual(isValid, false);
+      assert.strictEqual(isValid, true);
     });
 
     it('should return false when fingerprint is invalid', function () {