Merge pull request #6302 from BitGo/WIN-5923-create-coin-objects-for-only-coins-not-present-in-coin-map-and-coin-factory

feat(sdk-core): add method to check if coin is present in map

Author: veetragjain

modules/sdk-core/src/bitgo/coinFactory.ts

@@ -42,6 +42,16 @@ export class CoinFactory {
     this.coinConstructors.set(name, coin);
   }
 
+  /**
+   * Checks if the coin is present in both coin map and constructor map
+   * @param name Name of coin
+   * @returns {boolean}
+   */
+
+  public hasCoin(name: string): boolean {
+    return this.coinMap.has(name) && this.getCoinConstructor(name) !== undefined;
+  }
+
   /**
    * Registers a token in the coin map and the constructor map.
    * @param staticsCoin The static coin definition from BitGo Statics

modules/statics/src/coins.ts

@@ -3690,6 +3690,18 @@ export function createToken(token: AmsTokenConfig): Readonly<BaseCoin> | undefin
     ofc: ofcToken,
   };
 
+  //return the BaseCoin from default coin map if present
+  if (isCoinPresentInCoinMap({ ...token })) {
+    if (coins.has(token.name)) {
+      return coins.get(token.name);
+    }
+    if (coins.has(token.id)) {
+      return coins.get(token.id);
+    }
+    if (token.alias && coins.has(token.alias)) {
+      return coins.get(token.alias);
+    }
+  }
   const family = token.family;
   const initializer = initializerMap[family] as (...args: unknown[]) => Readonly<BaseCoin>;
   if (!initializer) {

modules/statics/test/unit/coins.ts

@@ -1161,5 +1161,14 @@ describe('create token map using config details', () => {
       decimalPlaces: amsTokenConfig.decimalPlaces,
       tokenContractAddress: amsTokenConfig.contractAddress.toLowerCase(),
     });
+    it('should return the base coin present in default coin map', () => {
+      const tokenName = 'thbar:usdc';
+      const token = createToken(incorrectAmsTokenConfig[tokenName][0]);
+      token?.should.not.be.undefined();
+      token?.decimalPlaces.should.eql(coins.get(tokenName).decimalPlaces);
+      token?.baseUnit.should.eql(coins.get(tokenName).baseUnit);
+      token?.decimalPlaces.should.not.eql(incorrectAmsTokenConfig[tokenName][0].decimalPlaces);
+      token?.baseUnit.should.not.eql(incorrectAmsTokenConfig[tokenName][0].baseUnit);
+    });
   });
 });