chore(sdk-core): preprocess build params before submitting

In the SDK we handle OP_RETURN outputs by setting them
in the address field of the output with the format
`scriptPubkey:HEX_ENCODED_SCRIPT_PUBKEY`. When we submit
to wallet platform, we want to convert that output to
the format { script: string, amount: string | number }.

Before submitting the buildParams to the API, we want
to convert it. In every other instance for other coins
we just want to return the same parameters.

TICKET: BTC-1582

Author: davidkaplanbitgo

modules/abstract-utxo/src/abstractUtxoCoin.ts

@@ -448,6 +448,21 @@ export abstract class AbstractUtxoCoin extends BaseCoin {
     }
   }
 
+  preprocessBuildParams(params: Record<string, any>): Record<string, any> {
+    params.recipients =
+      params.recipients && params.recipients instanceof Array
+        ? params?.recipients?.map((recipient) => {
+            if (recipient.address.startsWith(ScriptRecipientPrefix)) {
+              const { address, ...rest } = recipient;
+              return { ...rest, script: address.replace(ScriptRecipientPrefix, '') };
+            }
+            return recipient;
+          })
+        : params.recipients;
+
+    return params;
+  }
+
   /**
    * Get the latest block height
    * @param reqId

modules/sdk-core/src/bitgo/baseCoin/baseCoin.ts

@@ -249,6 +249,14 @@ export abstract class BaseCoin implements IBaseCoin {
     return bigNumber.toFixed(0);
   }
 
+  /**
+   * Preprocess the build parameters before sending to the API
+   * @param buildParams
+   */
+  preprocessBuildParams(buildParams: Record<string, any>): Record<string, any> {
+    return buildParams;
+  }
+
   /**
    * Sign message with private key
    *

modules/sdk-core/src/bitgo/baseCoin/iBaseCoin.ts

@@ -485,6 +485,7 @@ export interface IBaseCoin {
   getBaseFactor(): number | string;
   baseUnitsToBigUnits(baseUnits: string | number): string;
   bigUnitsToBaseUnits(bigUnits: string | number): string;
+  preprocessBuildParams(params: Record<string, any>): Record<string, any>;
   signMessage(key: { prv: string }, message: string): Promise<Buffer>;
   createKeySignatures(
     prv: string,

modules/sdk-core/src/bitgo/wallet/wallet.ts

@@ -1747,7 +1747,7 @@ export class Wallet implements IWallet {
     }
 
     // Whitelist params to build tx
-    const whitelistedParams = _.pick(params, this.prebuildWhitelistedParams());
+    const whitelistedParams = this.baseCoin.preprocessBuildParams(_.pick(params, this.prebuildWhitelistedParams()));
     debug('prebuilding transaction: %O', whitelistedParams);
 
     if (params.reqId) {
@@ -3655,7 +3655,7 @@ export class Wallet implements IWallet {
     // extract the whitelisted params from the top level, in case
     // other invalid params are present that would fail encoding
     // and fall back to the body params
-    const whitelistedParams = _.pick(params, whitelistedSendParams);
+    const whitelistedParams = this.baseCoin.preprocessBuildParams(_.pick(params, whitelistedSendParams));
     const reqTracer = reqId || new RequestTracer();
     this.bitgo.setRequestTracer(reqTracer);
     return postWithCodec(