fix(sdk-coin-icp): update payloads length and adjust interval for ingress expiries

TICKET: WIN-4876

Author: mohd-kashif

modules/sdk-coin-icp/src/lib/unsignedTransactionBuilder.ts

@@ -21,7 +21,10 @@ export class UnsignedTransactionBuilder {
   }
 
   async getUnsignedTransaction(): Promise<PayloadsData> {
-    const interval = MAX_INGRESS_TTL - PERMITTED_DRIFT - 120 * 1000_000_000; // 120 seconds in milliseconds
+    // interval value can be altered here to change the count of ingressExpiries which eventually changes the number of interval value can be altered here to change the count of ingressExpiries which eventually changes the number of payloads that needs to be signed
+    const interval =
+      Number(this._icpTransactionPayload.metadata.ingress_end) -
+      Number(this._icpTransactionPayload.metadata.ingress_start); // 300s in nanoseconds
     const ingressExpiries = this.getIngressExpiries(
       this._icpTransactionPayload.metadata.ingress_start!,
       this._icpTransactionPayload.metadata.ingress_end!,

modules/sdk-coin-icp/test/resources/icp.ts

@@ -127,58 +127,24 @@ export const metaData: IcpMetadata = {
 export const payloadsData = {
   payloads: [
     {
-      account_identifier: {
-        address: '0af815da8259ba8bb3d34fbfb2ac730f07a1adc81438d40d667d91b408b25f2f',
-      },
+      account_identifier: { address: '0af815da8259ba8bb3d34fbfb2ac730f07a1adc81438d40d667d91b408b25f2f' },
       hex_bytes: '0a69632d726571756573742dd9527902e38bc015d4f5521e680b29d1ebc5b4fe24dd5515e2abe99097f0b1',
       signature_type: 'ecdsa',
     },
     {
-      account_identifier: {
-        address: '0af815da8259ba8bb3d34fbfb2ac730f07a1adc81438d40d667d91b408b25f2f',
-      },
+      account_identifier: { address: '0af815da8259ba8bb3d34fbfb2ac730f07a1adc81438d40d667d91b408b25f2f' },
       hex_bytes: '0a69632d726571756573742adff4e1c4b8b725bd4accbaf80cd2b180b322bfc450ec00d14aa315c9a4e324',
       signature_type: 'ecdsa',
     },
-    {
-      account_identifier: {
-        address: '0af815da8259ba8bb3d34fbfb2ac730f07a1adc81438d40d667d91b408b25f2f',
-      },
-      hex_bytes: '0a69632d7265717565737476265b535aeeda1b30f9a276a62e9247c9288d518349d68b504e9db5f9fd7563',
-      signature_type: 'ecdsa',
-    },
-    {
-      account_identifier: {
-        address: '0af815da8259ba8bb3d34fbfb2ac730f07a1adc81438d40d667d91b408b25f2f',
-      },
-      hex_bytes: '0a69632d72657175657374bb6cfef054ce8ce0a54593f7eb78bb089dc14673e1556afd20dd9534d29aa2f7',
-      signature_type: 'ecdsa',
-    },
-    {
-      account_identifier: {
-        address: '0af815da8259ba8bb3d34fbfb2ac730f07a1adc81438d40d667d91b408b25f2f',
-      },
-      hex_bytes: '0a69632d726571756573741c174f275615e80d7280542bf373e2ecfa59c3a1d87475feed0a97203fb22f37',
-      signature_type: 'ecdsa',
-    },
-    {
-      account_identifier: {
-        address: '0af815da8259ba8bb3d34fbfb2ac730f07a1adc81438d40d667d91b408b25f2f',
-      },
-      hex_bytes: '0a69632d726571756573741814112eb6162e3dc5cc6a5a87c9ec2a6578e762059ec7510591aad208e7cded',
-      signature_type: 'ecdsa',
-    },
   ],
   unsigned_transaction:
-    'b90002677570646174657381826b5452414e53414354494f4eb900056b63616e69737465725f69644a000000000000000201016b6d6574686f645f6e616d656773656e645f70626361726758400a0308d20912040a02080a1a0308904e2a220a20c3d30f404955975adaba89f2e1ebc75c1f44a6a204578afce8f3780d64fe252e3a0a088084dcb3abb69694186673656e646572581dd5fc1dc4d74d4aa35d81cf345533d20548113412d32fffdcece2f68a026e696e67726573735f6578706972791b000000000000000070696e67726573735f6578706972696573831b182859ea979462001b18285a06882312001b18285a2278b1c200',
+    'b90002677570646174657381826b5452414e53414354494f4eb900056b63616e69737465725f69644a000000000000000201016b6d6574686f645f6e616d656773656e645f70626361726758400a0308d20912040a02080a1a0308904e2a220a20c3d30f404955975adaba89f2e1ebc75c1f44a6a204578afce8f3780d64fe252e3a0a088084dcb3abb69694186673656e646572581dd5fc1dc4d74d4aa35d81cf345533d20548113412d32fffdcece2f68a026e696e67726573735f6578706972791b000000000000000070696e67726573735f6578706972696573811b182859ea97946200',
 };
 
 export const signatures = [
   {
     signing_payload: {
-      account_identifier: {
-        address: '0af815da8259ba8bb3d34fbfb2ac730f07a1adc81438d40d667d91b408b25f2f',
-      },
+      account_identifier: { address: '0af815da8259ba8bb3d34fbfb2ac730f07a1adc81438d40d667d91b408b25f2f' },
       hex_bytes: '0a69632d726571756573742dd9527902e38bc015d4f5521e680b29d1ebc5b4fe24dd5515e2abe99097f0b1',
       signature_type: 'ecdsa',
     },
@@ -189,13 +155,11 @@ export const signatures = [
       curve_type: 'secp256k1',
     },
     hex_bytes:
-      '11d903fe529788a2202a261568066371e2022ddb339379368e19567473b3c2d7a88e032684652109ec8d9ef6b6600c479620ca690b26ecf07678b3ee307d1375',
+      '11d903fe529788a2202a261568066371e2022ddb339379368e19567473b3c2d75771fcd97b9adef613726109499ff3b7248e127da421b34b4959aa9e9fb92dcc',
   },
   {
     signing_payload: {
-      account_identifier: {
-        address: '0af815da8259ba8bb3d34fbfb2ac730f07a1adc81438d40d667d91b408b25f2f',
-      },
+      account_identifier: { address: '0af815da8259ba8bb3d34fbfb2ac730f07a1adc81438d40d667d91b408b25f2f' },
       hex_bytes: '0a69632d726571756573742adff4e1c4b8b725bd4accbaf80cd2b180b322bfc450ec00d14aa315c9a4e324',
       signature_type: 'ecdsa',
     },
@@ -208,78 +172,10 @@ export const signatures = [
     hex_bytes:
       'b50df90e4c94e45d4bd7117d98380d104f19cf7053814887acfe4d6ad24b08f8735473b00e5740beef2e675d98764dc22ab44c653ecf65281cc46601d2802eb5',
   },
-  {
-    signing_payload: {
-      account_identifier: {
-        address: '0af815da8259ba8bb3d34fbfb2ac730f07a1adc81438d40d667d91b408b25f2f',
-      },
-      hex_bytes: '0a69632d7265717565737476265b535aeeda1b30f9a276a62e9247c9288d518349d68b504e9db5f9fd7563',
-      signature_type: 'ecdsa',
-    },
-    signature_type: 'ecdsa',
-    public_key: {
-      hex_bytes:
-        '042ab77b959e28c4fa47fa8fb9e57cec3d66df5684d076ac2e4c5f28fd69a23dd31a59f908c8add51eab3530b4ac5d015166eaf2198c52fa9a8df7cfaeb8fdb7d4',
-      curve_type: 'secp256k1',
-    },
-    hex_bytes:
-      '005e67fcb5f5937b969b64eca79077030e7a0e9841dc6babca4211167c32799235b16823f37ba8b9431293705ac4b5e62c6fa18e0ea265a121f58d368295d45c',
-  },
-  {
-    signing_payload: {
-      account_identifier: {
-        address: '0af815da8259ba8bb3d34fbfb2ac730f07a1adc81438d40d667d91b408b25f2f',
-      },
-      hex_bytes: '0a69632d72657175657374bb6cfef054ce8ce0a54593f7eb78bb089dc14673e1556afd20dd9534d29aa2f7',
-      signature_type: 'ecdsa',
-    },
-    signature_type: 'ecdsa',
-    public_key: {
-      hex_bytes:
-        '042ab77b959e28c4fa47fa8fb9e57cec3d66df5684d076ac2e4c5f28fd69a23dd31a59f908c8add51eab3530b4ac5d015166eaf2198c52fa9a8df7cfaeb8fdb7d4',
-      curve_type: 'secp256k1',
-    },
-    hex_bytes:
-      '7e995be0c48d6e45c7fb671e53da580023bcca0346b346c7374d379d5d98b0205a304e9f9653694239c0e54d39503dbab5b0d3bcc64ca5f03f37de6a4300b6bd',
-  },
-  {
-    signing_payload: {
-      account_identifier: {
-        address: '0af815da8259ba8bb3d34fbfb2ac730f07a1adc81438d40d667d91b408b25f2f',
-      },
-      hex_bytes: '0a69632d726571756573741c174f275615e80d7280542bf373e2ecfa59c3a1d87475feed0a97203fb22f37',
-      signature_type: 'ecdsa',
-    },
-    signature_type: 'ecdsa',
-    public_key: {
-      hex_bytes:
-        '042ab77b959e28c4fa47fa8fb9e57cec3d66df5684d076ac2e4c5f28fd69a23dd31a59f908c8add51eab3530b4ac5d015166eaf2198c52fa9a8df7cfaeb8fdb7d4',
-      curve_type: 'secp256k1',
-    },
-    hex_bytes:
-      '9ee8331ab5b3cab1047b34540c5f74b89d3bb754cef793c09a7e728b781609531a84796c1e6f8474014f75c4918d68eb314ee487f6c64878a039cf3fe618e184',
-  },
-  {
-    signing_payload: {
-      account_identifier: {
-        address: '0af815da8259ba8bb3d34fbfb2ac730f07a1adc81438d40d667d91b408b25f2f',
-      },
-      hex_bytes: '0a69632d726571756573741814112eb6162e3dc5cc6a5a87c9ec2a6578e762059ec7510591aad208e7cded',
-      signature_type: 'ecdsa',
-    },
-    signature_type: 'ecdsa',
-    public_key: {
-      hex_bytes:
-        '042ab77b959e28c4fa47fa8fb9e57cec3d66df5684d076ac2e4c5f28fd69a23dd31a59f908c8add51eab3530b4ac5d015166eaf2198c52fa9a8df7cfaeb8fdb7d4',
-      curve_type: 'secp256k1',
-    },
-    hex_bytes:
-      '4ae4da61c3ef1b04e32fbb1b7c0b79ad89bb2b45501dbe2b84a4216df90a1038800e8e477e3eb52f1b91acfd14972279544ca940d5853fc7dcb2bc12dd0428ab',
-  },
 ];
 
 export const signedTransaction =
-  'b9000168726571756573747381826b5452414e53414354494f4e83b9000266757064617465b9000367636f6e74656e74b900066c726571756573745f747970656463616c6c6b63616e69737465725f69644a000000000000000201016b6d6574686f645f6e616d656773656e645f70626361726758400a0308d20912040a02080a1a0308904e2a220a20c3d30f404955975adaba89f2e1ebc75c1f44a6a204578afce8f3780d64fe252e3a0a088084dcb3abb69694186673656e646572581dd5fc1dc4d74d4aa35d81cf345533d20548113412d32fffdcece2f68a026e696e67726573735f6578706972791b182859ea979462006d73656e6465725f7075626b6579d84058583056301006072a8648ce3d020106052b8104000a034200042ab77b959e28c4fa47fa8fb9e57cec3d66df5684d076ac2e4c5f28fd69a23dd31a59f908c8add51eab3530b4ac5d015166eaf2198c52fa9a8df7cfaeb8fdb7d46a73656e6465725f736967584011d903fe529788a2202a261568066371e2022ddb339379368e19567473b3c2d7a88e032684652109ec8d9ef6b6600c479620ca690b26ecf07678b3ee307d13756a726561645f7374617465b9000367636f6e74656e74b900046c726571756573745f747970656a726561645f73746174656673656e646572581dd5fc1dc4d74d4aa35d81cf345533d20548113412d32fffdcece2f68a0265706174687381824e726571756573745f73746174757358202dd9527902e38bc015d4f5521e680b29d1ebc5b4fe24dd5515e2abe99097f0b16e696e67726573735f6578706972791b182859ea979462006d73656e6465725f7075626b6579d84058583056301006072a8648ce3d020106052b8104000a034200042ab77b959e28c4fa47fa8fb9e57cec3d66df5684d076ac2e4c5f28fd69a23dd31a59f908c8add51eab3530b4ac5d015166eaf2198c52fa9a8df7cfaeb8fdb7d46a73656e6465725f7369675840b50df90e4c94e45d4bd7117d98380d104f19cf7053814887acfe4d6ad24b08f8735473b00e5740beef2e675d98764dc22ab44c653ecf65281cc46601d2802eb5b9000266757064617465b9000367636f6e74656e74b900066c726571756573745f747970656463616c6c6b63616e69737465725f69644a000000000000000201016b6d6574686f645f6e616d656773656e645f70626361726758400a0308d20912040a02080a1a0308904e2a220a20c3d30f404955975adaba89f2e1ebc75c1f44a6a204578afce8f3780d64fe252e3a0a088084dcb3abb69694186673656e646572581dd5fc1dc4d74d4aa35d81cf345533d20548113412d32fffdcece2f68a026e696e67726573735f6578706972791b18285a06882312006d73656e6465725f7075626b6579d84058583056301006072a8648ce3d020106052b8104000a034200042ab77b959e28c4fa47fa8fb9e57cec3d66df5684d076ac2e4c5f28fd69a23dd31a59f908c8add51eab3530b4ac5d015166eaf2198c52fa9a8df7cfaeb8fdb7d46a73656e6465725f7369675840005e67fcb5f5937b969b64eca79077030e7a0e9841dc6babca4211167c32799235b16823f37ba8b9431293705ac4b5e62c6fa18e0ea265a121f58d368295d45c6a726561645f7374617465b9000367636f6e74656e74b900046c726571756573745f747970656a726561645f73746174656673656e646572581dd5fc1dc4d74d4aa35d81cf345533d20548113412d32fffdcece2f68a0265706174687381824e726571756573745f737461747573582076265b535aeeda1b30f9a276a62e9247c9288d518349d68b504e9db5f9fd75636e696e67726573735f6578706972791b18285a06882312006d73656e6465725f7075626b6579d84058583056301006072a8648ce3d020106052b8104000a034200042ab77b959e28c4fa47fa8fb9e57cec3d66df5684d076ac2e4c5f28fd69a23dd31a59f908c8add51eab3530b4ac5d015166eaf2198c52fa9a8df7cfaeb8fdb7d46a73656e6465725f73696758407e995be0c48d6e45c7fb671e53da580023bcca0346b346c7374d379d5d98b0205a304e9f9653694239c0e54d39503dbab5b0d3bcc64ca5f03f37de6a4300b6bdb9000266757064617465b9000367636f6e74656e74b900066c726571756573745f747970656463616c6c6b63616e69737465725f69644a000000000000000201016b6d6574686f645f6e616d656773656e645f70626361726758400a0308d20912040a02080a1a0308904e2a220a20c3d30f404955975adaba89f2e1ebc75c1f44a6a204578afce8f3780d64fe252e3a0a088084dcb3abb69694186673656e646572581dd5fc1dc4d74d4aa35d81cf345533d20548113412d32fffdcece2f68a026e696e67726573735f6578706972791b18285a2278b1c2006d73656e6465725f7075626b6579d84058583056301006072a8648ce3d020106052b8104000a034200042ab77b959e28c4fa47fa8fb9e57cec3d66df5684d076ac2e4c5f28fd69a23dd31a59f908c8add51eab3530b4ac5d015166eaf2198c52fa9a8df7cfaeb8fdb7d46a73656e6465725f73696758409ee8331ab5b3cab1047b34540c5f74b89d3bb754cef793c09a7e728b781609531a84796c1e6f8474014f75c4918d68eb314ee487f6c64878a039cf3fe618e1846a726561645f7374617465b9000367636f6e74656e74b900046c726571756573745f747970656a726561645f73746174656673656e646572581dd5fc1dc4d74d4aa35d81cf345533d20548113412d32fffdcece2f68a0265706174687381824e726571756573745f73746174757358201c174f275615e80d7280542bf373e2ecfa59c3a1d87475feed0a97203fb22f376e696e67726573735f6578706972791b18285a2278b1c2006d73656e6465725f7075626b6579d84058583056301006072a8648ce3d020106052b8104000a034200042ab77b959e28c4fa47fa8fb9e57cec3d66df5684d076ac2e4c5f28fd69a23dd31a59f908c8add51eab3530b4ac5d015166eaf2198c52fa9a8df7cfaeb8fdb7d46a73656e6465725f73696758404ae4da61c3ef1b04e32fbb1b7c0b79ad89bb2b45501dbe2b84a4216df90a1038800e8e477e3eb52f1b91acfd14972279544ca940d5853fc7dcb2bc12dd0428ab';
+  'b9000168726571756573747381826b5452414e53414354494f4e81b9000266757064617465b9000367636f6e74656e74b900066c726571756573745f747970656463616c6c6b63616e69737465725f69644a000000000000000201016b6d6574686f645f6e616d656773656e645f70626361726758400a0308d20912040a02080a1a0308904e2a220a20c3d30f404955975adaba89f2e1ebc75c1f44a6a204578afce8f3780d64fe252e3a0a088084dcb3abb69694186673656e646572581dd5fc1dc4d74d4aa35d81cf345533d20548113412d32fffdcece2f68a026e696e67726573735f6578706972791b182859ea979462006d73656e6465725f7075626b6579d84058583056301006072a8648ce3d020106052b8104000a034200042ab77b959e28c4fa47fa8fb9e57cec3d66df5684d076ac2e4c5f28fd69a23dd31a59f908c8add51eab3530b4ac5d015166eaf2198c52fa9a8df7cfaeb8fdb7d46a73656e6465725f736967584011d903fe529788a2202a261568066371e2022ddb339379368e19567473b3c2d75771fcd97b9adef613726109499ff3b7248e127da421b34b4959aa9e9fb92dcc6a726561645f7374617465b9000367636f6e74656e74b900046c726571756573745f747970656a726561645f73746174656673656e646572581dd5fc1dc4d74d4aa35d81cf345533d20548113412d32fffdcece2f68a0265706174687381824e726571756573745f73746174757358202dd9527902e38bc015d4f5521e680b29d1ebc5b4fe24dd5515e2abe99097f0b16e696e67726573735f6578706972791b182859ea979462006d73656e6465725f7075626b6579d84058583056301006072a8648ce3d020106052b8104000a034200042ab77b959e28c4fa47fa8fb9e57cec3d66df5684d076ac2e4c5f28fd69a23dd31a59f908c8add51eab3530b4ac5d015166eaf2198c52fa9a8df7cfaeb8fdb7d46a73656e6465725f7369675840b50df90e4c94e45d4bd7117d98380d104f19cf7053814887acfe4d6ad24b08f8735473b00e5740beef2e675d98764dc22ab44c653ecf65281cc46601d2802eb5';
 
 export const ParsedUnsignedTransaction = {
   operations: [

modules/sdk-coin-icp/test/unit/transactionBuilder/transactionBuilder.ts

@@ -52,6 +52,7 @@ describe('ICP Transaction Builder', async () => {
     should.equal(icpTransaction.public_keys[0].hex_bytes, testData.accounts.account1.publicKey);
     payloadsData.unsigned_transaction.should.be.a.String();
     payloadsData.payloads.should.be.an.Array();
+    payloadsData.payloads.length.should.equal(2);
     should.equal(payloadsData.unsigned_transaction, testData.payloadsData.unsigned_transaction);
     should.deepEqual(payloadsData.payloads, testData.payloadsData.payloads);
   });