Merge pull request #5825 from BitGo/BTC-1946

feat(express): add includeBalance option when fetching lightning wallets

Author: lcovar

modules/express/src/lightning/lightningSignerRoutes.ts

@@ -84,7 +84,7 @@ export async function handleInitLightningWallet(req: express.Request): Promise<u
     }
   );
 
-  const wallet = await coin.wallets().get({ id: walletId });
+  const wallet = await coin.wallets().get({ id: walletId, includeBalance: false });
   if (wallet.subType() !== 'lightningSelfCustody') {
     throw new ApiResponseError(`not a self custodial lighting wallet ${walletId}`, 400);
   }
@@ -145,7 +145,7 @@ export async function handleCreateSignerMacaroon(req: express.Request): Promise<
     }
   );
 
-  const wallet = await coin.wallets().get({ id: walletId });
+  const wallet = await coin.wallets().get({ id: walletId, includeBalance: false });
   if (wallet.subType() !== 'lightningSelfCustody') {
     throw new ApiResponseError(`not a self custodial lighting wallet ${walletId}`, 400);
   }

modules/express/src/lightning/lightningWalletRoutes.ts

@@ -17,7 +17,7 @@ export async function handleUpdateLightningWalletCoinSpecific(req: express.Reque
   );
 
   const coin = bitgo.coin(req.params.coin);
-  const wallet = await coin.wallets().get({ id: req.params.id });
+  const wallet = await coin.wallets().get({ id: req.params.id, includeBalance: false });
 
   return await updateWalletCoinSpecific(wallet, params);
 }

modules/sdk-core/src/bitgo/wallet/iWallets.ts

@@ -23,6 +23,7 @@ export interface GetWalletOptions {
   allTokens?: boolean;
   reqId?: IRequestTracer;
   id?: string;
+  includeBalance?: boolean;
 }
 
 export interface GenerateBaseMpcWalletOptions {