Merge pull request #7023 from BitGo/harit/jito-correct-staking-deactivate-inputs-and-outputs

fix(sdk-coin-sol): remove inputs and outputs for jito deactivate

Author: noel-bitgo

modules/sdk-coin-sol/src/lib/transaction.ts

@@ -371,7 +371,11 @@ export class Transaction extends BaseTransaction {
           }
           break;
         case InstructionBuilderTypes.StakingDeactivate:
-          if (instruction.params.amount && instruction.params.unstakingAddress) {
+          if (
+            instruction.params.amount &&
+            instruction.params.unstakingAddress &&
+            instruction.params.stakingType !== SolStakingTypeEnum.JITO
+          ) {
             inputs.push({
               address: instruction.params.stakingAddress,
               value: instruction.params.amount,

modules/sdk-coin-sol/test/unit/transactionBuilder/stakingActivateBuilder.ts

@@ -105,18 +105,20 @@ describe('Sol Staking Activate Builder', () => {
         },
       },
     ]);
-    tx.inputs.length.should.equal(1);
-    tx.inputs[0].should.deepEqual({
-      address: wallet.pub,
-      value: amount,
-      coin: 'tsol',
-    });
-    tx.outputs.length.should.equal(1);
-    tx.outputs[0].should.deepEqual({
-      address: stakeAccount.pub,
-      value: amount,
-      coin: 'tsol',
-    });
+    tx.inputs.should.deepEqual([
+      {
+        address: wallet.pub,
+        value: amount,
+        coin: 'tsol',
+      },
+    ]);
+    tx.outputs.should.deepEqual([
+      {
+        address: stakeAccount.pub,
+        value: amount,
+        coin: 'tsol',
+      },
+    ]);
   };
 
   const signBuilderNativeOrMarinade = (txBuilder: StakingActivateBuilder) => {
@@ -203,13 +205,14 @@ describe('Sol Staking Activate Builder', () => {
     });
 
     txJson.instructionsData.should.deepEqual(expectedInstructions);
-    tx.inputs.length.should.equal(1);
-    tx.inputs[0].should.deepEqual({
-      address: wallet.pub,
-      value: amount,
-      coin: 'tsol',
-    });
-    tx.outputs.length.should.equal(0);
+    tx.inputs.should.deepEqual([
+      {
+        address: wallet.pub,
+        value: amount,
+        coin: 'tsol',
+      },
+    ]);
+    tx.outputs.should.deepEqual([]);
   };
 
   describe('Succeed', () => {

modules/sdk-coin-sol/test/unit/transactionBuilder/stakingDeactivateBuilder.ts

@@ -346,6 +346,8 @@ describe('Sol Staking Deactivate Builder', () => {
                 },
               },
             ]);
+            tx.inputs.should.deepEqual([]);
+            tx.outputs.should.deepEqual([]);
           },
           knownRawTx: testData.JITO_STAKING_DEACTIVATE_SIGNED_TX,
         });