Merge pull request #5937 from BitGo/eric/SC-1424-fix-signing

sbplat · web-flow · commit a2535128aa50 · 2025-04-10T18:19:42.000-04:00
fix(sdk-core): messageEncoded is encoded as hex
diff --git a/modules/sdk-core/src/bitgo/utils/tss/ecdsa/ecdsaMPCv2.ts b/modules/sdk-core/src/bitgo/utils/tss/ecdsa/ecdsaMPCv2.ts
@@ -737,7 +737,7 @@ export class EcdsaMPCv2Utils extends BaseEcdsaUtils {
     } else if (requestType === RequestType.message) {
       txOrMessageToSign = txRequest.messages![0].messageEncoded;
       derivationPath = txRequest.messages![0].derivationPath || 'm/0';
-      bufferContent = Buffer.from(txOrMessageToSign);
+      bufferContent = Buffer.from(txOrMessageToSign, 'hex');
     } else {
       throw new Error('Invalid request type');
     }

Original file line number	Diff line number	Diff line change
`@@ -737,7 +737,7 @@ export class EcdsaMPCv2Utils extends BaseEcdsaUtils {`
`737`	`737`	`} else if (requestType === RequestType.message) {`
`738`	`738`	`txOrMessageToSign = txRequest.messages![0].messageEncoded;`
`739`	`739`	`derivationPath = txRequest.messages![0].derivationPath \|\| 'm/0';`
`740`		`- bufferContent = Buffer.from(txOrMessageToSign);`
	`740`	`+ bufferContent = Buffer.from(txOrMessageToSign, 'hex');`
`741`	`741`	`} else {`
`742`	`742`	`throw new Error('Invalid request type');`
`743`	`743`	`}`