Merge pull request #6281 from BitGo/coin-4471

feat(sdk-coin-vet): implement isValidBlockId for vet

Author: baltiyal

modules/sdk-coin-vet/src/lib/constants.ts

@@ -1,2 +1,3 @@
-export const DEFAULT_GAS_UNIT_PRICE = 100;
 export const VET_TRANSACTION_ID_LENGTH = 64;
+export const VET_ADDRESS_LENGTH = 40;
+export const VET_BLOCK_ID_LENGTH = 64;

modules/sdk-coin-vet/src/lib/utils.ts

@@ -1,15 +1,15 @@
 import { BaseUtils, TransactionType } from '@bitgo/sdk-core';
-import { VET_TRANSACTION_ID_LENGTH } from './constants';
+import { VET_ADDRESS_LENGTH, VET_BLOCK_ID_LENGTH, VET_TRANSACTION_ID_LENGTH } from './constants';
 import { KeyPair } from './keyPair';
 import { HexUInt, Transaction, TransactionClause } from '@vechain/sdk-core';
 
 export class Utils implements BaseUtils {
   isValidAddress(address: string): boolean {
-    return /^0x[0-9a-fA-F]{40}$/.test(address);
+    return this.isValidHex(address, VET_ADDRESS_LENGTH);
   }
 
   isValidBlockId(hash: string): boolean {
-    throw new Error('Method not implemented');
+    return this.isValidHex(hash, VET_BLOCK_ID_LENGTH);
   }
 
   isValidPrivateKey(key: string): boolean {

modules/sdk-coin-vet/test/resources/vet.ts

@@ -31,6 +31,18 @@ export const addresses = {
   ],
 };
 
+export const blockIds: { validBlockIds: string[]; invalidBlockIds: string[] } = {
+  validBlockIds: [
+    '0x014f12ed94c4b4770f7f9a73e2aa41a9dfbac02a49f36ec05acfdba8c7244ff0',
+    '0x014f130d00a2fe06d471a35e7f2cd18d25bdefe5370c07a2ad68c0ae3852ad86',
+  ],
+  invalidBlockIds: [
+    'randomString',
+    '0xc4173a804406a365e69dfb297ddfgsdcvf',
+    '5ne7phA48Jrvpn39AtupB8ZkCCAy8gLTfpGihZPuDqen',
+  ],
+};
+
 export const invalidRecipients: Recipient[] = [
   {
     address: addresses.invalidAddresses[0],

modules/sdk-coin-vet/test/unit/utils.ts

@@ -24,6 +24,25 @@ describe('Vechain util library', function () {
     });
   });
 
+  describe('isValidBlockId', function () {
+    it('should succeed to validate valid block IDs', function () {
+      for (const blockId of testData.blockIds.validBlockIds) {
+        should.equal(utils.isValidBlockId(blockId), true);
+      }
+    });
+
+    it('should fail to validate invalid block IDs', function () {
+      for (const blockId of testData.blockIds.invalidBlockIds) {
+        should.doesNotThrow(() => utils.isValidBlockId(blockId));
+        should.equal(utils.isValidBlockId(blockId), false);
+      }
+      // @ts-expect-error Testing for missing param, should not throw an error
+      should.doesNotThrow(() => utils.isValidBlockId(undefined));
+      // @ts-expect-error Testing for missing param, should return false
+      should.equal(utils.isValidBlockId(undefined), false);
+    });
+  });
+
   describe('isValidDeserialize', function () {
     it('should succeed to correctly deserialize sponsored signed serialized transaction', function () {
       const signedTxn: VetTransaction = utils.deserializeTransaction(testData.SPONSORED_TRANSACTION);