Merge pull request #5500 from BitGo/coin-3052-fix-apt-withdrawal-bugs

fix(sdk-coin-apt): stip hex prefix

Author: dialsquare1886

modules/sdk-coin-apt/src/lib/utils.ts

@@ -43,6 +43,7 @@ export class Utils implements BaseUtils {
 
   /** @inheritdoc */
   isValidPublicKey(key: string): boolean {
+    key = this.stripHexPrefix(key);
     return isValidEd25519PublicKey(key);
   }
 
@@ -102,6 +103,15 @@ export class Utils implements BaseUtils {
   castToNumber(value: bigint): number {
     return new BigNumber(value.toString()).toNumber();
   }
+
+  /**
+   * Strip hex prefix
+   * @param str
+   * @returns hex string without 0x prefix
+   */
+  stripHexPrefix(str: string): string {
+    return str.replace(/^0x/i, '');
+  }
 }
 
 const utils = new Utils();

modules/sdk-coin-apt/test/unit/apt.ts

@@ -64,6 +64,13 @@ describe('APT:', function () {
     tapt.getBaseFactor().should.equal(1e8);
   });
 
+  it('is valid pub', function () {
+    // with 0x prefix
+    basecoin.isValidPub('0x9b4e96086d111500259f9b38680b0509a405c1904da18976455a20c691d3bb07').should.equal(true);
+    // without 0x prefix
+    basecoin.isValidPub('9b4e96086d111500259f9b38680b0509a405c1904da18976455a20c691d3bb07').should.equal(true);
+  });
+
   describe('Verify transaction: ', () => {
     it('should succeed to verify transaction', async function () {
       const txPrebuild = newTxPrebuild();

modules/sdk-coin-apt/test/unit/utils.ts

@@ -36,4 +36,16 @@ describe('Aptos util library', function () {
       should.throws(() => utils.deserializeSignedTransaction(testData.INVALID_TRANSFER));
     });
   });
+
+  it('strip hex prefix', function () {
+    const s = utils.stripHexPrefix('0x9b4e96086d111500259f9b38680b0509a405c1904da18976455a20c691d3bb07');
+    should.equal(s, '9b4e96086d111500259f9b38680b0509a405c1904da18976455a20c691d3bb07');
+  });
+
+  it('is valid public key', function () {
+    // with 0x prefix
+    should.equal(true, utils.isValidPublicKey('0x9b4e96086d111500259f9b38680b0509a405c1904da18976455a20c691d3bb07'));
+    // without 0x prefix
+    should.equal(true, utils.isValidPublicKey('9b4e96086d111500259f9b38680b0509a405c1904da18976455a20c691d3bb07'));
+  });
 });