Merge pull request #5789 from BitGo/SC-1375-add-finality-provider-address-validation

fix(sdk-coin-baby): add support for finality provider address

Author: ewangbitgo

modules/sdk-coin-baby/src/baby.ts

@@ -39,7 +39,8 @@ export class Baby extends CosmosCoin {
 
   /** @inheritDoc **/
   isValidAddress(address: string): boolean {
-    return utils.isValidAddress(address) || utils.isValidValidatorAddress(address);
+    const isValidFinalAddress = utils.isValidHexString(address) && address.length === 64;
+    return utils.isValidAddress(address) || utils.isValidValidatorAddress(address) || isValidFinalAddress;
   }
 
   /** @inheritDoc **/

modules/sdk-coin-baby/test/resources/baby.ts

@@ -174,6 +174,7 @@ export const address = {
   invalidMemoIdAddress: 'bbn1274ep8pnrlej5vgmtwppysynzcd4fhxc3ku0t3?memoId=-1',
   invalidMemoIdAddress2: 'bbn1274ep8pnrlej5vgmtwppysynzcd4fhxc3ku0t3?memoId=1.23',
   multipleMemoIdAddress: 'bbn1274ep8pnrlej5vgmtwppysynzcd4fhxc3ku0t3?memoId=3&memoId=12',
+  finalityProviderAddress: 'e4889630fa8695dae630c41cd9b85ef165ccc2dc5e5935d5a24393a9defee9ef',
 };
 
 export const blockHash = {

modules/sdk-coin-baby/test/unit/baby.ts

@@ -90,6 +90,7 @@ describe('Babylon', function () {
       should.equal(utils.isValidAddress(address.validMemoIdAddress2), true);
       should.equal(utils.isValidAddress(address.multipleMemoIdAddress), false);
     });
+
     it('should validate validator addresses correctly', () => {
       should.equal(utils.isValidValidatorAddress(address.validatorAddress1), true);
       should.equal(utils.isValidValidatorAddress(address.validatorAddress2), true);
@@ -99,6 +100,11 @@ describe('Babylon', function () {
       should.equal(utils.isValidValidatorAddress(undefined as unknown as string), false);
       should.equal(utils.isValidValidatorAddress(''), false);
     });
+
+    it('should finality provider addresses correctly', () => {
+      should.equal(basecoin.isValidAddress(address.finalityProviderAddress), true);
+      should.equal(basecoin.isValidAddress('dfjk35y'), false);
+    });
   });
 
   describe('Verify transaction: ', () => {