refactor: includeKeychain is type BooleanFromString

TICKET: WP-5415

Author: danielzhao122

modules/express/src/clientRoutes.ts

@@ -641,7 +641,7 @@ export async function handleV2GenerateWallet(req: ExpressApiRouteRequest<'expres
   const bitgo = req.bitgo;
   const coin = bitgo.coin(req.decoded.coin);
   const result = await coin.wallets().generateWallet(req.body);
-  if (req.query.includeKeychains === 'false') {
+  if ((req.decoded.includeKeychains as any) === false) {
     return result.wallet.toJSON();
   }
   return { ...result, wallet: result.wallet.toJSON() };

modules/express/src/typedRoutes/api/v2/generateWallet.ts

@@ -1,4 +1,5 @@
 import * as t from 'io-ts';
+import { BooleanFromString } from 'io-ts-types';
 import { httpRoute, httpRequest, optional } from '@api-ts/io-ts-http';
 import { BitgoExpressError } from '../../schemas/error';
 import { UserKeychainCodec, BackupKeychainCodec, BitgoKeychainCodec } from '../../schemas/keychain';
@@ -80,7 +81,7 @@ export const GenerateWalletV2Params = {
  */
 export const GenerateWalletV2Query = {
   /** Include user, backup and bitgo keychains along with generated wallet */
-  includeKeychains: optional(t.string),
+  includeKeychains: optional(BooleanFromString),
 };
 
 /**

modules/express/test/unit/clientRoutes/generateWallet.ts

@@ -101,12 +101,13 @@ describe('Generate Wallet', () => {
         coin,
       },
       query: {
-        includeKeychains: 'true',
+        includeKeychains: true,
       },
       body: walletGenerateBody,
       decoded: {
         ...walletGenerateBody,
         coin,
+        includeKeychains: true,
       },
     } as unknown as ExpressApiRouteRequest<'express.wallet.generate', 'post'>;
 
@@ -186,12 +187,13 @@ describe('Generate Wallet', () => {
         coin,
       },
       query: {
-        includeKeychains: 'false',
+        includeKeychains: false,
       },
       body: walletGenerateBody,
       decoded: {
         ...walletGenerateBody,
         coin,
+        includeKeychains: false,
       },
     } as unknown as ExpressApiRouteRequest<'express.wallet.generate', 'post'>;