Merge pull request #6069 from BitGo/COIN-3222-bsc-fix

fix(sdk-coin-bsc): override verifytsstxn method for bsc

Author: mullapudipruthvik

modules/abstract-eth/src/abstractEthLikeNewCoins.ts

@@ -343,7 +343,7 @@ interface EthTransactionParams extends TransactionParams {
   tokenName?: string;
 }
 
-interface VerifyEthTransactionOptions extends VerifyTransactionOptions {
+export interface VerifyEthTransactionOptions extends VerifyTransactionOptions {
   txPrebuild: TransactionPrebuild;
   txParams: EthTransactionParams;
 }

modules/sdk-coin-bsc/src/bsc.ts

@@ -1,6 +1,10 @@
 import { BaseCoin, BitGoBase, common, MPCAlgorithm, MultisigType, multisigTypes } from '@bitgo/sdk-core';
 import { BaseCoin as StaticsBaseCoin, coins } from '@bitgo/statics';
-import { AbstractEthLikeNewCoins, recoveryBlockchainExplorerQuery } from '@bitgo/abstract-eth';
+import {
+  AbstractEthLikeNewCoins,
+  recoveryBlockchainExplorerQuery,
+  VerifyEthTransactionOptions,
+} from '@bitgo/abstract-eth';
 import { TransactionBuilder } from './lib';
 
 export class Bsc extends AbstractEthLikeNewCoins {
@@ -41,4 +45,34 @@ export class Bsc extends AbstractEthLikeNewCoins {
     const explorerUrl = common.Environments[this.bitgo.getEnv()].bscscanBaseUrl;
     return await recoveryBlockchainExplorerQuery(query, explorerUrl as string, apiToken);
   }
+
+  /**
+   * Verify if a tss transaction is valid
+   *
+   * @param {VerifyEthTransactionOptions} params
+   * @param {TransactionParams} params.txParams - params object passed to send
+   * @param {TransactionPrebuild} params.txPrebuild - prebuild object returned by server
+   * @param {Wallet} params.wallet - Wallet object to obtain keys to verify against
+   * @returns {boolean}
+   */
+  async verifyTssTransaction(params: VerifyEthTransactionOptions): Promise<boolean> {
+    const { txParams, txPrebuild, wallet } = params;
+    if (
+      !txParams?.recipients &&
+      !(
+        txParams.prebuildTx?.consolidateId ||
+        (txParams.type && ['acceleration', 'fillNonce', 'transferToken'].includes(txParams.type))
+      )
+    ) {
+      throw new Error(`missing txParams`);
+    }
+    if (!wallet || !txPrebuild) {
+      throw new Error(`missing params`);
+    }
+    if (txParams.hop && txParams.recipients && txParams.recipients.length > 1) {
+      throw new Error(`tx cannot be both a batch and hop transaction`);
+    }
+
+    return true;
+  }
 }

modules/sdk-coin-bsc/src/bscToken.ts

@@ -4,7 +4,7 @@
 
 import { EthLikeTokenConfig, coins } from '@bitgo/statics';
 import { BitGoBase, CoinConstructor, NamedCoinConstructor, MPCAlgorithm } from '@bitgo/sdk-core';
-import { CoinNames, EthLikeToken } from '@bitgo/abstract-eth';
+import { CoinNames, EthLikeToken, VerifyEthTransactionOptions } from '@bitgo/abstract-eth';
 import { TransactionBuilder } from './lib';
 
 export { EthLikeTokenConfig };
@@ -43,4 +43,33 @@ export class BscToken extends EthLikeToken {
   getFullName(): string {
     return 'Bsc Token';
   }
+  /**
+   * Verify if a tss transaction is valid
+   *
+   * @param {VerifyEthTransactionOptions} params
+   * @param {TransactionParams} params.txParams - params object passed to send
+   * @param {TransactionPrebuild} params.txPrebuild - prebuild object returned by server
+   * @param {Wallet} params.wallet - Wallet object to obtain keys to verify against
+   * @returns {boolean}
+   */
+  async verifyTssTransaction(params: VerifyEthTransactionOptions): Promise<boolean> {
+    const { txParams, txPrebuild, wallet } = params;
+    if (
+      !txParams?.recipients &&
+      !(
+        txParams.prebuildTx?.consolidateId ||
+        (txParams.type && ['acceleration', 'fillNonce', 'transferToken'].includes(txParams.type))
+      )
+    ) {
+      throw new Error(`missing txParams`);
+    }
+    if (!wallet || !txPrebuild) {
+      throw new Error(`missing params`);
+    }
+    if (txParams.hop && txParams.recipients && txParams.recipients.length > 1) {
+      throw new Error(`tx cannot be both a batch and hop transaction`);
+    }
+
+    return true;
+  }
 }