Skip to content

Commit ba93a73

Browse files
Merge pull request #5724 from BitGo/BTC-0
feat: allow pre-release versions in package dependency checks
2 parents a8f5223 + 23ee456 commit ba93a73

File tree

1 file changed

+10
-4
lines changed

1 file changed

+10
-4
lines changed

check-package-versions.js

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -87,10 +87,16 @@ async function main() {
8787
for (const dep of mod.deps) {
8888
const depVersion = getDependencyVersion(mod.path, dep);
8989
if (depVersion && depVersion !== expectedVersions[dep]) {
90-
console.log(
91-
`error: expected lerna-managed module ${mod.name} to depend on package ${dep} using version ${expectedVersions[dep]}, but found version ${depVersion} instead`
92-
);
93-
exitCode = 1;
90+
// Handle pre-release versions by checking if the base version matches
91+
const baseDepVersion = depVersion.split('-')[0];
92+
const baseExpectedVersion = expectedVersions[dep].split('-')[0];
93+
94+
if (baseDepVersion !== baseExpectedVersion) {
95+
console.log(
96+
`error: expected lerna-managed module ${mod.name} to depend on package ${dep} using version ${expectedVersions[dep]}, but found version ${depVersion} instead`
97+
);
98+
exitCode = 1;
99+
}
94100
}
95101
}
96102
}

0 commit comments

Comments
 (0)