refactor(abstract-utxo): move AbstractUtxoCoinWallet to its own file

We want to add more code here

Issue: BTC-1450

Author: OttoAllmendinger

modules/abstract-utxo/src/abstractUtxoCoin.ts

@@ -57,30 +57,30 @@ import {
   VerifyAddressOptions as BaseVerifyAddressOptions,
   VerifyTransactionOptions as BaseVerifyTransactionOptions,
   Wallet,
-  WalletData,
 } from '@bitgo/sdk-core';
 import { isReplayProtectionUnspent } from './replayProtection';
 import { signAndVerifyPsbt, signAndVerifyWalletTransaction } from './sign';
 import { supportedCrossChainRecoveries } from './config';
 import {
   assertValidTransactionRecipient,
   explainTx,
-  parseTransaction,
-  verifyTransaction,
   fromExtendedAddressFormat,
   isScriptRecipient,
+  parseTransaction,
+  verifyTransaction,
 } from './transaction';
 import { assertDescriptorWalletAddress, getDescriptorMapFromWallet, isDescriptorWallet } from './descriptor';
 
 import { getChainFromNetwork, getFamilyFromNetwork, getFullNameFromNetwork } from './names';
 import { CustomChangeOptions } from './transaction/fixedScript';
 import { toBip32Triple, UtxoKeychain, UtxoNamedKeychains } from './keychains';
+import { verifyKeySignature, verifyUserPublicKey } from './verifyKey';
+import { getPolicyForEnv } from './descriptor/validatePolicy';
+import { AbstractUtxoCoinWallet } from './wallet';
 
 const debug = debugLib('bitgo:v2:utxo');
 
 import ScriptType2Of3 = utxolib.bitgo.outputScripts.ScriptType2Of3;
-import { verifyKeySignature, verifyUserPublicKey } from './verifyKey';
-import { getPolicyForEnv } from './descriptor/validatePolicy';
 
 type UtxoCustomSigningFunction<TNumber extends number | bigint> = {
   (params: {
@@ -198,23 +198,6 @@ export interface TransactionParams extends BaseTransactionParams {
   rbfTxIds?: string[];
 }
 
-// parseTransactions' return type makes use of WalletData's type but with customChangeKeySignatures as required.
-export interface AbstractUtxoCoinWalletData extends WalletData {
-  customChangeKeySignatures: {
-    user: string;
-    backup: string;
-    bitgo: string;
-  };
-}
-
-export class AbstractUtxoCoinWallet extends Wallet {
-  public _wallet: AbstractUtxoCoinWalletData;
-
-  constructor(bitgo: BitGoBase, baseCoin: IBaseCoin, walletData: any) {
-    super(bitgo, baseCoin, walletData);
-  }
-}
-
 export interface ParseTransactionOptions<TNumber extends number | bigint = number> extends BaseParseTransactionOptions {
   txParams: TransactionParams;
   txPrebuild: TransactionPrebuild<TNumber>;

modules/abstract-utxo/src/descriptor/descriptorWallet.ts

@@ -3,8 +3,8 @@ import { IWallet, WalletCoinSpecific } from '@bitgo/sdk-core';
 
 import { NamedDescriptor } from './NamedDescriptor';
 import { DescriptorMap } from '../core/descriptor';
-import { AbstractUtxoCoinWalletData } from '../abstractUtxoCoin';
 import { DescriptorValidationPolicy, KeyTriple, toDescriptorMapValidate } from './validatePolicy';
+import { AbstractUtxoCoinWalletData } from '../wallet';
 
 type DescriptorWalletCoinSpecific = {
   descriptors: NamedDescriptor[];

modules/abstract-utxo/src/wallet.ts

@@ -0,0 +1,18 @@
+import { BitGoBase, IBaseCoin, Wallet, WalletData } from '@bitgo/sdk-core';
+
+// parseTransactions' return type makes use of WalletData's type but with customChangeKeySignatures as required.
+export interface AbstractUtxoCoinWalletData extends WalletData {
+  customChangeKeySignatures: {
+    user: string;
+    backup: string;
+    bitgo: string;
+  };
+}
+
+export class AbstractUtxoCoinWallet extends Wallet {
+  public _wallet: AbstractUtxoCoinWalletData;
+
+  constructor(bitgo: BitGoBase, baseCoin: IBaseCoin, walletData: any) {
+    super(bitgo, baseCoin, walletData);
+  }
+}

modules/abstract-utxo/test/descriptor/descriptorWallet.ts

@@ -1,6 +1,6 @@
 import assert from 'assert';
 import { getDescriptorMapFromWallet, isDescriptorWallet } from '../../src/descriptor';
-import { AbstractUtxoCoinWallet } from '../../src';
+import { AbstractUtxoCoinWallet } from '../../src/wallet';
 import { getDefaultXPubs, getDescriptorMap } from '../core/descriptor/descriptor.utils';
 import { toBip32Triple } from '../../src/keychains';