Merge pull request #5936 from BitGo/WIN-5178-add-hash-function-icp

feat(sdk-coin-icp): implement getHashFunction

TICKET: WIN-5189

Author: mohd-kashif

modules/sdk-coin-icp/src/icp.ts

@@ -18,8 +18,6 @@ import {
   SignTransactionOptions,
   TssVerifyAddressOptions,
   VerifyTransactionOptions,
-  InvalidAddressError,
-  UnexpectedAddressError,
 } from '@bitgo/sdk-core';
 import { coins, BaseCoin as StaticsBaseCoin } from '@bitgo/statics';
 import { Principal } from '@dfinity/principal';
@@ -40,11 +38,9 @@ import {
   Signatures,
   SigningPayload,
   IcpTransactionExplanation,
-  IcpCoinSpecific,
 } from './lib/iface';
 import { TransactionBuilderFactory } from './lib/transactionBuilderFactory';
 import utils from './lib/utils';
-import { Transaction } from './lib';
 
 /**
  * Class representing the Internet Computer (ICP) coin.
@@ -90,13 +86,15 @@ export class Icp extends BaseCoin {
   }
 
   async explainTransaction(params: { txHex: string }): Promise<IcpTransactionExplanation> {
-    const transaction = (await (await this.getBuilderFactory().from(params.txHex)).build()) as Transaction;
+    const factory = this.getBuilderFactory();
+    const txBuilder = await factory.from(params.txHex);
+    const transaction = await txBuilder.build();
     return transaction.explainTransaction();
   }
 
   async verifyTransaction(params: VerifyTransactionOptions): Promise<boolean> {
     const { txParams, txPrebuild } = params;
-    const { txHex } = txPrebuild;
+    const txHex = txPrebuild?.txHex;
     if (!txHex) {
       throw new Error('txHex is required');
     }
@@ -113,22 +111,18 @@ export class Icp extends BaseCoin {
       const output = explainedTx.outputs[0];
       const recipient = txParams.recipients[0];
       assert(
-        output.address === recipient.address && BigNumber(output.amount).eq(BigNumber(recipient.amount)),
+        typeof recipient.address === 'string' &&
+          typeof output.address === 'string' &&
+          output.address === recipient.address &&
+          BigNumber(output.amount).eq(BigNumber(recipient.amount)),
         'Tx outputs does not match with expected txParams recipients'
       );
     }
     return true;
   }
 
   async isWalletAddress(params: TssVerifyAddressOptions): Promise<boolean> {
-    if (!this.isValidAddress(params.address)) {
-      throw new InvalidAddressError(`invalid address: ${params.address}`);
-    }
-    const rootAddress = (params.coinSpecific as IcpCoinSpecific).rootAddress;
-    if (params.address.includes(rootAddress)) {
-      throw new UnexpectedAddressError(`address validation failure: ${params.address} vs ${rootAddress}`);
-    }
-    return true;
+    return this.isValidAddress(params.address);
   }
 
   async parseTransaction(params: ParseTransactionOptions): Promise<ParsedTransaction> {

modules/sdk-coin-icp/src/lib/iface.ts

@@ -194,7 +194,3 @@ export interface RecoveryOptions {
 export interface PublicNodeSubmitResponse {
   status: string;
 }
-
-export interface IcpCoinSpecific {
-  rootAddress: string;
-}

modules/sdk-coin-icp/src/lib/index.ts

@@ -1,9 +1,9 @@
 import * as Utils from './utils';
+export * from './iface';
 
 export { KeyPair } from './keyPair';
 export { TransactionBuilder } from './transactionBuilder';
 export { TransferBuilder } from './transferBuilder';
 export { TransactionBuilderFactory } from './transactionBuilderFactory';
 export { Transaction } from './transaction';
-export { Signatures, SignatureType } from './iface';
 export { Utils };