refactor: added decoding test to UT

TICKET: WP-5447

Author: danielzhao122

modules/express/src/typedRoutes/api/v2/lightningState.ts

@@ -13,14 +13,16 @@ export const LightningStateParams = {
   walletId: t.string,
 };
 
+export const LightningStateResponse200 = t.type({
+  state: WalletState,
+});
+
 /**
  * Response for getting lightning node state
  */
 export const LightningStateResponse = {
   /** Current Lightning wallet/node state('NON_EXISTING' | 'LOCKED' | 'UNLOCKED' | 'RPC_ACTIVE' | 'SERVER_ACTIVE' | 'WAITING_TO_START') */
-  200: t.type({
-    state: WalletState,
-  }),
+  200: LightningStateResponse200,
   /** BitGo Express error payload when the request is invalid (e.g., invalid coin or wallet not a self-custody lightning wallet). */
   400: BitgoExpressError,
 } as const;

modules/express/test/unit/clientRoutes/lightning/lightningSignerRoutes.ts

@@ -1,6 +1,6 @@
 import { TestBitGo, TestBitGoAPI } from '@bitgo/sdk-test';
 import { BitGo } from 'bitgo';
-import { common } from '@bitgo/sdk-core';
+import { common, decodeOrElse } from '@bitgo/sdk-core';
 import nock from 'nock';
 import * as express from 'express';
 import * as sinon from 'sinon';
@@ -14,6 +14,7 @@ import {
   handleUnlockLightningWallet,
 } from '../../../../src/lightning/lightningSignerRoutes';
 import { ExpressApiRouteRequest } from '../../../../src/typedRoutes/api';
+import { LightningStateResponse } from '../../../../src/typedRoutes/api/v2/lightningState';
 
 describe('Lightning signer routes', () => {
   let bitgo: TestBitGoAPI;
@@ -165,7 +166,10 @@ describe('Lightning signer routes', () => {
       },
     } as unknown as ExpressApiRouteRequest<'express.lightning.getState', 'get'>;
 
-    await handleGetLightningWalletState(req);
+    const res = await handleGetLightningWalletState(req);
+    decodeOrElse('LightningStateResponse200', LightningStateResponse[200], res, () => {
+      throw new Error('Response did not match expected codec');
+    });
 
     walletStateNock.done();
     readFileStub.calledOnceWith('lightningSignerFileSystemPath').should.be.true();