feat(abstract-utxo): enforce import order lint rule

Issue: BTC-1688

Author: OttoAllmendinger

modules/abstract-utxo/.eslintrc.js

@@ -0,0 +1,6 @@
+module.exports = {
+  extends: ['../../.eslintrc.json'],
+  rules: {
+    'import/order': ['error', { 'newlines-between': 'always' }],
+  },
+};

modules/abstract-utxo/src/abstractUtxoCoin.ts

@@ -1,23 +1,9 @@
 import assert from 'assert';
 import { randomBytes } from 'crypto';
+
 import _ from 'lodash';
 import * as utxolib from '@bitgo/utxo-lib';
 import { bip32, bitgo, getMainnet, isMainnet, isTestnet } from '@bitgo/utxo-lib';
-
-import {
-  backupKeyRecovery,
-  CrossChainRecoverySigned,
-  CrossChainRecoveryUnsigned,
-  forCoin,
-  recoverCrossChain,
-  RecoverParams,
-  RecoveryProvider,
-  v1BackupKeyRecovery,
-  V1RecoverParams,
-  v1Sweep,
-  V1SweepParams,
-} from './recovery';
-
 import {
   AddressCoinSpecific,
   AddressTypeChainMismatchError,
@@ -57,6 +43,20 @@ import {
   VerifyTransactionOptions as BaseVerifyTransactionOptions,
   Wallet,
 } from '@bitgo/sdk-core';
+
+import {
+  backupKeyRecovery,
+  CrossChainRecoverySigned,
+  CrossChainRecoveryUnsigned,
+  forCoin,
+  recoverCrossChain,
+  RecoverParams,
+  RecoveryProvider,
+  v1BackupKeyRecovery,
+  V1RecoverParams,
+  v1Sweep,
+  V1SweepParams,
+} from './recovery';
 import { isReplayProtectionUnspent } from './replayProtection';
 import { supportedCrossChainRecoveries } from './config';
 import {
@@ -68,7 +68,6 @@ import {
   verifyTransaction,
 } from './transaction';
 import { assertDescriptorWalletAddress, getDescriptorMapFromWallet, isDescriptorWallet } from './descriptor';
-
 import { getChainFromNetwork, getFamilyFromNetwork, getFullNameFromNetwork } from './names';
 import { CustomChangeOptions } from './transaction/fixedScript';
 import { toBip32Triple, UtxoKeychain, UtxoNamedKeychains } from './keychains';

modules/abstract-utxo/src/core/descriptor/psbt/parse.ts

@@ -3,6 +3,7 @@ import * as utxolib from '@bitgo/utxo-lib';
 
 import { DescriptorMap } from '../DescriptorMap';
 import { getVirtualSize } from '../VirtualSize';
+
 import { findDescriptorForInput, findDescriptorForOutput } from './findDescriptors';
 import { assertSatisfiable } from './assertSatisfiable';
 

modules/abstract-utxo/src/descriptor/assertDescriptorWalletAddress.ts

@@ -1,4 +1,5 @@
 import assert from 'assert';
+
 import * as utxolib from '@bitgo/utxo-lib';
 import { Descriptor } from '@bitgo/wasm-miniscript';
 

modules/abstract-utxo/src/descriptor/builder/parse.ts

@@ -1,6 +1,7 @@
 import { BIP32Interface } from '@bitgo/utxo-lib';
 import * as utxolib from '@bitgo/utxo-lib';
 import { Descriptor } from '@bitgo/wasm-miniscript';
+
 import { DescriptorBuilder, getDescriptorFromBuilder } from './builder';
 
 type NodeUnary<Key extends string> = { [k in Key]: unknown };

modules/abstract-utxo/src/descriptor/descriptorWallet.ts

@@ -1,11 +1,12 @@
 import * as t from 'io-ts';
 import { IWallet, WalletCoinSpecific } from '@bitgo/sdk-core';
 
-import { NamedDescriptor } from './NamedDescriptor';
 import { DescriptorMap } from '../core/descriptor';
-import { DescriptorValidationPolicy, KeyTriple, toDescriptorMapValidate } from './validatePolicy';
 import { UtxoWallet, UtxoWalletData } from '../wallet';
 
+import { NamedDescriptor } from './NamedDescriptor';
+import { DescriptorValidationPolicy, KeyTriple, toDescriptorMapValidate } from './validatePolicy';
+
 type DescriptorWalletCoinSpecific = {
   descriptors: NamedDescriptor[];
 };

modules/abstract-utxo/src/descriptor/validatePolicy.ts

@@ -2,9 +2,10 @@ import { Descriptor } from '@bitgo/wasm-miniscript';
 import { EnvironmentName, Triple } from '@bitgo/sdk-core';
 import * as utxolib from '@bitgo/utxo-lib';
 
+import { DescriptorMap, toDescriptorMap } from '../core/descriptor';
+
 import { DescriptorBuilder, parseDescriptor } from './builder';
 import { NamedDescriptor } from './NamedDescriptor';
-import { DescriptorMap, toDescriptorMap } from '../core/descriptor';
 
 export type DescriptorValidationPolicy = { allowedTemplates: DescriptorBuilder['name'][] } | 'allowAll';
 

modules/abstract-utxo/src/keychains.ts

@@ -1,4 +1,5 @@
 import assert from 'assert';
+
 import * as t from 'io-ts';
 import * as utxolib from '@bitgo/utxo-lib';
 import { IRequestTracer, IWallet, KeyIndices, promiseProps, Triple } from '@bitgo/sdk-core';

modules/abstract-utxo/src/recovery/RecoveryProvider.ts

@@ -1,7 +1,8 @@
 import { BlockchairApi, AddressInfo, TransactionIO } from '@bitgo/blockapis';
-import { ApiNotImplementedError } from './baseApi';
 import { bitgo } from '@bitgo/utxo-lib';
 
+import { ApiNotImplementedError } from './baseApi';
+
 type Unspent<TNumber extends number | bigint = number> = bitgo.Unspent<TNumber>;
 
 /**

modules/abstract-utxo/src/recovery/backupKeyRecovery.ts

@@ -1,18 +1,8 @@
 import assert from 'assert';
+
 import _ from 'lodash';
 import * as utxolib from '@bitgo/utxo-lib';
-const { getInternalChainCode, scriptTypeForChain, outputScripts, getExternalChainCode } = utxolib.bitgo;
-
-type ChainCode = utxolib.bitgo.ChainCode;
-type RootWalletKeys = utxolib.bitgo.RootWalletKeys;
-type WalletUnspent<TNumber extends number | bigint> = utxolib.bitgo.WalletUnspent<TNumber>;
-type WalletUnspentJSON = utxolib.bitgo.WalletUnspent & {
-  valueString: string;
-};
-type ScriptType2Of3 = utxolib.bitgo.outputScripts.ScriptType2Of3;
-
 import { VirtualSizes } from '@bitgo/unspents';
-
 import {
   BitGoBase,
   ErrorNoInputToRecover,
@@ -23,13 +13,24 @@ import {
   isTriple,
   krsProviders,
 } from '@bitgo/sdk-core';
+import { getMainnet, networks } from '@bitgo/utxo-lib';
+
 import { AbstractUtxoCoin, MultiSigAddress } from '../abstractUtxoCoin';
+import { signAndVerifyPsbt } from '../sign';
 
 import { forCoin, RecoveryProvider } from './RecoveryProvider';
 import { MempoolApi } from './mempoolApi';
 import { CoingeckoApi } from './coingeckoApi';
-import { signAndVerifyPsbt } from '../sign';
-import { getMainnet, networks } from '@bitgo/utxo-lib';
+
+type ScriptType2Of3 = utxolib.bitgo.outputScripts.ScriptType2Of3;
+type ChainCode = utxolib.bitgo.ChainCode;
+type RootWalletKeys = utxolib.bitgo.RootWalletKeys;
+type WalletUnspent<TNumber extends number | bigint> = utxolib.bitgo.WalletUnspent<TNumber>;
+type WalletUnspentJSON = utxolib.bitgo.WalletUnspent & {
+  valueString: string;
+};
+
+const { getInternalChainCode, scriptTypeForChain, outputScripts, getExternalChainCode } = utxolib.bitgo;
 
 export interface OfflineVaultTxInfo {
   inputs: WalletUnspentJSON[];