Merge pull request #6044 from BitGo/SC-1729

Revert "fix(sdk-coin-sui): walrus request withdraw stake should have empty inputs and outputs"

Author: sbplat

modules/sdk-coin-sui/src/lib/utils.ts

@@ -367,12 +367,6 @@ export class Utils implements BaseUtils {
     });
   }
 
-  isWalrusRequestWithdrawStakeTx(tx: WalrusWithdrawStakeProgrammableTransaction): boolean {
-    return tx.transactions
-      .filter((transaction) => 'kind' in transaction && transaction.kind === 'MoveCall')
-      .some(({ target }) => target.endsWith('::staking::request_withdraw_stake'));
-  }
-
   getWalrusWithdrawStakeRequests(tx: WalrusWithdrawStakeProgrammableTransaction): RequestWalrusWithdrawStake {
     let amount: number | undefined = undefined;
     let stakedWal: SuiObjectRef;

modules/sdk-coin-sui/src/lib/walrusWithdrawStakeTransaction.ts

@@ -195,7 +195,7 @@ export class WalrusWithdrawStakeTransaction extends Transaction<WalrusWithdrawSt
   }
 
   loadInputsAndOutputs(): void {
-    if (!this._suiTransaction || utils.isWalrusRequestWithdrawStakeTx(this._suiTransaction.tx)) {
+    if (!this._suiTransaction) {
       return;
     }
 

modules/sdk-coin-sui/test/unit/transactionBuilder/walrusWithdrawBuilder.ts

@@ -32,8 +32,18 @@ describe('Walrus Withdraw Builder', () => {
 
       assert(tx instanceof SuiTransaction);
       tx.type.should.equal(TransactionType.StakingDeactivate);
-      tx.inputs.length.should.equal(0);
-      tx.outputs.length.should.equal(0);
+      tx.inputs.length.should.equal(1);
+      tx.inputs[0].should.deepEqual({
+        address: '0xee6dfc3da32e21541a2aeadfcd250f8a0a23bb7abda9c8988407fc32068c3746',
+        value: testData.STAKING_AMOUNT.toString(),
+        coin: 'tsui:wal',
+      });
+      tx.outputs.length.should.equal(1);
+      tx.outputs[0].should.deepEqual({
+        address: testData.sender.address,
+        value: testData.STAKING_AMOUNT.toString(),
+        coin: 'tsui:wal',
+      });
 
       const rawTx = tx.toBroadcastFormat();
       await assertRebuild(rawTx);
@@ -64,8 +74,18 @@ describe('Walrus Withdraw Builder', () => {
 
       assert(tx instanceof SuiTransaction);
       tx.type.should.equal(TransactionType.StakingDeactivate);
-      tx.inputs.length.should.equal(0);
-      tx.outputs.length.should.equal(0);
+      tx.inputs.length.should.equal(1);
+      tx.inputs[0].should.deepEqual({
+        address: '0xee6dfc3da32e21541a2aeadfcd250f8a0a23bb7abda9c8988407fc32068c3746',
+        value: AMOUNT_UNKNOWN_TEXT,
+        coin: 'tsui:wal',
+      });
+      tx.outputs.length.should.equal(1);
+      tx.outputs[0].should.deepEqual({
+        address: testData.sender.address,
+        value: AMOUNT_UNKNOWN_TEXT,
+        coin: 'tsui:wal',
+      });
 
       const rawTx = tx.toBroadcastFormat();
       await assertRebuild(rawTx);