fix(statics): give precedence to statics coin map over ams map

TICKET: WIN-4944

Author: veetragjain

modules/statics/src/coins.ts

@@ -3190,28 +3190,24 @@ export function createTokenMapUsingConfigDetails(tokenConfigMap: Record<string,
     'terc1155:polygontoken',
   ]);
 
+  // Add all the coins from statics coin map first
+  coins.forEach((coin, coinName) => {
+    BaseCoins.set(coinName, coin);
+  });
+
+  // add the tokens not present in the static coin map
   for (const tokenConfigs of Object.values(tokenConfigMap)) {
     const tokenConfig = tokenConfigs[0];
     const family = tokenConfig.family;
+    const name = tokenConfig.name;
 
-    if (tokenConfig.isToken && !nftAndOtherTokens.has(tokenConfig.name)) {
+    if (!coins.has(name) && tokenConfig.isToken && !nftAndOtherTokens.has(tokenConfig.name)) {
       const token = createToken(family, tokenConfig, initializerMap);
       if (token) {
         BaseCoins.set(token.name, token);
-      } else if (coins.has(tokenConfig.name)) {
-        BaseCoins.set(tokenConfig.name, coins.get(tokenConfig.name));
       }
-    } else if (coins.has(tokenConfig.name)) {
-      BaseCoins.set(tokenConfig.name, coins.get(tokenConfig.name));
     }
   }
 
-  // Add keys and values from `coins` that are not already in `BaseCoins`
-  coins.forEach((coin, coinName) => {
-    if (!BaseCoins.has(coinName)) {
-      BaseCoins.set(coinName, coin);
-    }
-  });
-
   return CoinMap.fromCoins(Array.from(BaseCoins.values()));
 }

modules/statics/test/unit/coins.ts

@@ -23,7 +23,7 @@ import {
 } from '../../src';
 import { utxo } from '../../src/utxo';
 import { expectedColdFeatures } from './fixtures/expectedColdFeatures';
-import { amsTokenConfig, amsTokenConfigWithCustomToken } from './resources/amsTokenConfig';
+import { amsTokenConfig, amsTokenConfigWithCustomToken, incorrectAmsTokenConfig } from './resources/amsTokenConfig';
 
 interface DuplicateCoinObject {
   name: string;
@@ -922,6 +922,15 @@ describe('create token map using config details', () => {
       JSON.stringify(tokenNetwork).should.eql(JSON.stringify(staticNetwork));
     });
   });
+  it('should give precedence to static coin map over ams coin map', () => {
+    const tokenMap = createTokenMapUsingConfigDetails(incorrectAmsTokenConfig);
+    const tokenName = 'thbar:usdc';
+    const token = tokenMap.get(tokenName);
+    token.decimalPlaces.should.eql(coins.get(tokenName).decimalPlaces);
+    token.baseUnit.should.eql(coins.get(tokenName).baseUnit);
+    token.decimalPlaces.should.not.eql(incorrectAmsTokenConfig[tokenName][0].decimalPlaces);
+    token.baseUnit.should.not.eql(incorrectAmsTokenConfig[tokenName][0].baseUnit);
+  });
   it('should create a coin map and get formatted tokens from it', () => {
     const coinMap = createTokenMapUsingConfigDetails(amsTokenConfigWithCustomToken);
     const formattedTokens = getFormattedTokens(coinMap);

modules/statics/test/unit/resources/amsTokenConfig.ts

@@ -654,3 +654,46 @@ export const amsTokenConfigWithCustomToken = {
     },
   ],
 };
+
+export const incorrectAmsTokenConfig = {
+  ...amsTokenConfig,
+  'thbar:usdc': [
+    {
+      id: '842c2119-3071-409d-b86f-49f0b46b676e',
+      fullName: 'Testnet Hedera USD Coin',
+      name: 'thbar:usdc',
+      prefix: '',
+      suffix: 'THBAR:USDC',
+      baseUnit: 'fakebar',
+      kind: 'crypto',
+      family: 'hbar',
+      isToken: true,
+      features: [
+        'account-model',
+        'requires-big-number',
+        'valueless-transfer',
+        'transaction-data',
+        'custody',
+        'custody-bitgo-trust',
+        'custody-bitgo-mena-fze',
+        'custody-bitgo-custody-mena-fze',
+        'custody-bitgo-singapore',
+        'custody-bitgo-korea',
+        'custody-bitgo-europe-aps',
+        'custody-bitgo-frankfurt',
+      ],
+      decimalPlaces: 60,
+      asset: 'usdc',
+      network: {
+        type: 'testnet',
+        name: 'HederaTestnet',
+        family: 'hbar',
+        explorerUrl: 'https://testnet.dragonglass.me/hedera/search?q=',
+      },
+      primaryKeyCurve: 'ed25519',
+      nodeAccountId: '0.0.3',
+      tokenId: '0.0.13078',
+      contractAddress: '0.0.13078',
+    },
+  ],
+};