Merge pull request #5094 from BitGo/WIN-3772

fix: check if recipients is defined in verifyTransaction

Author: hitansh-madan

modules/sdk-coin-celo/src/celo.ts

@@ -31,7 +31,7 @@ export class Celo extends AbstractEthLikeCoin {
 
   async verifyTransaction(params: VerifyTransactionOptions): Promise<boolean> {
     const { txParams } = params;
-    if (txParams?.recipients?.length !== 1) {
+    if (Array.isArray(txParams.recipients) && txParams.recipients.length > 1) {
       throw new Error(`txParams should only have 1 recipient but ${txParams?.recipients?.length} found`);
     }
     return true;

modules/sdk-coin-dot/src/dot.ts

@@ -640,7 +640,7 @@ export class Dot extends BaseCoin {
 
   async verifyTransaction(params: VerifyTransactionOptions): Promise<boolean> {
     const { txParams } = params;
-    if (txParams?.recipients?.length !== 1) {
+    if (Array.isArray(txParams.recipients) && txParams.recipients.length > 1) {
       throw new Error(`txParams should only have 1 recipient but ${txParams?.recipients?.length} found`);
     }
     return true;

modules/sdk-coin-stx/src/stx.ts

@@ -47,7 +47,7 @@ export class Stx extends BaseCoin {
 
   async verifyTransaction(params: VerifyTransactionOptions): Promise<boolean> {
     const { txParams } = params;
-    if (txParams?.recipients?.length !== 1) {
+    if (Array.isArray(txParams.recipients) && txParams.recipients.length > 1) {
       throw new Error(`txParams should only have 1 recipient but ${txParams?.recipients?.length} found`);
     }
     return true;

modules/sdk-coin-xtz/src/xtz.ts

@@ -105,7 +105,7 @@ export class Xtz extends BaseCoin {
 
   async verifyTransaction(params: VerifyTransactionOptions): Promise<boolean> {
     const { txParams } = params;
-    if (txParams?.recipients?.length !== 1) {
+    if (Array.isArray(txParams.recipients) && txParams.recipients.length > 1) {
       throw new Error(`txParams should only have 1 recipient but ${txParams?.recipients?.length} found`);
     }
     return true;