fix(express): consolidateUnspents v1 type codec

Ticket: WP-6717

Author: lokesh-bitgo

modules/express/src/typedRoutes/api/v1/consolidateUnspents.ts

@@ -23,9 +23,9 @@ export const ConsolidateUnspentsRequestBody = {
   /** Target number of unspents to maintain (defaults to 1) */
   target: optional(t.number),
   /** Minimum size of unspents to consolidate */
-  minSize: optional(t.union([t.number, t.string])),
+  minSize: optional(t.number),
   /** Maximum size of unspents to consolidate */
-  maxSize: optional(t.union([t.number, t.string])),
+  maxSize: optional(t.number),
   /** Maximum number of inputs per consolidation transaction (defaults to 200, must be ≥ 2) */
   maxInputCountPerConsolidation: optional(t.number),
   /** Maximum number of consolidation iterations (defaults to -1) */
@@ -34,35 +34,62 @@ export const ConsolidateUnspentsRequestBody = {
   minConfirms: optional(t.number),
   /** Custom fee rate in satoshis per kilobyte */
   feeRate: optional(t.number),
+  /** One-time password for 2FA authentication */
+  otp: optional(t.string),
+  /** Optional message to attach to the transaction */
+  message: optional(t.string),
+  /** Whether to use instant transaction (BitGo Instant) */
+  instant: optional(t.boolean),
+  /** Sequence ID for transaction ordering */
+  sequenceId: optional(t.string),
+  /** Target number of blocks for fee estimation */
+  numBlocks: optional(t.number),
+  /** Whether minConfirms also applies to change outputs */
+  enforceMinConfirmsForChange: optional(t.boolean),
+  /** Target number of unspents for the wallet */
+  targetWalletUnspents: optional(t.number),
+  /** Minimum value of unspents to include (in satoshis) - accepts number or string */
+  minValue: optional(t.union([t.number, t.string])),
+  /** Maximum value of unspents to include (in satoshis) - accepts number or string */
+  maxValue: optional(t.union([t.number, t.string])),
+  /** Comment to attach to the transaction */
+  comment: optional(t.string),
 };
 
 /**
  * Response for consolidating unspents in a wallet
+ *
+ * Returns an array of transaction objects when consolidation occurs,
+ * or an empty object {} when no consolidation is needed (target already reached).
+ * The empty object is how Express serializes an undefined return from the V1 SDK.
  */
-export const ConsolidateUnspentsResponse = t.array(
-  t.type({
-    /** The status of the transaction ('accepted', 'pendingApproval', or 'otp') */
-    status: t.string,
-    /** The transaction hex */
-    tx: t.string,
-    /** The transaction hash/ID */
-    hash: t.string,
-    /** Whether the transaction is instant */
-    instant: t.boolean,
-    /** The instant ID (if applicable) */
-    instantId: optional(t.string),
-    /** The fee amount in satoshis */
-    fee: t.number,
-    /** The fee rate in satoshis per kilobyte */
-    feeRate: t.number,
-    /** Travel rule information */
-    travelInfos: t.unknown,
-    /** BitGo fee information (if applicable) */
-    bitgoFee: optional(t.unknown),
-    /** Travel rule result (if applicable) */
-    travelResult: optional(t.unknown),
-  })
-);
+export const ConsolidateUnspentsResponse = t.union([
+  t.array(
+    t.type({
+      /** The status of the transaction ('accepted', 'pendingApproval', or 'otp') */
+      status: t.union([t.literal('accepted'), t.literal('pendingApproval'), t.literal('otp')]),
+      /** The transaction hex */
+      tx: t.string,
+      /** The transaction hash/ID */
+      hash: t.string,
+      /** Whether the transaction is instant */
+      instant: t.boolean,
+      /** The instant ID (if applicable) */
+      instantId: optional(t.string),
+      /** The fee amount in satoshis */
+      fee: t.number,
+      /** The fee rate in satoshis per kilobyte */
+      feeRate: t.number,
+      /** Travel rule information */
+      travelInfos: t.unknown,
+      /** BitGo fee information (if applicable) */
+      bitgoFee: optional(t.unknown),
+      /** Travel rule result (if applicable) */
+      travelResult: optional(t.unknown),
+    })
+  ),
+  t.type({}), // Empty object when SDK returns undefined
+]);
 
 /**
  * Consolidate unspents in a wallet