fix(utxo-lib): respect skipNonWitnessUtxo flag in PSBT

davidkaplanbitgo · llm-git · davidkaplanbitgo · commit dc4871f99262 · 2025-10-10T13:55:32.000-04:00
Fix condition to properly respect the skipNonWitnessUtxo flag when deciding whether to add nonWitnessUtxo to PSBTs. Issue: BTC-000 Co-authored-by: llm-git <llm-git@ttll.de>
diff --git a/modules/utxo-lib/src/bitgo/wallet/Unspent.ts b/modules/utxo-lib/src/bitgo/wallet/Unspent.ts
@@ -256,7 +256,7 @@ export function updateWalletUnspentForPsbt(
   if ((isZcashOrSegwit || customParams?.skipNonWitnessUtxo) && !input.witnessUtxo) {
     const { script, value } = toPrevOutput(u, psbt.network);
     psbt.updateInput(inputIndex, { witnessUtxo: { script, value } });
-  } else if (!isZcashOrSegwit) {
+  } else if (!isZcashOrSegwit && !customParams?.skipNonWitnessUtxo) {
     if (!isUnspentWithPrevTx(u)) {
       throw new Error('Error, require previous tx to add to PSBT');
     }

Original file line number	Diff line number	Diff line change
`@@ -256,7 +256,7 @@ export function updateWalletUnspentForPsbt(`
`256`	`256`	`if ((isZcashOrSegwit \|\| customParams?.skipNonWitnessUtxo) && !input.witnessUtxo) {`
`257`	`257`	`const { script, value } = toPrevOutput(u, psbt.network);`
`258`	`258`	`psbt.updateInput(inputIndex, { witnessUtxo: { script, value } });`
`259`		`- } else if (!isZcashOrSegwit) {`
	`259`	`+ } else if (!isZcashOrSegwit && !customParams?.skipNonWitnessUtxo) {`
`260`	`260`	`if (!isUnspentWithPrevTx(u)) {`
`261`	`261`	`throw new Error('Error, require previous tx to add to PSBT');`
`262`	`262`	`}`