Skip to content

Commit dd62c38

Browse files
fix(root): resolve nx cache configuration and github actions issues
ISSUE: - GitHub Actions were failing due to NX cache configuration problems - Copilot feedback identified redundant exclusions in nx.json production named input - GitHub Actions cache keys had problematic negation pattern (!modules/*/package-lock.json) SOLUTION: - Fix NX cache configuration: remove redundant exclusions in nx.json production named input - Fix GitHub Actions cache keys: remove problematic negation pattern from all cache keys - Remove explicit NX dependency (Lerna 8 provides NX integration automatically) TECHNICAL DETAILS: - The production named input had redundant exclusions already covered by default input - GitHub Actions hashFiles() function doesn't handle negation patterns reliably - Lerna 8 includes NX integration, making explicit nx dependency unnecessary VERIFICATION: - NX cache functionality works correctly - GitHub Actions cache keys function properly - Cache restoration steps complete successfully in CI TICKET: WP-6096
1 parent 2b37aa4 commit dd62c38

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

.github/workflows/ci.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ jobs:
7474
path: |
7575
.nx/cache
7676
modules/*/dist
77-
key: ${{ runner.os }}-nx-${{ matrix.node-version }}-${{ hashFiles('yarn.lock') }}-${{ hashFiles('modules/*/src/**/*.ts', 'modules/*/src/**/*.js', 'modules/*/*.json', '!modules/*/package-lock.json') }}
77+
key: ${{ runner.os }}-nx-${{ matrix.node-version }}-${{ hashFiles('yarn.lock') }}-${{ hashFiles('modules/*/src/**/*.ts', 'modules/*/src/**/*.js', 'modules/*/*.json') }}
7878
restore-keys: |
7979
${{ runner.os }}-nx-${{ matrix.node-version }}-${{ hashFiles('yarn.lock') }}-
8080
${{ runner.os }}-nx-${{ matrix.node-version }}-
@@ -184,7 +184,7 @@ jobs:
184184
path: |
185185
.nx/cache
186186
modules/*/dist
187-
key: ${{ runner.os }}-nx-license-${{ hashFiles('yarn.lock') }}-${{ hashFiles('modules/*/src/**/*.ts', 'modules/*/src/**/*.js', 'modules/*/*.json', '!modules/*/package-lock.json') }}
187+
key: ${{ runner.os }}-nx-license-${{ hashFiles('yarn.lock') }}-${{ hashFiles('modules/*/src/**/*.ts', 'modules/*/src/**/*.js', 'modules/*/*.json') }}
188188
restore-keys: |
189189
${{ runner.os }}-nx-license-${{ hashFiles('yarn.lock') }}-
190190
${{ runner.os }}-nx-license-
@@ -291,7 +291,7 @@ jobs:
291291
path: |
292292
.nx/cache
293293
modules/*/dist
294-
key: ${{ runner.os }}-nx-browser-${{ hashFiles('yarn.lock') }}-${{ hashFiles('modules/*/src/**/*.ts', 'modules/*/src/**/*.js', 'modules/*/*.json', '!modules/*/package-lock.json') }}
294+
key: ${{ runner.os }}-nx-browser-${{ hashFiles('yarn.lock') }}-${{ hashFiles('modules/*/src/**/*.ts', 'modules/*/src/**/*.js', 'modules/*/*.json') }}
295295
restore-keys: |
296296
${{ runner.os }}-nx-browser-${{ hashFiles('yarn.lock') }}-
297297
${{ runner.os }}-nx-browser-

nx.json

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -78,9 +78,7 @@
7878
"!{projectRoot}/node_modules/**"
7979
],
8080
"production": [
81-
"default",
82-
"!{projectRoot}/**/*.spec.ts",
83-
"!{projectRoot}/**/test/**"
81+
"default"
8482
]
8583
}
8684
}

0 commit comments

Comments
 (0)