Merge pull request #5201 from BitGo/COIN-1957_send_many_error_message

refactor(wp): send many uniform error messages changes

Author: krupanand-bitgo

CODEOWNERS

@@ -52,6 +52,7 @@
 /modules/sdk-coin-atom/ @BitGo/ethalt-team
 /modules/sdk-coin-avaxc/ @BitGo/ethalt-team
 /modules/sdk-coin-avaxp/ @BitGo/ethalt-team
+/modules/sdk-coin-bera/ @BitGo/ethalt-team
 /modules/sdk-coin-bsc/ @BitGo/ethalt-team
 /modules/sdk-coin-coredao/ @BitGo/ethalt-team
 /modules/sdk-coin-cspr/ @BitGo/ethalt-team

modules/abstract-eth/src/abstractEthLikeNewCoins.ts

@@ -2285,8 +2285,10 @@ export abstract class AbstractEthLikeNewCoins extends AbstractEthLikeCoin {
     if (txParams.hop && txParams.recipients.length > 1) {
       throw new Error(`tx cannot be both a batch and hop transaction`);
     }
-    if (txPrebuild.recipients.length !== 1) {
-      throw new Error(`txPrebuild should only have 1 recipient but ${txPrebuild.recipients.length} found`);
+    if (txPrebuild.recipients.length > 1) {
+      throw new Error(
+        `${this.getChain()} doesn't support sending to more than 1 destination address within a single transaction. Try again, using only a single recipient.`
+      );
     }
     if (txParams.hop && txPrebuild.hopTransaction) {
       // Check recipient amount for hop transaction

modules/abstract-eth/test/unit/coin.ts

@@ -348,7 +348,9 @@ export function runTransactionVerificationTests(coinName: string, bitgo: TestBit
 
       await basecoin
         .verifyTransaction({ txParams, txPrebuild, wallet, verification })
-        .should.be.rejectedWith('txPrebuild should only have 1 recipient but 2 found');
+        .should.be.rejectedWith(
+          `${coinTest} doesn't support sending to more than 1 destination address within a single transaction. Try again, using only a single recipient.`
+        );
     });
 
     it('should reject a hop txPrebuild that does not send to its hop address', async () => {

modules/sdk-coin-arbeth/test/unit/arbeth.ts

@@ -402,7 +402,9 @@ describe('Arbitrum', function () {
 
       await basecoin
         .verifyTransaction({ txParams, txPrebuild, wallet, verification })
-        .should.be.rejectedWith('txPrebuild should only have 1 recipient but 2 found');
+        .should.be.rejectedWith(
+          `tarbeth doesn't support sending to more than 1 destination address within a single transaction. Try again, using only a single recipient.`
+        );
     });
 
     it('should reject a hop txPrebuild that does not send to its hop address', async function () {

modules/sdk-coin-avaxc/src/avaxc.ts

@@ -170,8 +170,10 @@ export class AvaxC extends AbstractEthLikeNewCoins {
     if (txParams.hop && txParams.recipients.length > 1) {
       throw new Error(`tx cannot be both a batch and hop transaction`);
     }
-    if (txPrebuild.recipients.length !== 1) {
-      throw new Error(`txPrebuild should only have 1 recipient but ${txPrebuild.recipients.length} found`);
+    if (txPrebuild.recipients.length > 1) {
+      throw new Error(
+        `${this.getChain()} doesn't support sending to more than 1 destination address within a single transaction. Try again, using only a single recipient.`
+      );
     }
     if (txParams.hop && txPrebuild.hopTransaction) {
       // Check recipient amount for hop transaction

modules/sdk-coin-avaxc/test/unit/avaxc.ts

@@ -610,7 +610,9 @@ describe('Avalanche C-Chain', function () {
 
       await tavaxCoin
         .verifyTransaction({ txParams, txPrebuild, wallet, verification })
-        .should.be.rejectedWith('txPrebuild should only have 1 recipient but 2 found');
+        .should.be.rejectedWith(
+          `tavaxc doesn't support sending to more than 1 destination address within a single transaction. Try again, using only a single recipient.`
+        );
     });
 
     it('should reject a hop txPrebuild that does not send to its hop address', async function () {

modules/sdk-coin-bera/test/unit/bera.ts

@@ -302,7 +302,9 @@ describe('Bera', function () {
 
       await basecoin
         .verifyTransaction({ txParams, txPrebuild, wallet, verification })
-        .should.be.rejectedWith('txPrebuild should only have 1 recipient but 2 found');
+        .should.be.rejectedWith(
+          `tbera doesn't support sending to more than 1 destination address within a single transaction. Try again, using only a single recipient.`
+        );
     });
 
     it('should reject a normal txPrebuild from the bitgo server with the wrong amount', async function () {

modules/sdk-coin-celo/src/celo.ts

@@ -32,7 +32,9 @@ export class Celo extends AbstractEthLikeCoin {
   async verifyTransaction(params: VerifyTransactionOptions): Promise<boolean> {
     const { txParams } = params;
     if (Array.isArray(txParams.recipients) && txParams.recipients.length > 1) {
-      throw new Error(`txParams should only have 1 recipient but ${txParams?.recipients?.length} found`);
+      throw new Error(
+        `${this.getChain()} doesn't support sending to more than 1 destination address within a single transaction. Try again, using only a single recipient.`
+      );
     }
     return true;
   }

modules/sdk-coin-celo/test/unit/celo.ts

@@ -40,7 +40,9 @@ describe('Celo Gold', function () {
 
       await basecoin
         .verifyTransaction({ txParams })
-        .should.be.rejectedWith('txParams should only have 1 recipient but 2 found');
+        .should.be.rejectedWith(
+          `celo doesn't support sending to more than 1 destination address within a single transaction. Try again, using only a single recipient.`
+        );
     });
   });
 });

modules/sdk-coin-dot/src/dot.ts

@@ -641,7 +641,9 @@ export class Dot extends BaseCoin {
   async verifyTransaction(params: VerifyTransactionOptions): Promise<boolean> {
     const { txParams } = params;
     if (Array.isArray(txParams.recipients) && txParams.recipients.length > 1) {
-      throw new Error(`txParams should only have 1 recipient but ${txParams?.recipients?.length} found`);
+      throw new Error(
+        `${this.getChain()} doesn't support sending to more than 1 destination address within a single transaction. Try again, using only a single recipient.`
+      );
     }
     return true;
   }