Merge pull request #7260 from BitGo/WIN-7548-use-ada-sdk-for-token-fee

feat(sdk-coin-ada) - remove fallback logic for token fee calculation

Author: Ranjna-G

modules/sdk-coin-ada/src/lib/transactionBuilder.ts

@@ -26,8 +26,6 @@ const FEE_COEFFICIENTS = {
   B_COEFFICIENT: '155381',
   /** Additional safety margin for the fee */
   SAFETY_MARGIN: '440',
-  /* Min fee required for token transaction */
-  MIN_TOKEN_TRANSACTION_FEE: '1000000',
 };
 
 export abstract class TransactionBuilder extends BaseTransactionBuilder {
@@ -379,15 +377,7 @@ export abstract class TransactionBuilder extends BaseTransactionBuilder {
     );
 
     // Calculate the fee based off our dummy transaction
-    let fee = CardanoWasm.min_fee(txDraft, linearFee).checked_add(BigNum.from_str(FEE_COEFFICIENTS.SAFETY_MARGIN));
-    /**
-     * In some cases especially with token transactions the calculated fee can be very low than the fee expected from the node
-     * So, ensure a minimum fee is always set
-     */
-    const minTokenFee = BigNum.from_str(FEE_COEFFICIENTS.MIN_TOKEN_TRANSACTION_FEE);
-    if (fee.less_than(minTokenFee)) {
-      fee = minTokenFee;
-    }
+    const fee = CardanoWasm.min_fee(txDraft, linearFee).checked_add(BigNum.from_str(FEE_COEFFICIENTS.SAFETY_MARGIN));
     this._fee = fee;
   }
 

modules/sdk-coin-ada/test/unit/tokenWithdrawal.ts

@@ -39,7 +39,7 @@ describe('ADA Token Operations', async () => {
       totalInput -
       1500000 /* min ada for change token utxo */ -
       1500000 /* min ada for recipient token utxo*/ -
-      1000000
+      173597
     ) /* fee */
       .toString();
     const expectedChangeToken = '80';
@@ -127,7 +127,7 @@ describe('ADA Token Operations', async () => {
       1500000 /* min ada for change token utxo */ -
       1500000 /* min ada for recipient token utxo*/ -
       1500000 /* min ada for unsupported token change utxo */ -
-      1000000
+      179889
     ) /* fee */
       .toString();
     const expectedChangeToken = '80';