feat(sdk-coin-sol): implement isWalletAddress for address verfn

TICKET: WP-6459

Author: pranavjain97

modules/sdk-coin-sol/src/sol.ts

@@ -23,7 +23,6 @@ import {
   ITokenEnablement,
   KeyPair,
   Memo,
-  MethodNotImplementedError,
   MPCAlgorithm,
   MPCConsolidationRecoveryOptions,
   MPCRecoveryOptions,
@@ -50,8 +49,9 @@ import {
   TransactionExplanation,
   TransactionParams,
   TransactionRecipient,
-  VerifyAddressOptions,
   VerifyTransactionOptions,
+  TssVerifyAddressOptions,
+  verifyEddsaTssWalletAddress,
 } from '@bitgo/sdk-core';
 import { auditEddsaPrivateKey, getDerivationPath } from '@bitgo/sdk-lib-mpc';
 import { BaseNetwork, CoinFamily, coins, SolCoin, BaseCoin as StaticsBaseCoin } from '@bitgo/statics';
@@ -560,8 +560,22 @@ export class Sol extends BaseCoin {
     return true;
   }
 
-  async isWalletAddress(params: VerifyAddressOptions): Promise<boolean> {
-    throw new MethodNotImplementedError();
+  async isWalletAddress(params: TssVerifyAddressOptions): Promise<boolean> {
+    return verifyEddsaTssWalletAddress(
+      params,
+      (address) => this.isValidAddress(address),
+      (publicKey) => this.getAddressFromPublicKey(publicKey)
+    );
+  }
+
+  /**
+   * Converts a Solana public key to an address
+   * @param publicKey Hex-encoded public key (64 hex characters = 32 bytes)
+   * @returns Base58-encoded Solana address
+   */
+  getAddressFromPublicKey(publicKey: string): string {
+    const publicKeyBuffer = Buffer.from(publicKey, 'hex');
+    return base58.encode(publicKeyBuffer);
   }
 
   /**

modules/sdk-coin-sol/test/unit/sol.ts

@@ -3353,4 +3353,84 @@ describe('SOL:', function () {
       );
     });
   });
+
+  describe('isWalletAddress', () => {
+    it('should verify valid wallet address with correct keychain and index', async function () {
+      const address = '7YAesfwPk41VChUgr65bm8FEep7ymWqLSW5rpYB5zZPY';
+      const commonKeychain =
+        '8ea32ecacfc83effbd2e2790ee44fa7c59b4d86c29a12f09fb613d8195f93f4e21875cad3b98adada40c040c54c3569467df41a020881a6184096378701862bd';
+      const index = '1';
+      const keychains = [{ commonKeychain }];
+
+      const result = await basecoin.isWalletAddress({ keychains, address, index });
+      result.should.equal(true);
+    });
+
+    it('should return false for address with incorrect keychain', async function () {
+      const address = '7YAesfwPk41VChUgr65bm8FEep7ymWqLSW5rpYB5zZPY';
+      const wrongKeychain =
+        '0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000';
+      const index = '1';
+      const keychains = [{ commonKeychain: wrongKeychain }];
+
+      const result = await basecoin.isWalletAddress({ keychains, address, index });
+      result.should.equal(false);
+    });
+
+    it('should return false for address with incorrect index', async function () {
+      const address = '7YAesfwPk41VChUgr65bm8FEep7ymWqLSW5rpYB5zZPY';
+      const commonKeychain =
+        '8ea32ecacfc83effbd2e2790ee44fa7c59b4d86c29a12f09fb613d8195f93f4e21875cad3b98adada40c040c54c3569467df41a020881a6184096378701862bd';
+      const wrongIndex = '999';
+      const keychains = [{ commonKeychain }];
+
+      const result = await basecoin.isWalletAddress({ keychains, address, index: wrongIndex });
+      result.should.equal(false);
+    });
+
+    it('should throw error for invalid address', async function () {
+      const invalidAddress = 'invalidaddress';
+      const commonKeychain =
+        '8ea32ecacfc83effbd2e2790ee44fa7c59b4d86c29a12f09fb613d8195f93f4e21875cad3b98adada40c040c54c3569467df41a020881a6184096378701862bd';
+      const index = '1';
+      const keychains = [{ commonKeychain }];
+
+      await assert.rejects(async () => await basecoin.isWalletAddress({ keychains, address: invalidAddress, index }), {
+        message: `invalid address: ${invalidAddress}`,
+      });
+    });
+
+    it('should throw error when keychains are missing', async function () {
+      const address = '7YAesfwPk41VChUgr65bm8FEep7ymWqLSW5rpYB5zZPY';
+      const index = '1';
+
+      await assert.rejects(async () => await basecoin.isWalletAddress({ address, index } as any), {
+        message: 'missing required param keychains',
+      });
+    });
+
+    it('should throw error when keychains have different commonKeychains', async function () {
+      const address = '7YAesfwPk41VChUgr65bm8FEep7ymWqLSW5rpYB5zZPY';
+      const commonKeychain1 =
+        '8ea32ecacfc83effbd2e2790ee44fa7c59b4d86c29a12f09fb613d8195f93f4e21875cad3b98adada40c040c54c3569467df41a020881a6184096378701862bd';
+      const commonKeychain2 =
+        '0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000';
+      const index = '1';
+      const keychains = [{ commonKeychain: commonKeychain1 }, { commonKeychain: commonKeychain2 }];
+
+      await assert.rejects(async () => await basecoin.isWalletAddress({ keychains, address, index }), {
+        message: 'all keychains must have the same commonKeychain for MPC coins',
+      });
+    });
+  });
+
+  describe('getAddressFromPublicKey', () => {
+    it('should convert public key to base58 address', function () {
+      const publicKey = '61220a9394802b1d1df37b35f7a3197970f48081092cee011fc98f7b71b2bd43';
+      const expectedAddress = '7YAesfwPk41VChUgr65bm8FEep7ymWqLSW5rpYB5zZPY';
+
+      const address = basecoin.getAddressFromPublicKey(publicKey);
+      address.should.equal(expectedAddress);
+    });
+  });
 });