Merge pull request #6467 from BitGo/coin-4755-msg-signing-support-ada-sol

fix(account-lib): create Buffer from hex string

Author: bhavidhingra

modules/sdk-coin-sol/test/unit/messages/messageBuilderFactory.ts

@@ -122,7 +122,8 @@ describe('Solana MessageBuilderFactory', function () {
   describe('fromBroadcastString', function () {
     it('should parse broadcastable string and return correct builder type', async function () {
       const broadcastString = JSON.stringify(testBroadcastMessage);
-      const builder = factory.fromBroadcastString(broadcastString);
+      const broadcastHex = Buffer.from(broadcastString).toString('hex');
+      const builder = factory.fromBroadcastString(broadcastHex);
 
       assertSimpleMessageBuilder(builder);
       const message = await assertBuilderMessageProperties(builder, 'test message');
@@ -132,7 +133,7 @@ describe('Solana MessageBuilderFactory', function () {
 
     it('should throw for invalid JSON string', function () {
       try {
-        factory.fromBroadcastString('{invalid json');
+        factory.fromBroadcastString('abcdefg'); // Invalid hex string
         fail('Expected error not thrown');
       } catch (error) {
         error.should.be.instanceof(SyntaxError);

modules/sdk-core/src/account-lib/baseCoin/messages/baseMessageBuilderFactory.ts

@@ -48,7 +48,7 @@ export abstract class BaseMessageBuilderFactory implements IMessageBuilderFactor
    * @returns A message builder instance for the parsed broadcastable message type
    */
   fromBroadcastString(broadcastHex: string): IMessageBuilder {
-    const broadcastStr = Buffer.from(broadcastHex).toString();
+    const broadcastStr = Buffer.from(broadcastHex, 'hex').toString();
     const broadcastMessage = JSON.parse(broadcastStr) as BroadcastableMessage;
     return this.fromBroadcastFormat(broadcastMessage);
   }

modules/sdk-core/test/unit/account-lib/baseCoin/messages/baseMessageBuilderFactory.ts

@@ -69,7 +69,8 @@ describe('Base Message Builder Factory', () => {
       };
 
       const broadcastString = JSON.stringify(broadcastMessage);
-      const builder = factory.fromBroadcastString(broadcastString);
+      const broadcastHex = Buffer.from(broadcastString).toString('hex');
+      const builder = factory.fromBroadcastString(broadcastHex);
 
       should.exist(builder);
       // Since the TestMessageBuilder always returns the same type that was passed to constructor
@@ -90,7 +91,8 @@ describe('Base Message Builder Factory', () => {
       };
 
       const broadcastString = JSON.stringify(broadcastMessage);
-      const builder = factory.fromBroadcastString(broadcastString);
+      const broadcastHex = Buffer.from(broadcastString).toString('hex');
+      const builder = factory.fromBroadcastString(broadcastHex);
 
       should.exist(builder);
       should.equal(builder.getType(), MessageStandardType.UNKNOWN);
@@ -105,7 +107,8 @@ describe('Base Message Builder Factory', () => {
       };
 
       const broadcastString = JSON.stringify(broadcastMessage);
-      const builder = factory.fromBroadcastString(broadcastString);
+      const broadcastHex = Buffer.from(broadcastString).toString('hex');
+      const builder = factory.fromBroadcastString(broadcastHex);
 
       should.exist(builder);
       should.equal(builder.getType(), MessageStandardType.EIP191);