feat: use statics to get denom of tokens

TICKET: COIN-5004

Author: MohammedRyaan786

modules/abstract-cosmos/src/lib/utils.ts

@@ -19,6 +19,7 @@ import {
   Registry,
 } from '@cosmjs/proto-signing';
 import { Coin, defaultRegistryTypes } from '@cosmjs/stargate';
+import { coins } from '@bitgo/statics';
 import BigNumber from 'bignumber.js';
 import { SignDoc, TxRaw } from 'cosmjs-types/cosmos/tx/v1beta1/tx';
 import { Any } from 'cosmjs-types/google/protobuf/any';
@@ -933,6 +934,19 @@ export class CosmosUtils<CustomMessage = never> implements BaseUtils {
   getHashFunction(): Hash {
     return createHash('sha256');
   }
+
+  getTokenDenomsUsingCoinFamily(coinFamily: string): string[] {
+    // using set to remove duplicates as denom can be same on testnet and mainnet for a few tokens
+    return [
+      ...new Set(
+        coins
+          .filter(
+            (coin) => coin.family.toLowerCase() === coinFamily.toLowerCase() && coin.isToken && coin.denom !== undefined
+          )
+          .map((coin) => coin.denom as string)
+      ),
+    ];
+  }
 }
 
 const utils = new CosmosUtils();

modules/abstract-cosmos/test/unit/cosmosToken.ts

@@ -3,6 +3,7 @@ import 'should';
 import { TestBitGo, TestBitGoAPI } from '@bitgo/sdk-test';
 import { BitGoAPI } from '@bitgo/sdk-api';
 import { CosmosToken } from '../../src';
+import CosmosUtils from '../../src/lib/utils';
 
 describe('Cosmos Tokens', function () {
   let bitgo: TestBitGoAPI;
@@ -46,4 +47,8 @@ describe('Cosmos Tokens', function () {
     mainnetCosmosToken.denom.should.equal('uylds.fcc');
     mainnetCosmosToken.decimalPlaces.should.equal(6);
   });
+
+  it('should return denomination for YLDS token on hash using hash as coinFamily', function () {
+    CosmosUtils.getTokenDenomsUsingCoinFamily('hash').should.deepEqual(['uylds.fcc']);
+  });
 });

modules/sdk-coin-asi/src/lib/constants.ts

@@ -1,4 +1,7 @@
-export const validDenoms = ['fet', 'tfet', 'afet', 'atestfet'];
+import { CosmosUtils } from '@bitgo/abstract-cosmos';
+
+const cosmosUtils = new CosmosUtils();
+export const validDenoms = ['fet', 'tfet', 'afet', 'atestfet', ...cosmosUtils.getTokenDenomsUsingCoinFamily('asi')];
 export const accountAddressRegex = /^(fetch)1(['qpzry9x8gf2tvdw0s3jn54khce6mua7l]{38})$/;
 export const validatorAddressRegex = /^(fetchvaloper)1(['qpzry9x8gf2tvdw0s3jn54khce6mua7l]{38})$/;
 export const contractAddressRegex = /^(fetch)1(['qpzry9x8gf2tvdw0s3jn54khce6mua7l]+)$/;

modules/sdk-coin-atom/src/lib/constants.ts

@@ -1,4 +1,7 @@
-export const validDenoms = ['natom', 'uatom', 'matom', 'atom'];
+import { CosmosUtils } from '@bitgo/abstract-cosmos';
+
+const cosmosUtils = new CosmosUtils();
+export const validDenoms = ['natom', 'uatom', 'matom', 'atom', ...cosmosUtils.getTokenDenomsUsingCoinFamily('atom')];
 export const accountAddressRegex = /^(cosmos)1(['qpzry9x8gf2tvdw0s3jn54khce6mua7l]{38})$/;
 export const validatorAddressRegex = /^(cosmosvaloper)1(['qpzry9x8gf2tvdw0s3jn54khce6mua7l]{38})$/;
 export const contractAddressRegex = /^(cosmos)1(['qpzry9x8gf2tvdw0s3jn54khce6mua7l]+)$/;

modules/sdk-coin-baby/src/lib/constants.ts

@@ -1,4 +1,7 @@
-export const validDenoms = ['baby', 'tbaby', 'ubbn'];
+import { CosmosUtils } from '@bitgo/abstract-cosmos';
+
+const cosmosUtils = new CosmosUtils();
+export const validDenoms = ['baby', 'tbaby', 'ubbn', ...cosmosUtils.getTokenDenomsUsingCoinFamily('baby')];
 export const accountAddressRegex = /^(bbn)1(['qpzry9x8gf2tvdw0s3jn54khce6mua7l]{38})$/;
 export const validatorAddressRegex = /^(bbnvaloper)1(['qpzry9x8gf2tvdw0s3jn54khce6mua7l]{38})$/;
 export const contractAddressRegex = /^(bbn)1(['qpzry9x8gf2tvdw0s3jn54khce6mua7l]+)$/;

modules/sdk-coin-bld/src/lib/constants.ts

@@ -1,4 +1,7 @@
-export const validDenoms = ['nbld', 'ubld', 'mbld', 'bld'];
+import { CosmosUtils } from '@bitgo/abstract-cosmos';
+
+const cosmosUtils = new CosmosUtils();
+export const validDenoms = ['nbld', 'ubld', 'mbld', 'bld', ...cosmosUtils.getTokenDenomsUsingCoinFamily('bld')];
 export const accountAddressRegex = /^(agoric)1(['qpzry9x8gf2tvdw0s3jn54khce6mua7l]{38})$/;
 export const validatorAddressRegex = /^(agoricvaloper)1(['qpzry9x8gf2tvdw0s3jn54khce6mua7l]{38})$/;
 export const contractAddressRegex = /^(agoric)1(['qpzry9x8gf2tvdw0s3jn54khce6mua7l]+)$/;

modules/sdk-coin-coreum/src/lib/constants.ts

@@ -1,9 +1,10 @@
-export const mainnetValidDenoms = ['ucore'];
+import { CosmosUtils } from '@bitgo/abstract-cosmos';
+
+const cosmosUtils = new CosmosUtils();
+export const validDenoms = ['ucore', 'utestcore', ...cosmosUtils.getTokenDenomsUsingCoinFamily('coreum')];
 export const mainnetAccountAddressRegex = /^(core)1(['qpzry9x8gf2tvdw0s3jn54khce6mua7l]{38})$/;
 export const mainnetValidatorAddressRegex = /^(corevaloper)1(['qpzry9x8gf2tvdw0s3jn54khce6mua7l]{38})$/;
 export const MAINNET_ADDRESS_PREFIX = 'core';
-
-export const testnetValidDenoms = ['utestcore'];
 export const testnetAccountAddressRegex = /^(testcore)1(['qpzry9x8gf2tvdw0s3jn54khce6mua7l]{38})$/;
 export const testnetValidatorAddressRegex = /^(testcorevaloper)1(['qpzry9x8gf2tvdw0s3jn54khce6mua7l]{38})$/;
 export const TESTNET_ADDRESS_PREFIX = 'testcore';

modules/sdk-coin-coreum/src/lib/utils.ts

@@ -35,12 +35,7 @@ export class CoreumUtils extends CosmosUtils {
     if (amountBig.isLessThanOrEqualTo(0)) {
       throw new InvalidTransactionError('transactionBuilder: validateAmount: Invalid amount: ' + amount.amount);
     }
-    if (
-      (this.networkType === NetworkType.TESTNET &&
-        !constants.testnetValidDenoms.find((denom) => denom === amount.denom)) ||
-      (this.networkType === NetworkType.MAINNET &&
-        !constants.mainnetValidDenoms.find((denom) => denom === amount.denom))
-    ) {
+    if (!constants.validDenoms.find((denom) => denom === amount.denom)) {
       throw new InvalidTransactionError('transactionBuilder: validateAmount: Invalid denom: ' + amount.denom);
     }
   }

modules/sdk-coin-cronos/src/lib/constants.ts

@@ -1,4 +1,13 @@
-export const validDenoms = ['cro', 'tcro', 'basecro', 'basetcro'];
+import { CosmosUtils } from '@bitgo/abstract-cosmos';
+
+const cosmosUtils = new CosmosUtils();
+export const validDenoms = [
+  'cro',
+  'tcro',
+  'basecro',
+  'basetcro',
+  ...cosmosUtils.getTokenDenomsUsingCoinFamily('cronos'),
+];
 
 export const mainnetAccountAddressRegex = /^(cro)1(['qpzry9x8gf2tvdw0s3jn54khce6mua7l]{38})$/;
 export const mainnetValidatorAddressRegex = /^(crocncl)1(['qpzry9x8gf2tvdw0s3jn54khce6mua7l]{38})$/;

modules/sdk-coin-hash/src/lib/constants.ts

@@ -1,4 +1,7 @@
-export const validDenoms = ['nhash', 'uhash', 'mhash', 'hash', 'uylds.fcc'];
+import { CosmosUtils } from '@bitgo/abstract-cosmos';
+
+const cosmosUtils = new CosmosUtils();
+export const validDenoms = ['nhash', 'uhash', 'mhash', 'hash', ...cosmosUtils.getTokenDenomsUsingCoinFamily('hash')];
 export const mainnetAccountAddressRegex = /^(pb)1(['qpzry9x8gf2tvdw0s3jn54khce6mua7l]{38})$/;
 export const mainnetValidatorAddressRegex = /^(pbvaloper)1(['qpzry9x8gf2tvdw0s3jn54khce6mua7l]{38})$/;
 export const mainnetContractAddressRegex = /^(pb)1(['qpzry9x8gf2tvdw0s3jn54khce6mua7l]+)$/;