Merge pull request #5831 from BitGo/WIN-4251

refactor(sdk-coin-icp): rename methods for clarity and consistency

Author: adarsh312

modules/sdk-coin-icp/src/lib/transactionBuilder.ts

@@ -19,11 +19,11 @@ export abstract class TransactionBuilder extends BaseTransactionBuilder {
     this._transaction = new Transaction(_coinConfig, utils);
   }
 
-  public getSignaturePayload(): Signatures[] {
+  public signaturePayload(): Signatures[] {
     return this._transaction.signaturePayload;
   }
 
-  public getUnsignedTransaction(): string {
+  public unsignedTransaction(): string {
     return this._transaction.payloadsData.unsigned_transaction;
   }
 

modules/sdk-coin-icp/test/unit/transactionBuilder/transactionBuilder.ts

@@ -51,10 +51,10 @@ describe('ICP Transaction Builder', async () => {
     should.equal(icpTransaction.operations[1].amount.value, '10');
     should.equal(icpTransaction.operations[2].amount.value, '-10000');
     should.equal(icpTransaction.public_keys[0].hex_bytes, testData.accounts.account1.publicKey);
-    txBuilder.getUnsignedTransaction().should.be.a.String();
+    txBuilder.unsignedTransaction().should.be.a.String();
     payloadsData.payloads.should.be.an.Array();
     payloadsData.payloads.length.should.equal(2);
-    should.equal(txBuilder.getUnsignedTransaction(), testData.payloadsData.unsigned_transaction);
+    should.equal(txBuilder.unsignedTransaction(), testData.payloadsData.unsigned_transaction);
     should.deepEqual(payloadsData.payloads, testData.payloadsData.payloads);
   });
 
@@ -90,7 +90,7 @@ describe('ICP Transaction Builder', async () => {
   it('should sign a txn and then give txn in broadcast format', async () => {
     const baseKey: BaseKey = { key: testData.accounts.account1.secretKey };
     txBuilder.sign(baseKey);
-    should.deepEqual(txBuilder.getSignaturePayload(), testData.signatures);
+    should.deepEqual(txBuilder.signaturePayload(), testData.signatures);
     txBuilder.combine();
     const signedTxn = txBuilder.transaction.signedTransaction;
     signedTxn.should.be.a.String();