refactor(abstract-utxo): rename WalletOutput to FixedScriptWalletOutput

Make room for DescriptorWalletOutput

Issue: BTC-1450

Author: OttoAllmendinger

modules/abstract-utxo/src/abstractUtxoCoin.ts

@@ -132,16 +132,18 @@ export interface BaseOutput {
   external?: boolean;
 }
 
-export interface WalletOutput extends BaseOutput {
+export interface FixedScriptWalletOutput extends BaseOutput {
   needsCustomChangeKeySignatureVerification?: boolean;
   chain: number;
   index: number;
 }
 
-export type Output = BaseOutput | WalletOutput;
+export type Output = BaseOutput | FixedScriptWalletOutput;
 
-export function isWalletOutput(output: Output): output is WalletOutput {
-  return (output as WalletOutput).chain !== undefined && (output as WalletOutput).index !== undefined;
+export function isWalletOutput(output: Output): output is FixedScriptWalletOutput {
+  return (
+    (output as FixedScriptWalletOutput).chain !== undefined && (output as FixedScriptWalletOutput).index !== undefined
+  );
 }
 
 export interface TransactionExplanation extends BaseTransactionExplanation<string, string> {
@@ -745,7 +747,7 @@ export abstract class AbstractUtxoCoin extends BaseCoin {
     );
 
     const needsCustomChangeKeySignatureVerification = allOutputDetails.some(
-      (output) => (output as WalletOutput)?.needsCustomChangeKeySignatureVerification
+      (output) => (output as FixedScriptWalletOutput)?.needsCustomChangeKeySignatureVerification
     );
 
     const changeOutputs = _.filter(allOutputDetails, { external: false });

modules/abstract-utxo/src/transaction/fixedScript/explainTransaction.ts

@@ -7,7 +7,7 @@ import {
   ExplainTransactionOptions,
   Output,
   TransactionExplanation,
-  WalletOutput,
+  FixedScriptWalletOutput,
 } from '../../abstractUtxoCoin';
 import { toExtendedAddressFormat } from '../recipient';
 
@@ -19,7 +19,7 @@ function explainCommon<TNumber extends number | bigint>(
   const displayOrder = ['id', 'outputAmount', 'changeAmount', 'outputs', 'changeOutputs'];
   let spendAmount = BigInt(0);
   let changeAmount = BigInt(0);
-  const changeOutputs: WalletOutput[] = [];
+  const changeOutputs: FixedScriptWalletOutput[] = [];
   const outputs: Output[] = [];
 
   const { changeInfo } = params;