Skip to content

Commit ef0f38d

Browse files
Merge pull request #7142 from BitGo/WIN-7449
fix: update fullname of binance smart chain and bnb token
2 parents 9b2f238 + 0a19d00 commit ef0f38d

File tree

5 files changed

+9
-16
lines changed

5 files changed

+9
-16
lines changed

modules/sdk-coin-bsc/test/unit/bsc.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import { Bsc, Tbsc } from '../../src/index';
77

88
const bitgo: TestBitGoAPI = TestBitGo.decorate(BitGoAPI, { env: 'test' });
99

10-
describe('Binance Smart Chain', function () {
10+
describe('Native BNB', function () {
1111
before(function () {
1212
bitgo.safeRegister('bsc', Bsc.createInstance);
1313
bitgo.safeRegister('tbsc', Tbsc.createInstance);
@@ -21,7 +21,7 @@ describe('Binance Smart Chain', function () {
2121
bsc.should.be.an.instanceof(Bsc);
2222
bsc.getChain().should.equal('bsc');
2323
bsc.getFamily().should.equal('bsc');
24-
bsc.getFullName().should.equal('Binance Smart Chain');
24+
bsc.getFullName().should.equal('Native BNB');
2525
bsc.getBaseFactor().should.equal(1e18);
2626
bsc.supportsTss().should.equal(true);
2727
bsc.allowsAccountConsolidations().should.equal(true);
@@ -33,7 +33,7 @@ describe('Binance Smart Chain', function () {
3333
tbsc.should.be.an.instanceof(Tbsc);
3434
tbsc.getChain().should.equal('tbsc');
3535
tbsc.getFamily().should.equal('bsc');
36-
tbsc.getFullName().should.equal('Testnet Binance Smart Chain');
36+
tbsc.getFullName().should.equal('Testnet Native BNB');
3737
tbsc.getBaseFactor().should.equal(1e18);
3838
tbsc.supportsTss().should.equal(true);
3939
tbsc.allowsAccountConsolidations().should.equal(true);

modules/statics/src/allCoinsAndTokens.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1202,7 +1202,7 @@ export const allCoinsAndTokens = [
12021202
account(
12031203
'd0d44124-c7e9-4214-96ae-fbc6856ee3c2',
12041204
'bsc',
1205-
'Binance Smart Chain',
1205+
'Native BNB',
12061206
Networks.main.bsc,
12071207
18,
12081208
UnderlyingAsset.BSC,
@@ -1212,7 +1212,7 @@ export const allCoinsAndTokens = [
12121212
account(
12131213
'0a205427-f7c9-48a4-a238-c4b33ba6384d',
12141214
'tbsc',
1215-
'Testnet Binance Smart Chain',
1215+
'Testnet Native BNB',
12161216
Networks.test.bsc,
12171217
18,
12181218
UnderlyingAsset.BSC,

modules/statics/src/coins/erc20Coins.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -992,7 +992,7 @@ export const erc20Coins = [
992992
erc20(
993993
'462e1878-68eb-4c2b-9346-cee992195cdc',
994994
'bnb',
995-
'BNB Token',
995+
'BNB Token (ETH Network)',
996996
18,
997997
'0xb8c77482e45f1f44de1745f52c74426c631bdd52',
998998
UnderlyingAsset.BNB

modules/statics/src/coins/ofcCoins.ts

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -104,14 +104,7 @@ export const ofcCoins = [
104104
ofc('5958e6e9-c6d7-4372-8d1d-c681f595c481', 'ofchash', 'Provenance', 9, UnderlyingAsset.HASH, CoinKind.CRYPTO),
105105
ofc('4616eb4e-9244-449c-a503-02cb2d715b2c', 'ofcsei', 'Sei', 6, UnderlyingAsset.SEI, CoinKind.CRYPTO),
106106
ofc('50a00889-47d2-44b5-8dc8-1fb3b4f47b86', 'ofczeta', 'Zeta', 18, UnderlyingAsset.ZETA, CoinKind.CRYPTO),
107-
ofc(
108-
'03df4c0c-12be-4b24-b3c3-c59be198711b',
109-
'ofcbsc',
110-
'Binance Smart Chain',
111-
18,
112-
UnderlyingAsset.BSC,
113-
CoinKind.CRYPTO
114-
),
107+
ofc('03df4c0c-12be-4b24-b3c3-c59be198711b', 'ofcbsc', 'Native BNB', 18, UnderlyingAsset.BSC, CoinKind.CRYPTO),
115108
ofc('7b79bc25-5497-4350-b961-4bbed2bea994', 'ofcsui', 'Sui', 9, UnderlyingAsset.SUI, CoinKind.CRYPTO),
116109
ofc('31bae66e-a135-42f9-b9d3-1623ab9c7ecc', 'ofctrx', 'Tron', 6, UnderlyingAsset.TRX, CoinKind.CRYPTO),
117110
ofc('dbbceebe-9096-4d7b-ae9e-31eb8a3dc5ca', 'ofcsol', 'Solana', 9, UnderlyingAsset.SOL, CoinKind.CRYPTO),
@@ -491,7 +484,7 @@ export const ofcCoins = [
491484
tofc(
492485
'52e600bb-b006-452b-9f82-f81c20d0168d',
493486
'ofctbsc',
494-
'Testnet Binance Smart Chain',
487+
'Testnet Native BNB',
495488
18,
496489
UnderlyingAsset.BSC,
497490
CoinKind.CRYPTO

modules/statics/src/coins/ofcErc20Coins.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ export const ofcErc20Coins = [
5353
ofcerc20('ae72248b-19fb-4736-9430-caf68615a751', 'ofcbal', 'Balancer', 18, UnderlyingAsset.BAL),
5454
ofcerc20('8541eeed-0478-45fe-bff9-4bcc63ef3f67', 'ofcbico', 'Biconomy', 18, UnderlyingAsset.BICO),
5555
ofcerc20('48e33478-36b0-4332-a792-6b4d629c2376', 'ofcbit', 'BitDAO', 18, UnderlyingAsset.BIT),
56-
ofcerc20('4bc691c4-dcdd-4b78-be96-1e87269c3caf', 'ofcbnb', 'BNB Token', 18, UnderlyingAsset.BNB),
56+
ofcerc20('4bc691c4-dcdd-4b78-be96-1e87269c3caf', 'ofcbnb', 'BNB Token (ETH Network)', 18, UnderlyingAsset.BNB),
5757
ofcerc20('7a76184c-b4b2-4c87-81bc-0c496c605488', 'ofcbnt', 'Bancor', 18, UnderlyingAsset.BNT),
5858
ofcerc20('f142074d-8d94-442b-a0e3-3f09c98acaeb', 'ofcbtrst', 'Braintrust', 18, UnderlyingAsset.BTRST),
5959
ofcerc20('779e9fa5-e4f2-4c74-947a-5b5df61e66df', 'ofcbusd', 'Binance USD', 18, UnderlyingAsset.BUSD, undefined, [

0 commit comments

Comments
 (0)