fix(sdk-core): deprecate displayOrder in ITransactionExplanation

OttoAllmendinger · OttoAllmendinger · commit fa3376b4b265 · 2024-12-03T16:05:01.000+01:00
I could not find any usage of displayOrder outside of tests. Our UI does not seem to depend on it. Issue: BTC-1450
diff --git a/modules/sdk-core/src/bitgo/baseCoin/iBaseCoin.ts b/modules/sdk-core/src/bitgo/baseCoin/iBaseCoin.ts
@@ -82,7 +82,8 @@ export interface ITransactionFee<TAmount = string> {
 }
 
 export interface ITransactionExplanation<TFee = any, TAmount = any> {
-  displayOrder: string[];
+  /** @deprecated */
+  displayOrder?: string[];
   id: string;
   outputs: ITransactionRecipient[];
   outputAmount: TAmount;

Original file line number	Diff line number	Diff line change
`@@ -82,7 +82,8 @@ export interface ITransactionFee<TAmount = string> {`
`82`	`82`	`}`
`83`	`83`
`84`	`84`	`export interface ITransactionExplanation<TFee = any, TAmount = any> {`
`85`		`- displayOrder: string[];`
	`85`	`+ /** @deprecated */`
	`86`	`+ displayOrder?: string[];`
`86`	`87`	`id: string;`
`87`	`88`	`outputs: ITransactionRecipient[];`
`88`	`89`	`outputAmount: TAmount;`