fix(sdk-core): fix broken mocking for unit tests

TICKET: BTC-1527

Author: kcheng-bitgo

modules/bitgo/test/v2/unit/wallet.ts

@@ -1500,7 +1500,6 @@ describe('V2 Wallet:', function () {
     it('should pass unspents parameter when calling fanout unspents', async function () {
       const path = `/api/v2/${wallet.coin()}/wallet/${wallet.id()}/fanoutUnspents`;
       const response = nock(bgUrl)
-        .persist()
         .post(path, _.matches({ unspents })) // use _.matches to do a partial match on request body object instead of strict matching
         .reply(200);
 
@@ -1516,13 +1515,18 @@ describe('V2 Wallet:', function () {
 
     it('should only build tx (not sign/send) while fanning out unspents', async function () {
       const path = `/api/v2/${wallet.coin()}/wallet/${wallet.id()}/fanoutUnspents`;
-      const response = nock(bgUrl).persist().post(path, _.matches({ unspents })).reply(200);
+      const response = nock(bgUrl).post(path, _.matches({ unspents })).reply(200);
 
       const unusedNocks = nock(bgUrl);
       unusedNocks.get(`/api/v2/${wallet.coin()}/key/${wallet.keyIds()[0]}`).reply(200);
       unusedNocks.post(`/api/v2/${wallet.coin()}/wallet/${wallet.id()}/tx/send`).reply(200);
 
-      await wallet.fanoutUnspents({ address, unspents }, ManageUnspentsOptions.BUILD_ONLY);
+      try {
+        await wallet.fanoutUnspents({ address, unspents }, ManageUnspentsOptions.BUILD_ONLY);
+      } catch (e) {
+        // the fanoutUnspents method will probably throw an exception for not having all of the correct nocks
+        // we only care about /fanoutUnspents and whether unspents is an allowed parameter
+      }
 
       response.isDone().should.be.true();
       unusedNocks.pendingMocks().length.should.eql(2);
@@ -1585,6 +1589,7 @@ describe('V2 Wallet:', function () {
       await wallet.consolidateUnspents({ bulk: true, walletPassphrase });
 
       nocks.forEach((n) => {
+        console.log(n);
         n.isDone().should.be.true();
       });
     });