added eslint to project, set arc to run linter when diffing

Reviewers: benchan, arik

Reviewed By: arik

Subscribers: ben

Differential Revision: https://phabricator.bitgo.com/D6106

Author: Zac Leids

.arcanist-extensions

@@ -1,3 +1,7 @@
 {
-  "phabricator.uri" : "http://phabricator.bitgo.com"
+  "phabricator.uri" : "https://phabricator.bitgo.com",
+
+  "load": [
+    ".arcanist-extensions/eslint_linter"
+  ]
 }

.arcconfig

@@ -0,0 +1,23 @@
+{
+  "linters": {
+    "filename": {
+      "type": "filename"
+    },
+    "generated": {
+      "type": "generated"
+    },
+    "merge-conflict": {
+      "type": "merge-conflict"
+    },
+    "nolint": {
+      "type": "nolint"
+    },
+    "spelling": {
+      "type": "spelling"
+    },
+    "eslint": {
+      "type": "eslint",
+      "include": "(\\.js$)"
+    }
+  }
+}

.arclint

@@ -0,0 +1,4 @@
+node_modules
+.idea
+.arcanist-extensions
+public

.eslintignore

@@ -0,0 +1,31 @@
+{
+  "env": {
+    "browser": true,
+    "es6": true,
+    "node": true,
+    "mocha": true
+  },
+  "extends": "eslint:recommended",
+  "parserOptions": {
+    "sourceType": "module",
+    "ecmaVersion": 6
+  },
+  "rules": {
+    "indent": ["error", 2, {"SwitchCase": 1, "MemberExpression": "off"}],
+    "linebreak-style": ["error", "unix"],
+    "semi": ["error", "always"],
+    "eqeqeq": ["warn", "always"],
+    "curly": "error",
+    "no-extra-boolean-cast": "off",
+    "no-unused-vars": "warn",
+    "object-curly-spacing": ["error", "always", {"objectsInObjects": true, "arraysInObjects": true}],
+    "array-bracket-spacing": ["error", "never"],
+    "require-yield": "off",
+    "func-call-spacing": ["error", "never"],
+    "quotes": ["error", "single"],
+    "key-spacing": ["error", { "beforeColon": false, "afterColon": true, "mode": "strict" }],
+    "quote-props": ["error", "as-needed"],
+    "no-console": "off",
+    "no-empty": "warn"
+  }
+}

.eslintrc.json

@@ -0,0 +1,3 @@
+[submodule ".arcanist-extensions"]
+	path = .arcanist-extensions
+	url = https://github.com/tagview/arcanist-extensions.git

.gitmodules

@@ -1,6 +1,6 @@
 {
   "name": "bitgo",
-  "version": "3.4.11",
+  "version": "3.4.12",
   "description": "BitGo Javascript SDK",
   "main": "./src/index.js",
   "keywords": [
@@ -21,6 +21,7 @@
     "browserify": "13.1.0",
     "coveralls": "~2.13.1",
     "envify": "~3.4.0",
+    "eslint": "~4.3.0",
     "istanbul": "0.4.5",
     "karma": "~0.13.22",
     "karma-chrome-launcher": "~0.1.7",
@@ -60,7 +61,8 @@
     "test": "npm run test-node",
     "express": "node bin/bitgo-express -b 0.0.0.0",
     "test-node": "./node_modules/.bin/istanbul test ./node_modules/.bin/_mocha -- --timeout 20000 --reporter list --recursive test/",
-    "test-browser": "npm run compile-test && ./node_modules/karma/bin/karma start .karma.conf.js --log-level debug --single-run"
+    "test-browser": "npm run compile-test && ./node_modules/karma/bin/karma start .karma.conf.js --log-level debug --single-run",
+    "lint": "./node_modules/.bin/eslint --ext .js ."
   },
   "dependencies": {
     "argparse": "~0.1.16",