chore(abstract-lightning): dont include coin in path

BTC-0

TICKET: BTC-0

Author: davidkaplanbitgo

modules/abstract-lightning/src/wallet/lightning.ts

@@ -176,7 +176,7 @@ export class LightningWallet implements ILightningWallet {
 
   async createInvoice(params: CreateInvoiceBody): Promise<Invoice> {
     const createInvoiceResponse = await this.wallet.bitgo
-      .post(this.wallet.baseCoin.url(`/wallet/${this.wallet.id()}/lightning/invoice`))
+      .post(this.wallet.bitgo.url(`/wallet/${this.wallet.id()}/lightning/invoice`, 2))
       .send(t.exact(CreateInvoiceBody).encode(params))
       .result();
     return sdkcore.decodeOrElse(Invoice.name, Invoice, createInvoiceResponse, (error) => {
@@ -187,7 +187,7 @@ export class LightningWallet implements ILightningWallet {
 
   async getInvoice(paymentHash: string): Promise<InvoiceInfo> {
     const response = await this.wallet.bitgo
-      .get(this.wallet.baseCoin.url(`/wallet/${this.wallet.id()}/lightning/invoice/${paymentHash}`))
+      .get(this.wallet.bitgo.url(`/wallet/${this.wallet.id()}/lightning/invoice/${paymentHash}`, 2))
       .result();
     return decodeOrElse(InvoiceInfo.name, InvoiceInfo, response, (error) => {
       throw new Error(`Invalid get invoice response ${error}`);
@@ -197,7 +197,7 @@ export class LightningWallet implements ILightningWallet {
   async listInvoices(params: InvoiceQuery): Promise<InvoiceInfo[]> {
     const returnCodec = t.array(InvoiceInfo);
     const createInvoiceResponse = await this.wallet.bitgo
-      .get(this.wallet.baseCoin.url(`/wallet/${this.wallet.id()}/lightning/invoice`))
+      .get(this.wallet.bitgo.url(`/wallet/${this.wallet.id()}/lightning/invoice`, 2))
       .query(InvoiceQuery.encode(params))
       .result();
     return sdkcore.decodeOrElse(returnCodec.name, returnCodec, createInvoiceResponse, (error) => {
@@ -264,7 +264,7 @@ export class LightningWallet implements ILightningWallet {
 
   async getPayment(paymentHash: string): Promise<PaymentInfo> {
     const response = await this.wallet.bitgo
-      .get(this.wallet.baseCoin.url(`/wallet/${this.wallet.id()}/lightning/payment/${paymentHash}`))
+      .get(this.wallet.bitgo.url(`/wallet/${this.wallet.id()}/lightning/payment/${paymentHash}`, 2))
       .result();
     return decodeOrElse(PaymentInfo.name, PaymentInfo, response, (error) => {
       throw new Error(`Invalid payment response: ${error}`);
@@ -273,7 +273,7 @@ export class LightningWallet implements ILightningWallet {
 
   async listPayments(params: PaymentQuery): Promise<PaymentInfo[]> {
     const response = await this.wallet.bitgo
-      .get(this.wallet.baseCoin.url(`/wallet/${this.wallet.id()}/lightning/payment`))
+      .get(this.wallet.bitgo.url(`/wallet/${this.wallet.id()}/lightning/payment`, 2))
       .query(PaymentQuery.encode(params))
       .result();
     return decodeOrElse(t.array(PaymentInfo).name, t.array(PaymentInfo), response, (error) => {
@@ -283,7 +283,7 @@ export class LightningWallet implements ILightningWallet {
 
   async getTransaction(txId: string): Promise<Transaction> {
     const response = await this.wallet.bitgo
-      .get(this.wallet.baseCoin.url(`/wallet/${this.wallet.id()}/lightning/transaction/${txId}`))
+      .get(this.wallet.bitgo.url(`/wallet/${this.wallet.id()}/lightning/transaction/${txId}`, 2))
       .result();
     return decodeOrElse(Transaction.name, Transaction, response, (error) => {
       throw new Error(`Invalid transaction response: ${error}`);
@@ -292,7 +292,7 @@ export class LightningWallet implements ILightningWallet {
 
   async listTransactions(params: TransactionQuery): Promise<Transaction[]> {
     const response = await this.wallet.bitgo
-      .get(this.wallet.baseCoin.url(`/wallet/${this.wallet.id()}/lightning/transaction`))
+      .get(this.wallet.bitgo.url(`/wallet/${this.wallet.id()}/lightning/transaction`, 2))
       .query(TransactionQuery.encode(params))
       .result();
     return decodeOrElse(t.array(Transaction).name, t.array(Transaction), response, (error) => {

modules/bitgo/test/v2/unit/lightning/lightningWallets.ts

@@ -262,9 +262,13 @@ describe('Lightning wallets', function () {
         createdAt: new Date(),
         updatedAt: new Date(),
       };
-      const query = { status: 'open', startDate: new Date(), limit: 100n } as InvoiceQuery;
+      const query = {
+        status: 'open',
+        startDate: new Date(),
+        limit: 100n,
+      } as InvoiceQuery;
       const listInvoicesNock = nock(bgUrl)
-        .get(`/api/v2/${coinName}/wallet/${wallet.wallet.id()}/lightning/invoice`)
+        .get(`/api/v2/wallet/${wallet.wallet.id()}/lightning/invoice`)
         .query(InvoiceQuery.encode(query))
         .reply(200, [InvoiceInfo.encode(invoice)]);
       const invoiceResponse = await wallet.listInvoices(query);
@@ -275,7 +279,7 @@ describe('Lightning wallets', function () {
 
     it('listInvoices should throw error if wp response is invalid', async function () {
       const listInvoicesNock = nock(bgUrl)
-        .get(`/api/v2/${coinName}/wallet/${wallet.wallet.id()}/lightning/invoice`)
+        .get(`/api/v2/wallet/${wallet.wallet.id()}/lightning/invoice`)
         .reply(200, [{ valueMsat: '1000' }]);
       await assert.rejects(async () => await wallet.listInvoices({}), /Invalid list invoices response/);
       listInvoicesNock.done();
@@ -296,10 +300,7 @@ describe('Lightning wallets', function () {
         valueMsat: 1000n,
       };
       const createInvoiceNock = nock(bgUrl)
-        .post(
-          `/api/v2/${coinName}/wallet/${wallet.wallet.id()}/lightning/invoice`,
-          CreateInvoiceBody.encode(createInvoice)
-        )
+        .post(`/api/v2/wallet/${wallet.wallet.id()}/lightning/invoice`, CreateInvoiceBody.encode(createInvoice))
         .reply(200, Invoice.encode(invoice));
       const createInvoiceResponse = await wallet.createInvoice(createInvoice);
       assert.deepStrictEqual(createInvoiceResponse, invoice);
@@ -313,7 +314,7 @@ describe('Lightning wallets', function () {
         expiry: 100,
       };
       const createInvoiceNock = nock(bgUrl)
-        .post(`/api/v2/${coinName}/wallet/${wallet.wallet.id()}/lightning/invoice`)
+        .post(`/api/v2/wallet/${wallet.wallet.id()}/lightning/invoice`)
         .reply(200, { valueMsat: '1000' });
       await assert.rejects(async () => await wallet.createInvoice(createInvoice), /Invalid create invoice response/);
       createInvoiceNock.done();