feat(express): migrated consolidateunspents as type route#7374
Merged
lokesh-bitgo merged 1 commit intomasterfrom Oct 29, 2025
Conversation
Contributor
Author
There was a problem hiding this comment.
Pull Request Overview
This PR adds a V2 API endpoint for consolidating unspents in wallets with typed routes. The endpoint follows the V2 API pattern by including a coin parameter in the URL path and uses typed request/response handling.
Key changes:
- New typed route definition for POST
/api/v2/{coin}/wallet/{id}/consolidateunspents - Comprehensive test suite with 1150 lines covering request/response validation, bulk mode, error cases, and codec tests
- Migration from untyped express route to typed route handler with proper parameter decoding
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| modules/express/src/typedRoutes/api/v2/consolidateunspents.ts | Defines typed route, request/response schemas with support for single and bulk consolidation modes |
| modules/express/test/unit/typedRoutes/consolidateunspentsV2.ts | Comprehensive test suite validating codecs, API behavior, framework integration, and edge cases |
| modules/express/src/typedRoutes/api/index.ts | Registers the new V2 endpoint in the API spec alongside the existing V1 endpoint |
| modules/express/src/clientRoutes.ts | Updates handler to use typed route with decoded parameters and registers route with typed router |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
danielzhao122
approved these changes
Oct 29, 2025
adityasoni-bitgo
approved these changes
Oct 29, 2025
zahin-mohammad
approved these changes
Oct 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: WP-5430