feat(express): update change keychain password for ofc multi-user-key… #7584
+184
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Taseen08
reviewed
Nov 20, 2025
Contributor
Taseen08
left a comment
Taseen08
left a comment
There was a problem hiding this comment.
One comment re: the encryptedPrivKeys.json. Looks good otherwise
alextse-bg
force-pushed
the
WP-6901
branch
4 times, most recently
from
d01fafc to
b0db0e1
Compare
zahin-mohammad
approved these changes
Nov 24, 2025
zahin-mohammad
previously approved these changes
Nov 24, 2025
adityasoni-bitgo
previously approved these changes
Nov 24, 2025
alextse-bg
dismissed stale reviews from zahin-mohammad, Taseen08, and adityasoni-bitgo
via
3d9b72e
Contributor
|
CI seems to be failing here |
… wallet added pub as a part of the request to update keychain password for ofc multi-user-key wallet, since mutliple pub-prv key pairs can exist in the same keychain document for those wallet. Ticket: WP-6901
alextse-bg
requested review from
Taseen08,
adityasoni-bitgo and
zahin-mohammad
Taseen08
approved these changes
Nov 26, 2025
zahin-mohammad
approved these changes
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… wallet
added pub as a part of the request to update keychain password for ofc multi-user-key wallet
Ticket: WP-6901