Merge pull request #7 from BitGo/BTC-2650.bump-miniscript-crate

feat: bump miniscript crate to 12.3.4

Author: OttoAllmendinger

packages/wasm-utxo/Cargo.lock

@@ -9,7 +9,7 @@ crate-type = ["cdylib"]
 [dependencies]
 wasm-bindgen = "0.2"
 js-sys = "0.3"
-miniscript = { git = "https://github.com/BitGo/rust-miniscript", branch = "opdrop" }
+miniscript = { git = "https://github.com/BitGo/rust-miniscript", tag = "miniscript-12.3.4-opdrop" }
 
 [dev-dependencies]
 base64 = "0.22.1"

packages/wasm-utxo/Cargo.toml

@@ -1,11 +1,11 @@
 {
-  "descriptor": "pkh([deadbeef/1/2'/3/4']03a34b99f22c790c4e36b2b3c2c35a36db06226e41c692fc82b8b56ac1c540c5bd)#v0p5w8jl",
+  "descriptor": "pkh(03a34b99f22c790c4e36b2b3c2c35a36db06226e41c692fc82b8b56ac1c540c5bd)#wf36a0pg",
   "wasmNode": {
     "Pkh": {
-      "Single": "[deadbeef/1/2'/3/4']03a34b99f22c790c4e36b2b3c2c35a36db06226e41c692fc82b8b56ac1c540c5bd"
+      "Single": "03a34b99f22c790c4e36b2b3c2c35a36db06226e41c692fc82b8b56ac1c540c5bd"
     }
   },
   "ast": {
-    "pkh": "[deadbeef/1/2'/3/4']03a34b99f22c790c4e36b2b3c2c35a36db06226e41c692fc82b8b56ac1c540c5bd"
+    "pkh": "03a34b99f22c790c4e36b2b3c2c35a36db06226e41c692fc82b8b56ac1c540c5bd"
   }
 }

packages/wasm-utxo/test/fixtures/2.json

@@ -13,9 +13,6 @@ function getDescriptorOpDropP2ms(locktime: number, keys: utxolib.BIP32Interface[
 }
 
 describe("CLV with OP_DROP", function () {
-  // OP_DROP enabled in this branch
-  // return;
-
   const locktime = 1024;
   const descriptor = Descriptor.fromString(
     getDescriptorOpDropP2ms(locktime, rootWalletKeys.triple),

packages/wasm-utxo/test/opdrop.ts

@@ -99,11 +99,11 @@ describe("Descriptor fixtures", function () {
       it("should parse (pkType derivable)", async function () {
         const descriptor = Descriptor.fromString(fixture.descriptor, "derivable");
 
-        assert.doesNotThrow(() =>
-          Descriptor.fromString(fixture.descriptor, "derivable").atDerivationIndex(0),
-        );
-
         if (isDerivable(i)) {
+          assert.doesNotThrow(() =>
+            Descriptor.fromString(fixture.descriptor, "derivable").atDerivationIndex(0),
+          );
+
           if (descriptor.descType() !== "Tr") {
             assert.doesNotThrow(() => descriptor.atDerivationIndex(0).encode());
           }