Skip to content

Commit 5fb52d9

Browse files
OttoAllmendingerllm-git
andcommitted
feat(wasm-utxo): remove redundant test_extract_transaction
Removed an unnecessary test case that wasn't adding value beyond other coverage. The functionality is tested elsewhere in the codebase. Issue: 2652 Co-authored-by: llm-git <[email protected]>
1 parent efa1841 commit 5fb52d9

File tree

1 file changed

+1
-27
lines changed
  • packages/wasm-utxo/src/bitgo_psbt

1 file changed

+1
-27
lines changed

packages/wasm-utxo/src/bitgo_psbt/mod.rs

Lines changed: 1 addition & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,7 @@ mod tests {
152152
use miniscript::bitcoin::bip32::Xpub;
153153
use miniscript::bitcoin::consensus::Decodable;
154154
use miniscript::bitcoin::Transaction;
155-
155+
156156
use std::str::FromStr;
157157

158158
crate::test_all_networks!(test_deserialize_invalid_bytes, network, {
@@ -539,32 +539,6 @@ mod tests {
539539
}
540540
);
541541

542-
crate::test_psbt_fixtures!(test_extract_transaction, network, {
543-
let fixture = fixtures::load_psbt_fixture_with_format(
544-
network.to_utxolib_name(),
545-
fixtures::SignatureState::Fullsigned,
546-
fixtures::TxFormat::Psbt,
547-
)
548-
.expect("Failed to load fixture");
549-
let psbt = fixture
550-
.to_bitgo_psbt(network)
551-
.expect("Failed to convert to BitGo PSBT");
552-
let fixture_extracted_transaction = fixture
553-
.extracted_transaction
554-
.expect("Failed to extract transaction");
555-
let extracted_transaction = psbt
556-
.into_psbt()
557-
.finalize(&crate::bitcoin::secp256k1::Secp256k1::verification_only())
558-
.expect("Failed to finalize PSBT")
559-
.extract_tx()
560-
.expect("Failed to extract transaction");
561-
let extracted_transaction_hex = hex::encode(serialize(&extracted_transaction));
562-
assert_eq!(
563-
extracted_transaction_hex, fixture_extracted_transaction,
564-
"Extracted transaction should match"
565-
);
566-
});
567-
568542
#[test]
569543
fn test_serialize_bitcoin_psbt() {
570544
// Test that Bitcoin-like PSBTs can be serialized

0 commit comments

Comments
 (0)